From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from walk.intel-email.com (walk.intel-email.com [101.227.64.242]) by mx.groups.io with SMTP id smtpd.web08.1712.1668562483646968496 for ; Tue, 15 Nov 2022 17:34:47 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=kVpj/rya; spf=pass (domain: byosoft.com.cn, ip: 101.227.64.242, mailfrom: gaoliming@byosoft.com.cn) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 98797CD1F663 for ; Wed, 16 Nov 2022 09:34:40 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1668562480; bh=OnHwrx9vtfI+yuJ+ijFzWoE3xAKINp+YVgUYFvitdtc=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=kVpj/ryaLgU1uZCnF4GuRYRGFCSICX99Tw2jeemWQGh1DrCdeBkyEYljpQu4nGLj+ SRalTY62W4lBq0B4mukIkKKlhbMPbh6D5tuyLduIutlHOdSl+xny3OL/PYmPeL851E 2Eq2sRV8nMMYEFkx+OTuUr6ROJZP7wFagOEnGTlQ= Received: from localhost (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 945BBCD1F688 for ; Wed, 16 Nov 2022 09:34:40 +0800 (CST) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 69E62CD1F64D for ; Wed, 16 Nov 2022 09:34:40 +0800 (CST) Authentication-Results: walk.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by walk.intel-email.com (Postfix) with SMTP id 023C2CD1F6D0 for ; Wed, 16 Nov 2022 09:34:37 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Wed, 16 Nov 2022 09:34:29 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , , Cc: "'Ard Biesheuvel'" , "'Leif Lindholm'" , "'Sami Mujawar'" References: <20221114144347.1664317-1-Pierre.Gondois@arm.com> <1727A2869BB78C87.23030@groups.io> In-Reply-To: <1727A2869BB78C87.23030@groups.io> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIDEvMV1bZWRrMi1zdGFibGUyMDIyMTFdIEFybVBrZy9Bcm1Ucm5nTGliOiBSZW1vdmUgQVNTRVJUIGluIEdldEFybVRybmdWZXJzaW9uKCk=?= Date: Wed, 16 Nov 2022 09:34:29 +0800 Message-ID: <020601d8f95b$92a1ff60$b7e5fe20$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQEvOXqpZMdmV+Z0NEbEaBaAGsUUFgIXrGunAiolu7qvcjWNIA== Sender: "gaoliming" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn PR https://github.com/tianocore/edk2/pull/3641 is created to merge it.=20 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 gaoliming via > groups.io > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B411=E6=9C=8815=E6=97=A5= 10:55 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; ardb@kernel.org; Pierr= e.Gondois@arm.com > =E6=8A=84=E9=80=81: 'Ard Biesheuvel' ; 'Leif L= indholm' > ; 'Sami Mujawar' > =E4=B8=BB=E9=A2=98: =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH 1/1][edk2-sta= ble202211] > ArmPkg/ArmTrngLib: Remove ASSERT in GetArmTrngVersion() >=20 > Ard: > I am OK to merge it for this stable tag. I will do it. >=20 > Thanks > Liming > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =E4=BB=A3=E8=A1=A8 Ard > > Biesheuvel > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B411=E6=9C=8814=E6=97= =A5 23:10 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: Pierre.Gondois@arm.com > > =E6=8A=84=E9=80=81: devel@edk2.groups.io; Ard Biesheuvel > ; > > Leif Lindholm ; Sami Mujawar > > ; Liming Gao > > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH 1/1][edk2-stable202211] > ArmPkg/ArmTrngLib: > > Remove ASSERT in GetArmTrngVersion() > > > > On Mon, 14 Nov 2022 at 15:44, wrote: > > > > > > From: Pierre Gondois > > > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4150 > > > > > > GetArmTrngVersion() is used to check the presence of an Arm > > > Trng. If not found, an ASSERT prevents from booting in DEBUG > > > builds. > > > Remove this ASSERT. > > > > > > Reported-by: Sami Mujawar > > > Signed-off-by: Pierre Gondois > > > > Acked-by: Ard Biesheuvel > > > > Liming: please merge this if you are ok with it, or I can merge it if > > you prefer. > > > > > --- > > > ArmPkg/Library/ArmTrngLib/ArmTrngLib.c | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c > > b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c > > > index fdabc02cd39c..3278722320c8 100644 > > > --- a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c > > > +++ b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c > > > @@ -344,7 +344,6 @@ ArmTrngLibConstructor ( > > > > > > Status =3D GetArmTrngVersion (&MajorRev, &MinorRev); > > > if (RETURN_ERROR (Status)) { > > > - ASSERT_RETURN_ERROR (Status); > > > goto ErrorHandler; > > > } > > > > > > -- > > > 2.25.1 > > > > > > > > > > > >=20 >=20 >=20 >=20 >=20 >=20 >=20