* [PATCH 1/1][edk2-stable202211] ArmPkg/ArmTrngLib: Remove ASSERT in GetArmTrngVersion()
@ 2022-11-14 14:43 PierreGondois
2022-11-14 15:10 ` Ard Biesheuvel
2022-11-14 16:00 ` Sami Mujawar
0 siblings, 2 replies; 6+ messages in thread
From: PierreGondois @ 2022-11-14 14:43 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Leif Lindholm, Sami Mujawar, Liming Gao
From: Pierre Gondois <pierre.gondois@arm.com>
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4150
GetArmTrngVersion() is used to check the presence of an Arm
Trng. If not found, an ASSERT prevents from booting in DEBUG
builds.
Remove this ASSERT.
Reported-by: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
ArmPkg/Library/ArmTrngLib/ArmTrngLib.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
index fdabc02cd39c..3278722320c8 100644
--- a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
+++ b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
@@ -344,7 +344,6 @@ ArmTrngLibConstructor (
Status = GetArmTrngVersion (&MajorRev, &MinorRev);
if (RETURN_ERROR (Status)) {
- ASSERT_RETURN_ERROR (Status);
goto ErrorHandler;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/1][edk2-stable202211] ArmPkg/ArmTrngLib: Remove ASSERT in GetArmTrngVersion()
2022-11-14 14:43 [PATCH 1/1][edk2-stable202211] ArmPkg/ArmTrngLib: Remove ASSERT in GetArmTrngVersion() PierreGondois
@ 2022-11-14 15:10 ` Ard Biesheuvel
2022-11-15 2:54 ` 回复: [edk2-devel] " gaoliming
[not found] ` <1727A2869BB78C87.23030@groups.io>
2022-11-14 16:00 ` Sami Mujawar
1 sibling, 2 replies; 6+ messages in thread
From: Ard Biesheuvel @ 2022-11-14 15:10 UTC (permalink / raw)
To: Pierre.Gondois
Cc: devel, Ard Biesheuvel, Leif Lindholm, Sami Mujawar, Liming Gao
On Mon, 14 Nov 2022 at 15:44, <Pierre.Gondois@arm.com> wrote:
>
> From: Pierre Gondois <pierre.gondois@arm.com>
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4150
>
> GetArmTrngVersion() is used to check the presence of an Arm
> Trng. If not found, an ASSERT prevents from booting in DEBUG
> builds.
> Remove this ASSERT.
>
> Reported-by: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
Liming: please merge this if you are ok with it, or I can merge it if
you prefer.
> ---
> ArmPkg/Library/ArmTrngLib/ArmTrngLib.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> index fdabc02cd39c..3278722320c8 100644
> --- a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> +++ b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> @@ -344,7 +344,6 @@ ArmTrngLibConstructor (
>
> Status = GetArmTrngVersion (&MajorRev, &MinorRev);
> if (RETURN_ERROR (Status)) {
> - ASSERT_RETURN_ERROR (Status);
> goto ErrorHandler;
> }
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread* 回复: [edk2-devel] [PATCH 1/1][edk2-stable202211] ArmPkg/ArmTrngLib: Remove ASSERT in GetArmTrngVersion()
2022-11-14 15:10 ` Ard Biesheuvel
@ 2022-11-15 2:54 ` gaoliming
[not found] ` <1727A2869BB78C87.23030@groups.io>
1 sibling, 0 replies; 6+ messages in thread
From: gaoliming @ 2022-11-15 2:54 UTC (permalink / raw)
To: devel, ardb, Pierre.Gondois
Cc: 'Ard Biesheuvel', 'Leif Lindholm',
'Sami Mujawar'
Ard:
I am OK to merge it for this stable tag. I will do it.
Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Ard
> Biesheuvel
> 发送时间: 2022年11月14日 23:10
> 收件人: Pierre.Gondois@arm.com
> 抄送: devel@edk2.groups.io; Ard Biesheuvel <ardb+tianocore@kernel.org>;
> Leif Lindholm <leif@nuviainc.com>; Sami Mujawar
> <sami.mujawar@arm.com>; Liming Gao <gaoliming@byosoft.com.cn>
> 主题: Re: [edk2-devel] [PATCH 1/1][edk2-stable202211] ArmPkg/ArmTrngLib:
> Remove ASSERT in GetArmTrngVersion()
>
> On Mon, 14 Nov 2022 at 15:44, <Pierre.Gondois@arm.com> wrote:
> >
> > From: Pierre Gondois <pierre.gondois@arm.com>
> >
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4150
> >
> > GetArmTrngVersion() is used to check the presence of an Arm
> > Trng. If not found, an ASSERT prevents from booting in DEBUG
> > builds.
> > Remove this ASSERT.
> >
> > Reported-by: Sami Mujawar <sami.mujawar@arm.com>
> > Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
>
> Acked-by: Ard Biesheuvel <ardb@kernel.org>
>
> Liming: please merge this if you are ok with it, or I can merge it if
> you prefer.
>
> > ---
> > ArmPkg/Library/ArmTrngLib/ArmTrngLib.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> > index fdabc02cd39c..3278722320c8 100644
> > --- a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> > +++ b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> > @@ -344,7 +344,6 @@ ArmTrngLibConstructor (
> >
> > Status = GetArmTrngVersion (&MajorRev, &MinorRev);
> > if (RETURN_ERROR (Status)) {
> > - ASSERT_RETURN_ERROR (Status);
> > goto ErrorHandler;
> > }
> >
> > --
> > 2.25.1
> >
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread[parent not found: <1727A2869BB78C87.23030@groups.io>]
* 回复: [edk2-devel] [PATCH 1/1][edk2-stable202211] ArmPkg/ArmTrngLib: Remove ASSERT in GetArmTrngVersion()
[not found] ` <1727A2869BB78C87.23030@groups.io>
@ 2022-11-16 1:34 ` gaoliming
2022-11-16 9:12 ` Ard Biesheuvel
0 siblings, 1 reply; 6+ messages in thread
From: gaoliming @ 2022-11-16 1:34 UTC (permalink / raw)
To: devel, gaoliming, ardb, Pierre.Gondois
Cc: 'Ard Biesheuvel', 'Leif Lindholm',
'Sami Mujawar'
PR https://github.com/tianocore/edk2/pull/3641 is created to merge it.
Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 gaoliming via
> groups.io
> 发送时间: 2022年11月15日 10:55
> 收件人: devel@edk2.groups.io; ardb@kernel.org; Pierre.Gondois@arm.com
> 抄送: 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Leif Lindholm'
> <leif@nuviainc.com>; 'Sami Mujawar' <sami.mujawar@arm.com>
> 主题: 回复: [edk2-devel] [PATCH 1/1][edk2-stable202211]
> ArmPkg/ArmTrngLib: Remove ASSERT in GetArmTrngVersion()
>
> Ard:
> I am OK to merge it for this stable tag. I will do it.
>
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Ard
> > Biesheuvel
> > 发送时间: 2022年11月14日 23:10
> > 收件人: Pierre.Gondois@arm.com
> > 抄送: devel@edk2.groups.io; Ard Biesheuvel
> <ardb+tianocore@kernel.org>;
> > Leif Lindholm <leif@nuviainc.com>; Sami Mujawar
> > <sami.mujawar@arm.com>; Liming Gao <gaoliming@byosoft.com.cn>
> > 主题: Re: [edk2-devel] [PATCH 1/1][edk2-stable202211]
> ArmPkg/ArmTrngLib:
> > Remove ASSERT in GetArmTrngVersion()
> >
> > On Mon, 14 Nov 2022 at 15:44, <Pierre.Gondois@arm.com> wrote:
> > >
> > > From: Pierre Gondois <pierre.gondois@arm.com>
> > >
> > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4150
> > >
> > > GetArmTrngVersion() is used to check the presence of an Arm
> > > Trng. If not found, an ASSERT prevents from booting in DEBUG
> > > builds.
> > > Remove this ASSERT.
> > >
> > > Reported-by: Sami Mujawar <sami.mujawar@arm.com>
> > > Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
> >
> > Acked-by: Ard Biesheuvel <ardb@kernel.org>
> >
> > Liming: please merge this if you are ok with it, or I can merge it if
> > you prefer.
> >
> > > ---
> > > ArmPkg/Library/ArmTrngLib/ArmTrngLib.c | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> > b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> > > index fdabc02cd39c..3278722320c8 100644
> > > --- a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> > > +++ b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> > > @@ -344,7 +344,6 @@ ArmTrngLibConstructor (
> > >
> > > Status = GetArmTrngVersion (&MajorRev, &MinorRev);
> > > if (RETURN_ERROR (Status)) {
> > > - ASSERT_RETURN_ERROR (Status);
> > > goto ErrorHandler;
> > > }
> > >
> > > --
> > > 2.25.1
> > >
> >
> >
> >
> >
>
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [edk2-devel] [PATCH 1/1][edk2-stable202211] ArmPkg/ArmTrngLib: Remove ASSERT in GetArmTrngVersion()
2022-11-16 1:34 ` gaoliming
@ 2022-11-16 9:12 ` Ard Biesheuvel
0 siblings, 0 replies; 6+ messages in thread
From: Ard Biesheuvel @ 2022-11-16 9:12 UTC (permalink / raw)
To: devel, gaoliming
Cc: Pierre.Gondois, Ard Biesheuvel, Leif Lindholm, Sami Mujawar
On Wed, 16 Nov 2022 at 02:34, gaoliming via groups.io
<gaoliming=byosoft.com.cn@groups.io> wrote:
>
> PR https://github.com/tianocore/edk2/pull/3641 is created to merge it.
>
Thank you Liming.
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 gaoliming via
> > groups.io
> > 发送时间: 2022年11月15日 10:55
> > 收件人: devel@edk2.groups.io; ardb@kernel.org; Pierre.Gondois@arm.com
> > 抄送: 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Leif Lindholm'
> > <leif@nuviainc.com>; 'Sami Mujawar' <sami.mujawar@arm.com>
> > 主题: 回复: [edk2-devel] [PATCH 1/1][edk2-stable202211]
> > ArmPkg/ArmTrngLib: Remove ASSERT in GetArmTrngVersion()
> >
> > Ard:
> > I am OK to merge it for this stable tag. I will do it.
> >
> > Thanks
> > Liming
> > > -----邮件原件-----
> > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Ard
> > > Biesheuvel
> > > 发送时间: 2022年11月14日 23:10
> > > 收件人: Pierre.Gondois@arm.com
> > > 抄送: devel@edk2.groups.io; Ard Biesheuvel
> > <ardb+tianocore@kernel.org>;
> > > Leif Lindholm <leif@nuviainc.com>; Sami Mujawar
> > > <sami.mujawar@arm.com>; Liming Gao <gaoliming@byosoft.com.cn>
> > > 主题: Re: [edk2-devel] [PATCH 1/1][edk2-stable202211]
> > ArmPkg/ArmTrngLib:
> > > Remove ASSERT in GetArmTrngVersion()
> > >
> > > On Mon, 14 Nov 2022 at 15:44, <Pierre.Gondois@arm.com> wrote:
> > > >
> > > > From: Pierre Gondois <pierre.gondois@arm.com>
> > > >
> > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4150
> > > >
> > > > GetArmTrngVersion() is used to check the presence of an Arm
> > > > Trng. If not found, an ASSERT prevents from booting in DEBUG
> > > > builds.
> > > > Remove this ASSERT.
> > > >
> > > > Reported-by: Sami Mujawar <sami.mujawar@arm.com>
> > > > Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
> > >
> > > Acked-by: Ard Biesheuvel <ardb@kernel.org>
> > >
> > > Liming: please merge this if you are ok with it, or I can merge it if
> > > you prefer.
> > >
> > > > ---
> > > > ArmPkg/Library/ArmTrngLib/ArmTrngLib.c | 1 -
> > > > 1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> > > b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> > > > index fdabc02cd39c..3278722320c8 100644
> > > > --- a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> > > > +++ b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> > > > @@ -344,7 +344,6 @@ ArmTrngLibConstructor (
> > > >
> > > > Status = GetArmTrngVersion (&MajorRev, &MinorRev);
> > > > if (RETURN_ERROR (Status)) {
> > > > - ASSERT_RETURN_ERROR (Status);
> > > > goto ErrorHandler;
> > > > }
> > > >
> > > > --
> > > > 2.25.1
> > > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
> >
> >
>
>
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1][edk2-stable202211] ArmPkg/ArmTrngLib: Remove ASSERT in GetArmTrngVersion()
2022-11-14 14:43 [PATCH 1/1][edk2-stable202211] ArmPkg/ArmTrngLib: Remove ASSERT in GetArmTrngVersion() PierreGondois
2022-11-14 15:10 ` Ard Biesheuvel
@ 2022-11-14 16:00 ` Sami Mujawar
1 sibling, 0 replies; 6+ messages in thread
From: Sami Mujawar @ 2022-11-14 16:00 UTC (permalink / raw)
To: Pierre.Gondois, devel
Cc: Ard Biesheuvel, Leif Lindholm, Liming Gao, nd@arm.com
Hi Pierre,
Thank you for this fix.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 14/11/2022 02:43 pm, Pierre.Gondois@arm.com wrote:
> From: Pierre Gondois <pierre.gondois@arm.com>
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4150
>
> GetArmTrngVersion() is used to check the presence of an Arm
> Trng. If not found, an ASSERT prevents from booting in DEBUG
> builds.
> Remove this ASSERT.
>
> Reported-by: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
> ---
> ArmPkg/Library/ArmTrngLib/ArmTrngLib.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> index fdabc02cd39c..3278722320c8 100644
> --- a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> +++ b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> @@ -344,7 +344,6 @@ ArmTrngLibConstructor (
>
> Status = GetArmTrngVersion (&MajorRev, &MinorRev);
> if (RETURN_ERROR (Status)) {
> - ASSERT_RETURN_ERROR (Status);
> goto ErrorHandler;
> }
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-16 9:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-14 14:43 [PATCH 1/1][edk2-stable202211] ArmPkg/ArmTrngLib: Remove ASSERT in GetArmTrngVersion() PierreGondois
2022-11-14 15:10 ` Ard Biesheuvel
2022-11-15 2:54 ` 回复: [edk2-devel] " gaoliming
[not found] ` <1727A2869BB78C87.23030@groups.io>
2022-11-16 1:34 ` gaoliming
2022-11-16 9:12 ` Ard Biesheuvel
2022-11-14 16:00 ` Sami Mujawar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox