public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch 1/1] MdeModulePkg/CapsuleApp: Add EFIAPI to CompareFileNameInAlphabet()
@ 2023-05-05 17:10 Michael D Kinney
  2023-05-06  1:15 ` 回复: [edk2-devel] " gaoliming
  0 siblings, 1 reply; 2+ messages in thread
From: Michael D Kinney @ 2023-05-05 17:10 UTC (permalink / raw)
  To: devel; +Cc: Jian J Wang, Liming Gao, Guomin Jiang

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4446

CompareFileNameInAlphabet() is passed as a function pointer
parameter and typecast to type SORT_COMPARE that is declared
with EFIAPI.  Add EFIAPI to CompareFileNameInAlphabet() to match
SORT_COMPARE type.

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Guomin Jiang <guomin.jiang@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 MdeModulePkg/Application/CapsuleApp/CapsuleDump.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
index 26ad60ce592e..7605153e972b 100644
--- a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
+++ b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
@@ -632,6 +632,7 @@ SplitFileNameExtension (
 
 **/
 INTN
+EFIAPI
 CompareFileNameInAlphabet (
   IN VOID  *Left,
   IN VOID  *Right
-- 
2.40.1.windows.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* 回复: [edk2-devel] [Patch 1/1] MdeModulePkg/CapsuleApp: Add EFIAPI to CompareFileNameInAlphabet()
  2023-05-05 17:10 [Patch 1/1] MdeModulePkg/CapsuleApp: Add EFIAPI to CompareFileNameInAlphabet() Michael D Kinney
@ 2023-05-06  1:15 ` gaoliming
  0 siblings, 0 replies; 2+ messages in thread
From: gaoliming @ 2023-05-06  1:15 UTC (permalink / raw)
  To: devel, michael.d.kinney; +Cc: 'Jian J Wang', 'Guomin Jiang'

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Michael D
> Kinney
> 发送时间: 2023年5月6日 1:10
> 收件人: devel@edk2.groups.io
> 抄送: Jian J Wang <jian.j.wang@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Guomin Jiang <guomin.jiang@intel.com>
> 主题: [edk2-devel] [Patch 1/1] MdeModulePkg/CapsuleApp: Add EFIAPI to
> CompareFileNameInAlphabet()
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4446
> 
> CompareFileNameInAlphabet() is passed as a function pointer
> parameter and typecast to type SORT_COMPARE that is declared
> with EFIAPI.  Add EFIAPI to CompareFileNameInAlphabet() to match
> SORT_COMPARE type.
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  MdeModulePkg/Application/CapsuleApp/CapsuleDump.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
> b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
> index 26ad60ce592e..7605153e972b 100644
> --- a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
> +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
> @@ -632,6 +632,7 @@ SplitFileNameExtension (
> 
>  **/
>  INTN
> +EFIAPI
>  CompareFileNameInAlphabet (
>    IN VOID  *Left,
>    IN VOID  *Right
> --
> 2.40.1.windows.1
> 
> 
> 
> 
> 




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-05-06  1:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-05 17:10 [Patch 1/1] MdeModulePkg/CapsuleApp: Add EFIAPI to CompareFileNameInAlphabet() Michael D Kinney
2023-05-06  1:15 ` 回复: [edk2-devel] " gaoliming

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox