回复: [edk2-devel] [Patch v2 0/3] Address C++ keyword collisions

["gaoliming" <gaoliming@byosoft.com.cn>]

For the patch set, Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Oliver
> Smith-Denny
> 发送时间: 2023年6月1日 1:46
> 收件人: Michael D Kinney <michael.d.kinney@intel.com>;
> devel@edk2.groups.io
> 抄送: Liming Gao <gaoliming@byosoft.com.cn>; Zhiguang Liu
> <zhiguang.liu@intel.com>; Pedro Falcato <pedro.falcato@gmail.com>; Aaron
> Pop <aaronpop@microsoft.com>
> 主题: Re: [edk2-devel] [Patch v2 0/3] Address C++ keyword collisions
> 
> For the patchset:
> 
> Reviewed-by: Oliver Smith-Denny <osde@linux.microsoft.com>
> 
> Thanks!
> 
> On 5/30/2023 11:53 AM, Michael D Kinney wrote:
> > New in v2
> > ==========
> > Changes from 2 patches to 3 patches to support bisect.  This
> > temporarily uses an anonymous union to allow use of both field
> > name styles.  It also allows downstream usage of these fields
> > to sync with the first 2 patches, update their field names,
> > and then sync with last patch.
> >
> > PR: https://github.com/tianocore/edk2/pull/4436
> >
> > ===========
> >
> > Update Tpm12.h and Tpm20.h and not use c++ reserved keywords
> > operator and xor in C structures to support use of these
> > include files when building with a C++ compiler.
> >
> > Update SecurityPkg Tpm2CommandLib to use updated field names.
> >
> > * Change operator -> Operator
> > * Change xor -> Xor
> >
> > NOTE: This is a non-backwards compatible change to Tpm12.h
> > and Tmp20.h. And consumers of these include files that access
> > the "operator" or "xor" fields must be updated.
> >
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > Cc: Oliver Smith-Denny <osde@linux.microsoft.com>
> > Cc: Pedro Falcato <pedro.falcato@gmail.com>
> > Cc: Aaron Pop <aaronpop@microsoft.com>
> > Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> >
> > Michael D Kinney (3):
> >    MdePkg/Include/IndustryStandard: Add Operator and Xor field names
> >    SecurityPkg/Library/TpmCommandLib: Change xor to Xor
> >    MdePkg/Include/IndustryStandard: Address C++ keyword collisions
> >
> >   MdePkg/Include/IndustryStandard/Tpm12.h             | 4 ++--
> >   MdePkg/Include/IndustryStandard/Tpm20.h             | 4 ++--
> >   SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c | 6 +++---
> >   SecurityPkg/Library/Tpm2CommandLib/Tpm2Object.c     | 6 +++---
> >   SecurityPkg/Library/Tpm2CommandLib/Tpm2Session.c    | 2 +-
> >   5 files changed, 11 insertions(+), 11 deletions(-)
> >
> 
> 
> 
>