From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cxsh.intel-email.com (cxsh.intel-email.com [121.46.250.151]) by mx.groups.io with SMTP id smtpd.web10.25293.1685604661246616412 for ; Thu, 01 Jun 2023 00:31:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=VNgKRsd/; spf=pass (domain: byosoft.com.cn, ip: 121.46.250.151, mailfrom: gaoliming@byosoft.com.cn) Received: from cxsh.intel-email.com (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 8619CDDA7DB for ; Thu, 1 Jun 2023 15:30:58 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1685604658; bh=RgEEw+JoFB+HEq6wRhYCcksU+3FRJyWiwYv3oC65T7Y=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=VNgKRsd/GWfHAvzj3/R7/xyLoXW61Cz6IBnkrF7YmdZA4gVaZZ12N3o7lHt1+aJkF GAY3I7FbRU6MmienyJdclqeMAUJQRW8XrrsXT8mYnfCDsfgN45/Vw5sZoUY4QNKidT 91gnGy6Pc12nJkacYPRNznAqrlRQ9n3yJBJYjiTc= Received: from localhost (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 818F4DDA7D5 for ; Thu, 1 Jun 2023 15:30:58 +0800 (CST) Received: from cxsh.intel-email.com (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 50921DDA78B for ; Thu, 1 Jun 2023 15:30:58 +0800 (CST) Authentication-Results: cxsh.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by cxsh.intel-email.com (Postfix) with SMTP id C9F56DDA7DB for ; Thu, 1 Jun 2023 15:30:55 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 01 Jun 2023 15:30:52 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , "'Michael D Kinney'" Cc: "'Zhiguang Liu'" , "'Pedro Falcato'" , "'Aaron Pop'" References: <20230530185322.70-1-michael.d.kinney@intel.com> <1a9fac1d-6d31-a836-77dd-114ec520321d@linux.microsoft.com> In-Reply-To: <1a9fac1d-6d31-a836-77dd-114ec520321d@linux.microsoft.com> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BhdGNoIHYyIDAvM10gQWRkcmVzcyBDKysga2V5d29yZCBjb2xsaXNpb25z?= Date: Thu, 1 Jun 2023 15:30:53 +0800 Message-ID: <020b01d9945a$ffb5eae0$ff21c0a0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJ+HlE6zZLe7SdhwaBD0UyYqXmeVgHW+Ouxrh3BbJA= Sender: "gaoliming" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn For the patch set, Reviewed-by: Liming Gao > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Oliver > Smith-Denny > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B46=E6=9C=881=E6=97=A5 1= :46 > =E6=94=B6=E4=BB=B6=E4=BA=BA: Michael D Kinney ; > devel@edk2.groups.io > =E6=8A=84=E9=80=81: Liming Gao ; Zhiguang Liu > ; Pedro Falcato ; Aaron > Pop > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [Patch v2 0/3] Address C++ keyword c= ollisions >=20 > For the patchset: >=20 > Reviewed-by: Oliver Smith-Denny >=20 > Thanks! >=20 > On 5/30/2023 11:53 AM, Michael D Kinney wrote: > > New in v2 > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > Changes from 2 patches to 3 patches to support bisect. This > > temporarily uses an anonymous union to allow use of both field > > name styles. It also allows downstream usage of these fields > > to sync with the first 2 patches, update their field names, > > and then sync with last patch. > > > > PR: https://github.com/tianocore/edk2/pull/4436 > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > > Update Tpm12.h and Tpm20.h and not use c++ reserved keywords > > operator and xor in C structures to support use of these > > include files when building with a C++ compiler. > > > > Update SecurityPkg Tpm2CommandLib to use updated field names. > > > > * Change operator -> Operator > > * Change xor -> Xor > > > > NOTE: This is a non-backwards compatible change to Tpm12.h > > and Tmp20.h. And consumers of these include files that access > > the "operator" or "xor" fields must be updated. > > > > Cc: Liming Gao > > Cc: Zhiguang Liu > > Cc: Oliver Smith-Denny > > Cc: Pedro Falcato > > Cc: Aaron Pop > > Signed-off-by: Michael D Kinney > > > > Michael D Kinney (3): > > MdePkg/Include/IndustryStandard: Add Operator and Xor field names > > SecurityPkg/Library/TpmCommandLib: Change xor to Xor > > MdePkg/Include/IndustryStandard: Address C++ keyword collisions > > > > MdePkg/Include/IndustryStandard/Tpm12.h | 4 ++-- > > MdePkg/Include/IndustryStandard/Tpm20.h | 4 ++-- > > SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c | 6 +++--- > > SecurityPkg/Library/Tpm2CommandLib/Tpm2Object.c | 6 +++--- > > SecurityPkg/Library/Tpm2CommandLib/Tpm2Session.c | 2 +- > > 5 files changed, 11 insertions(+), 11 deletions(-) > > >=20 >=20 >=20 >=20