From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Kun Qin'" <kun.q@outlook.com>,
"'Yao, Jiewen'" <jiewen.yao@intel.com>, <devel@edk2.groups.io>
Cc: "'Wang, Jian J'" <jian.j.wang@intel.com>,
"'Lu, XiaoyuX'" <xiaoyux.lu@intel.com>,
"'Jiang, Guomin'" <guomin.jiang@intel.com>
Subject: 回复: [edk2-devel] [PATCH v1 1/1] CryptoPkg: BaseCryptLib: Fix buffer double free in CryptPkcs7VerifyEku
Date: Tue, 24 Nov 2020 09:26:35 +0800 [thread overview]
Message-ID: <022901d6c200$d940f5f0$8bc2e1d0$@byosoft.com.cn> (raw)
In-Reply-To: <DM5PR06MB309836DF712104772BBE2052F3FC0@DM5PR06MB3098.namprd06.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 8316 bytes --]
Kun:
I see the personal PR (https://github.com/tianocore/edk2/pull/1140 ) passed
all checks. So, I think there is no issue for this patch.
Thanks
Liming
发件人: Kun Qin <kun.q@outlook.com>
发送时间: 2020年11月24日 6:49
收件人: Yao, Jiewen <jiewen.yao@intel.com>; gaoliming
<gaoliming@byosoft.com.cn>; devel@edk2.groups.io
抄送: Wang, Jian J <jian.j.wang@intel.com>; Lu, XiaoyuX
<xiaoyux.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>
主题: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg: BaseCryptLib: Fix buffer
double free in CryptPkcs7VerifyEku
Hi Jiewen,
It looks like the v2 patch went through:
https://edk2.groups.io/g/devel/message/67823?p=,,,20,0,0,0::Created,,double+
free,20,2,0,78456278
I also ran the CI build against the branch that has this patch, the PR seems
to be closed after dependency analysis. But edk2 top of master CI build was
failing as is. Please let me know how you would like to proceed.
Thanks,
Kun
From: Yao, Jiewen <mailto:jiewen.yao@intel.com>
Sent: Sunday, November 22, 2020 17:24
To: Kun Qin <mailto:kun.q@outlook.com> ; gaoliming
<mailto:gaoliming@byosoft.com.cn> ; devel@edk2.groups.io <mailto:devel@edk2.
groups.io>
Cc: Wang, Jian J <mailto:jian.j.wang@intel.com> ; Lu, XiaoyuX
<mailto:xiaoyux.lu@intel.com> ; Jiang, Guomin
<mailto:guomin.jiang@intel.com>
Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg: BaseCryptLib: Fix buffer
double free in CryptPkcs7VerifyEku
Sure. It seems Liming already approves it.
I will wait one more day to see if there is any other objection from the
people in different time zone.
At mean time, I need your help to double confirm that, this patch can be
merged without any CI error. So, please try Pull-Request by yourself and
make sure it pass all CI checks.
I have some bad experience that CI error occurs finally, which prevent me
from committing. Then we have to go back ask original submitter to fix and
generate patch again. It may cause delay and miss the timeline.
Thank you
Yao Jiewen
From: Kun Qin <kun.q@outlook.com <mailto:kun.q@outlook.com> >
Sent: Monday, November 23, 2020 9:17 AM
To: Yao, Jiewen <jiewen.yao@intel.com <mailto:jiewen.yao@intel.com> >;
gaoliming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >;
devel@edk2.groups.io <mailto:devel@edk2.groups.io>
Cc: Wang, Jian J <jian.j.wang@intel.com <mailto:jian.j.wang@intel.com> >;
Lu, XiaoyuX <xiaoyux.lu@intel.com <mailto:xiaoyux.lu@intel.com> >; Jiang,
Guomin <guomin.jiang@intel.com <mailto:guomin.jiang@intel.com> >
Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg: BaseCryptLib: Fix buffer
double free in CryptPkcs7VerifyEku
Hi Jiewen,
It will be great if you could help me merging in this fix. Please let me
know if you need anything else from me to have it merged.
Thanks,
Kun
From: Yao, Jiewen <mailto:jiewen.yao@intel.com>
Sent: Sunday, November 22, 2020 04:25
To: Kun Qin <mailto:kun.q@outlook.com> ; gaoliming
<mailto:gaoliming@byosoft.com.cn> ; devel@edk2.groups.io <mailto:devel@edk2.
groups.io>
Cc: Wang, Jian J <mailto:jian.j.wang@intel.com> ; Lu, XiaoyuX
<mailto:xiaoyux.lu@intel.com> ; Jiang, Guomin
<mailto:guomin.jiang@intel.com>
Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg: BaseCryptLib: Fix buffer
double free in CryptPkcs7VerifyEku
I can help to merge if it is approved.
I will add reviewed-by tag when I merge it.
Thank you
Yao Jiewen
From: Kun Qin <kun.q@outlook.com <mailto:kun.q@outlook.com> >
Sent: Sunday, November 22, 2020 3:10 PM
To: gaoliming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >;
devel@edk2.groups.io <mailto:devel@edk2.groups.io> ; Yao, Jiewen
<jiewen.yao@intel.com <mailto:jiewen.yao@intel.com> >
Cc: Wang, Jian J <jian.j.wang@intel.com <mailto:jian.j.wang@intel.com> >;
Lu, XiaoyuX <xiaoyux.lu@intel.com <mailto:xiaoyux.lu@intel.com> >; Jiang,
Guomin <guomin.jiang@intel.com <mailto:guomin.jiang@intel.com> >
Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg: BaseCryptLib: Fix buffer
double free in CryptPkcs7VerifyEku
Hi Liming,
It will be great if we can get this in. But I have been having trouble
sending a v2 patch that incorporates Jiewen’s “Reviewed-by” tag through
git command line for the past week (no other changes). It kept giving me an
error of "No host provider available to service this request". Please let me
know if you have any suggestions.
Thanks,
Kun
From: gaoliming <mailto:gaoliming@byosoft.com.cn>
Sent: Thursday, November 19, 2020 9:39 PM
To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> ;
jiewen.yao@intel.com <mailto:jiewen.yao@intel.com> ; 'Kun Qin'
<mailto:kun.q@outlook.com>
Cc: 'Wang, Jian J' <mailto:jian.j.wang@intel.com> ; 'Lu, XiaoyuX'
<mailto:xiaoyux.lu@intel.com> ; 'Jiang, Guomin'
<mailto:guomin.jiang@intel.com>
Subject: 回复: [edk2-devel] [PATCH v1 1/1] CryptoPkg: BaseCryptLib: Fix
buffer double free in CryptPkcs7VerifyEku
Kun:
This is a bug fix. It passed code review. Do you request to merge it for
this stable tag 202011?
Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+67567+4905953+8761045@groups.io
<mailto:bounce+27952+67567+4905953+8761045@groups.io>
> <bounce+27952+67567+4905953+8761045@groups.io
<mailto:bounce+27952+67567+4905953+8761045@groups.io> > 代表 Yao, Jiewen
> 发送时间: 2020年11月14日 8:32
> 收件人: Kun Qin <kun.q@outlook.com <mailto:kun.q@outlook.com> >;
devel@edk2.groups.io <mailto:devel@edk2.groups.io>
> 抄送: Wang, Jian J <jian.j.wang@intel.com <mailto:jian.j.wang@intel.com>
>; Lu, XiaoyuX
> <xiaoyux.lu@intel.com <mailto:xiaoyux.lu@intel.com> >; Jiang, Guomin
<guomin.jiang@intel.com <mailto:guomin.jiang@intel.com> >; Yao,
> Jiewen <jiewen.yao@intel.com <mailto:jiewen.yao@intel.com> >
> 主题: Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg: BaseCryptLib: Fix buffer
> double free in CryptPkcs7VerifyEku
>
> Sorry, I missed this email.
>
> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com
<mailto:Jiewen.yao@intel.com> >
>
>
> > -----Original Message-----
> > From: Kun Qin <kun.q@outlook.com <mailto:kun.q@outlook.com> >
> > Sent: Wednesday, October 21, 2020 10:32 AM
> > To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>
> > Cc: Wang, Jian J <jian.j.wang@intel.com <mailto:jian.j.wang@intel.com>
>; Lu, XiaoyuX
> > <xiaoyux.lu@intel.com <mailto:xiaoyux.lu@intel.com> >; Yao, Jiewen
<jiewen.yao@intel.com <mailto:jiewen.yao@intel.com> >; Jiang,
> > Guomin <guomin.jiang@intel.com <mailto:guomin.jiang@intel.com> >
> > Subject: [PATCH v1 1/1] CryptoPkg: BaseCryptLib: Fix buffer double free
in
> > CryptPkcs7VerifyEku
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2459
> >
> > SignerCert is part of Pkcs7 instance when both have valid content.
OpenSLL
> > PKCS7_free function will release the memory of SignerCert when
applicable.
> > Freeing SignerCert with X509_free again might cause page fault if use-
> > after-free guard is enabled.
> >
> > Cc: Jian J Wang <jian.j.wang@intel.com <mailto:jian.j.wang@intel.com> >
> > Cc: Xiaoyu Lu <xiaoyux.lu@intel.com <mailto:xiaoyux.lu@intel.com> >
> > Cc: Jiewen Yao <jiewen.yao@intel.com <mailto:jiewen.yao@intel.com> >
> > Cc: Guomin Jiang <guomin.jiang@intel.com <mailto:guomin.jiang@intel.com>
>
> >
> > Signed-off-by: Kun Qin <kun.q@outlook.com <mailto:kun.q@outlook.com> >
> > ---
> > CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyEku.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyEku.c
> > b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyEku.c
> > index c9fdb65b99d1..40cc39afe7dd 100644
> > --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyEku.c
> > +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyEku.c
> > @@ -508,10 +508,6 @@ Exit:
> > free (SignedData);
> >
> > }
> >
> >
> >
> > - if (SignerCert != NULL) {
> >
> > - X509_free (SignerCert);
> >
> > - }
> >
> > -
> >
> > if (Pkcs7 != NULL) {
> >
> > PKCS7_free (Pkcs7);
> >
> > }
> >
> > --
> > 2.28.0.windows.1
>
>
>
>
>
[-- Attachment #2: Type: text/html, Size: 18079 bytes --]
next prev parent reply other threads:[~2020-11-24 1:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201021023228.1884-1-kun.q@outlook.com>
2020-10-21 2:32 ` [PATCH v1 1/1] CryptoPkg: BaseCryptLib: Fix buffer double free in CryptPkcs7VerifyEku Kun Qin
2020-10-21 13:31 ` [edk2-devel] " Laszlo Ersek
2020-11-14 0:31 ` Yao, Jiewen
2020-11-20 5:39 ` 回复: [edk2-devel] " gaoliming
2020-11-22 7:09 ` Kun Qin
2020-11-22 12:25 ` Yao, Jiewen
2020-11-23 0:49 ` 回复: " gaoliming
2020-11-23 1:16 ` Kun Qin
2020-11-23 1:24 ` Yao, Jiewen
2020-11-23 22:49 ` kun.q
2020-11-24 1:26 ` gaoliming [this message]
2020-11-24 1:31 ` Yao, Jiewen
[not found] ` <164A4D9262108CA1.16773@groups.io>
2020-11-26 3:26 ` Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='022901d6c200$d940f5f0$8bc2e1d0$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox