From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id B60CC740047 for ; Mon, 13 May 2024 13:11:45 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=mqg8rYaD5eWJRtLyBky5t6mI9cFJzk33IpHSRSxxing=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20240206; t=1715605904; v=1; b=t7zCCnPTV6q3K6KhwuA44AnXqtFHxRb0Q2cChLvzaNTOcMyu2DmIvlHVgKyt90nHg4k+eGWX Uu0hlxUiPF7uGVcfvhCmAwlGk+rc1jWZFC4fR4TYyYwbiYPm1U87tQ2GTrD44ARouAP6Gsc57fn QD816f663oSIW+vZyzaeqTppbTrB9LUthhdCXCTtVR+XeVMLuBXorpRsvqX3AbrH/9DOPKhq9UB /QjBiRX1mHCsBnit+Ft+ZCo1CRpYJ02yAgpR6UfBxdfFJkRtprU/f/u1VAB6ZZtlJ95OVjH09gx Kaza9YM+5cyRov1FZ9lZNbZVa64mYbsxSn7AVxeSZyHWA== X-Received: by 127.0.0.2 with SMTP id qfrrYY7687511xJPiuveXDb9; Mon, 13 May 2024 06:11:44 -0700 X-Received: from cxsh.intel-email.com (cxsh.intel-email.com [121.46.250.151]) by mx.groups.io with SMTP id smtpd.web11.59887.1715605901956501879 for ; Mon, 13 May 2024 06:11:42 -0700 X-Received: from cxsh.intel-email.com (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 84DBFDDA788 for ; Mon, 13 May 2024 21:11:39 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 7ECE9DDA785 for ; Mon, 13 May 2024 21:11:39 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by cxsh.intel-email.com (Postfix) with SMTP id C88A9DDA789 for ; Mon, 13 May 2024 21:11:24 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([114.92.182.254]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Mon, 13 May 2024 21:11:21 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 114.92.182.254 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: "'Pethaiyan, Madhan'" , "'Kinney, Michael D'" , Cc: "'Liu, Zhiguang'" , "'Li, Yi1'" , "'GuoX Xu'" References: <20240308172556.2473-1-madhan.pethaiyan@intel.com> <062701da80ac$bfad0b10$3f072130$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIFYxXSBNZGVQa2c6IFVwZGF0ZSBHZXRJbWFnZSAsIEdldEltYWdlSW5mbyBkZXNjcmlwdGlvbiBkZXRhaWxz?= Date: Mon, 13 May 2024 21:11:22 +0800 Message-ID: <022b01daa537$0dcd17a0$296746e0$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQK1p6m02awiaSaka2QkRGHZgxw2lwIsPDE9AUBWX0MBaKpc4wKNtexSr6QG+cA= Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 13 May 2024 06:11:43 -0700 Resent-From: gaoliming@byosoft.com.cn Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: u9njqYwd40U8xLKJ6uirS4hJx7686176AA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=t7zCCnPT; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io These PRs are all failure. Please update them.=20 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: Pethaiyan, Madhan > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B45=E6=9C=8813=E6=97=A5 = 20:10 > =E6=94=B6=E4=BB=B6=E4=BA=BA: gaoliming ; Kinney= , Michael D > ; devel@edk2.groups.io > =E6=8A=84=E9=80=81: Liu, Zhiguang ; Li, Yi1 ; 'GuoX > Xu' > =E4=B8=BB=E9=A2=98: RE: [edk2-devel] [PATCH V1] MdePkg: Update GetImage ,= GetImageInfo > description details >=20 > Hi all , >=20 > I had created EDK2 PR, few weeks ago, thought it will be reviewed and app= roved . > Please help to check and approve. >=20 > https://github.com/tianocore/edk2/pull/5584 > https://github.com/tianocore/edk2/pull/5586 > https://github.com/tianocore/edk2/pull/5587 >=20 > Thanks, > P. Madhan >=20 > -----Original Message----- > From: gaoliming > Sent: Thursday, March 28, 2024 6:41 AM > To: Pethaiyan, Madhan ; Kinney, Michael D > ; devel@edk2.groups.io > Cc: Liu, Zhiguang ; Li, Yi1 ; '= GuoX Xu' > > Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH V1] MdePkg: Update GetIm= age , > GetImageInfo description details >=20 > Madhan: > I have no comments for this patch set. Reviewed-by: Liming Gao > >=20 > Have you create Edk2 PR to verify the changes? >=20 > Thanks > Liming > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: Pethaiyan, Madhan > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B43=E6=9C=8814=E6=97= =A5 16:17 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: Kinney, Michael D ; > > devel@edk2.groups.io > > =E6=8A=84=E9=80=81: Liming Gao ; Liu, Zhiguan= g > > ; Li, Yi1 ; GuoX Xu > > > > =E4=B8=BB=E9=A2=98: RE: [edk2-devel] [PATCH V1] MdePkg: Update GetImage= , GetImageInfo > > description details > > > > Hi Mike , > > > > I had raised new code review addressing the coding standard errors and > those > > were not part of my change any way .. > > > > Thanks, > > P. Madhan > > > > -----Original Message----- > > From: Kinney, Michael D > > Sent: Sunday, March 10, 2024 1:47 AM > > To: devel@edk2.groups.io; Pethaiyan, Madhan > > > > Cc: Liming Gao ; Liu, Zhiguang > > ; Li, Yi1 ; GuoX Xu > > ; Kinney, Michael D > > Subject: RE: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , > > GetImageInfo description details > > > > Hi Madhan, > > > > I created a PR with all 3 related patches to run through EDK II CI. > > > > https://github.com/tianocore/edk2/pull/5453 > > > > There are CI failures. Please resolve and send updated patches. > > > > Thanks, > > > > Mike > > > > > -----Original Message----- > > > From: devel@edk2.groups.io On Behalf Of > > > Pethaiyan Madhan > > > Sent: Friday, March 8, 2024 3:17 PM > > > To: devel@edk2.groups.io > > > Cc: Pethaiyan, Madhan ; Kinney, Michael > > > D ; Liming Gao > > > ; Liu, Zhiguang ; > > > Li, Yi1 ; GuoX Xu > > > Subject: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , > > > GetImageInfo description details > > > > > > 1.For EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImage(): > > > Add the following sentence at the end of the Image parameter > > > description. "May be NULL with a zero ImageSize in order to > > > determine the size of the buffer needed". > > > > > > Modify the description of "EFI_INVALID_PARAMETER" return code as > > > "The ImageSize is not too small and Image is NULL." > > > > > > 2.For EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImageInfo(): > > > Add the following sentence at the end of the ImageInfo parameter > > > description."May be NULL with a zero ImageInfoSize in order to > > > determine the size of the buffer needed". > > > > > > Modify the description of "EFI_INVALID_PARAMETER" return code as > > > "The ImageInfoSize is not too small and Image is NULL." and add new > > > descriptions for "EFI_INVALID_PARAMETER" return code. > > > > > > REF: UEFI spec v2.10 23.1.2 > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4660 > > > > > > Cc: Michael D Kinney > > > Cc: Liming Gao > > > Cc: Zhiguang Liu > > > Cc: Yi Li > > > Cc: GuoX Xu > > > Signed-off-by: Pethaiyan Madhan > > > --- > > > MdePkg/Include/Protocol/FirmwareManagement.h | 14 ++++++++++++-- > > > 1 file changed, 12 insertions(+), 2 deletions(-) > > > > > > diff --git a/MdePkg/Include/Protocol/FirmwareManagement.h > > > b/MdePkg/Include/Protocol/FirmwareManagement.h > > > index e535bb697d..90b7d83c8f 100644 > > > --- a/MdePkg/Include/Protocol/FirmwareManagement.h > > > +++ b/MdePkg/Include/Protocol/FirmwareManagement.h > > > @@ -294,6 +294,8 @@ EFI_STATUS > > > to contain the image(s) > > > information if the buffer was too small. > > > @param[in, out] ImageInfo A pointer to the buffer in whic= h > > > firmware places the current image(s) > > > information. The > > information is > > > an array of EFI_FIRMWARE_IMAGE_DESCRIPTORs. > > > + May be NULL with a zero > > > ImageInfoSize in order to determine the size of the > > > + buffer needed. > > > @param[out] DescriptorVersion A pointer to the location in > > > which firmware returns the version number > > > associated with the > > > EFI_FIRMWARE_IMAGE_DESCRIPTOR. > > > @param[out] DescriptorCount A pointer to the location in > > > which firmware returns the number of @@ -314,7 +316,12 @@ EFI_STATUS > > > @retval EFI_SUCCESS The device was successfully > > > updated with the new image. > > > @retval EFI_BUFFER_TOO_SMALL The ImageInfo buffer was > > too > > > small. The current buffer size > > > needed to hold the image(s) > > > information is returned in ImageInfoSize. > > > - @retval EFI_INVALID_PARAMETER ImageInfoSize is NULL. > > > + @retval EFI_INVALID_PARAMETER ImageInfoSize is not too small > > > and ImageInfo is NULL. > > > + @retval EFI_INVALID_PARAMETER ImageInfoSize is non-zero and > > > DescriptorVersion is NULL. > > > + @retval EFI_INVALID_PARAMETER ImageInfoSize is non-zero and > > > DescriptorCount is NULL. > > > + @retval EFI_INVALID_PARAMETER ImageInfoSize is non-zero and > > > DescriptorSize is NULL. > > > + @retval EFI_INVALID_PARAMETER ImageInfoSize is non-zero and > > > PackageVersion is NULL. > > > + @retval EFI_INVALID_PARAMETER ImageInfoSize is non-zero and > > > PackageVersionName is NULL. > > > @retval EFI_DEVICE_ERROR Valid information could not > > be > > > returned. Possible corrupted image. > > > > > > **/ > > > @@ -341,6 +348,9 @@ EFI_STATUS > > > @param[in] ImageIndex A unique number identifying the > > > firmware image(s) within the device. > > > The number is between 1 and > > > DescriptorCount. > > > @param[out] Image Points to the buffer where the > > > current image is copied to. > > > + May be NULL with a zero > > ImageSize in > > > order to determine the size of the > > > + buffer needed. > > > + > > > @param[in, out] ImageSize On entry, points to the size of the > > > buffer pointed to by Image, in bytes. > > > On return, points to the length of > > > the image, in bytes. > > > > > > @@ -348,7 +358,7 @@ EFI_STATUS > > > @retval EFI_BUFFER_TOO_SMALL The buffer specified by ImageSize > > is > > > too small to hold the > > > image. The current buffer size > > > needed to hold the image is returned > > > in ImageSize. > > > - @retval EFI_INVALID_PARAMETER The Image was NULL. > > > + @retval EFI_INVALID_PARAMETER The ImageSize is not too small and > > > Image is NULL. > > > @retval EFI_NOT_FOUND The current image is not copied > > to > > > the buffer. > > > @retval EFI_UNSUPPORTED The operation is not supported. > > > @retval EFI_SECURITY_VIOLATION The operation could not be > > performed > > > due to an authentication failure. > > > -- > > > 2.38.1.windows.1 > > > > > > > > > > > >=20 > > > >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118863): https://edk2.groups.io/g/devel/message/118863 Mute This Topic: https://groups.io/mt/105189505/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-