From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Stewart, Chris \(SW Architect\)'" <chris.stewart@hp.com>,
<devel@edk2.groups.io>
Cc: <jiewen.yao@intel.com>, <jian.j.wang@intel.com>,
<xiaoyux.lu@intel.com>, <guomin.jiang@intel.com>,
"'Leif Lindholm'" <leif@nuviainc.com>,
"'Andrew Fish'" <afish@apple.com>,
"'Kinney, Michael D'" <michael.d.kinney@intel.com>
Subject: 回复: [edk2-stable202108] Package: CryptoPkg/BaseCryptLib: fix incorrect param order
Date: Wed, 18 Aug 2021 09:18:17 +0800 [thread overview]
Message-ID: <022f01d793ce$ece73380$c6b59a80$@byosoft.com.cn> (raw)
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
This is a clear bug fix. I suggest to merge it for this stable tag 202108.
Thanks
Liming
> -----邮件原件-----
> 发件人: Stewart, Chris (SW Architect) <chris.stewart@hp.com>
> 发送时间: 2021年8月17日 20:48
> 收件人: devel@edk2.groups.io
> 抄送: jiewen.yao@intel.com; jian.j.wang@intel.com; xiaoyux.lu@intel.com;
> guomin.jiang@intel.com; gaoliming@byosoft.com.cn; Stewart, Chris (SW
> Architect) <chris.stewart@hp.com>
> 主题: [PATCH] Package: CryptoPkg/BaseCryptLib: fix incorrect param order
>
> [PATCH] Package: CryptoPkg/BaseCryptLib: fix incorrect param order
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3550
>
> Function ConvertAsn1TimeToEfiTime initializes timestamp to zeroes with
> SetMem, but the actual parameters are out of order.
> The result is the SetMem operation has no effect. The fix is to put the
actual
> parameters in the correct order.
>
> Signed-off-by: Chris Stewart <chris.stewart@hp.com>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> CC: Jiewen Yao <jiewen.yao@intel.com>
> CC: Jian J Wang <jian.j.wang@intel.com>
> CC: Xiaoyu Lu <xiaoyux.lu@intel.com>
> CC: Guomin Jiang <guomin.jiang@intel.com>
> ---
> CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
> b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
> index ff7f6488f2..970e9b94a0 100644
> --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
> +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
> @@ -155,7 +155,7 @@ ConvertAsn1TimeToEfiTime (
> }
>
> Str = (CONST CHAR8*)Asn1Time->data;
> - SetMem (EfiTime, 0, sizeof (EFI_TIME));
> + SetMem (EfiTime, sizeof (EFI_TIME), 0);
>
> Index = 0;
> if (Asn1Time->type == V_ASN1_UTCTIME) { /* two digit
> year */
> --
> 2.19.2.windows.1
next reply other threads:[~2021-08-18 1:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 1:18 gaoliming [this message]
2021-08-18 1:20 ` [edk2-devel] 回复: [edk2-stable202108] Package: CryptoPkg/BaseCryptLib: fix incorrect param order Yao, Jiewen
2021-08-19 2:49 ` 回复: " gaoliming
[not found] ` <169C955ADD5C610A.22901@groups.io>
2021-08-23 2:20 ` gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='022f01d793ce$ece73380$c6b59a80$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox