From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242])
 by mx.groups.io with SMTP id smtpd.web10.48439.1629249505297478691
 for <devel@edk2.groups.io>;
 Tue, 17 Aug 2021 18:18:26 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn)
Received: from DESKTOPS6D0PVI ([58.246.60.130])
	(envelope-sender <gaoliming@byosoft.com.cn>)
	by 192.168.6.13 with ESMTP
	for <afish@apple.com>; Wed, 18 Aug 2021 09:18:15 +0800
X-WM-Sender: gaoliming@byosoft.com.cn
X-Originating-IP: 58.246.60.130
X-WM-AuthFlag: YES
X-WM-AuthUser: gaoliming@byosoft.com.cn
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Stewart, Chris \(SW Architect\)'" <chris.stewart@hp.com>,
	<devel@edk2.groups.io>
Cc: <jiewen.yao@intel.com>,
	<jian.j.wang@intel.com>,
	<xiaoyux.lu@intel.com>,
	<guomin.jiang@intel.com>,
	"'Leif Lindholm'" <leif@nuviainc.com>,
	"'Andrew Fish'" <afish@apple.com>,
	"'Kinney, Michael D'" <michael.d.kinney@intel.com>
Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1zdGFibGUyMDIxMDhdIFBhY2thZ2U6IENyeXB0b1BrZy9CYXNlQ3J5cHRMaWI6IGZpeCBpbmNvcnJlY3QgcGFyYW0gb3JkZXI=?=
Date: Wed, 18 Aug 2021 09:18:17 +0800
Message-ID: <022f01d793ce$ece73380$c6b59a80$@byosoft.com.cn>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AdeTzuW46zQXRoEgQGu2Bo4RAhnwig==
Content-Type: text/plain;
	charset="gb2312"
Content-Transfer-Encoding: quoted-printable
Content-Language: zh-cn

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

This is a clear bug fix. I suggest to merge it for this stable tag =
202108.=20

Thanks
Liming
> -----=D3=CA=BC=FE=D4=AD=BC=FE-----
> =B7=A2=BC=FE=C8=CB: Stewart, Chris (SW Architect) =
<chris.stewart@hp.com>
> =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA8=D4=C217=C8=D5 20:48
> =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io
> =B3=AD=CB=CD: jiewen.yao@intel.com; jian.j.wang@intel.com; =
xiaoyux.lu@intel.com;
> guomin.jiang@intel.com; gaoliming@byosoft.com.cn; Stewart, Chris (SW
> Architect) <chris.stewart@hp.com>
> =D6=F7=CC=E2: [PATCH] Package: CryptoPkg/BaseCryptLib: fix incorrect =
param order
>=20
> [PATCH] Package: CryptoPkg/BaseCryptLib: fix incorrect param order
>=20
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3550
>=20
> Function ConvertAsn1TimeToEfiTime initializes timestamp to zeroes with
> SetMem, but the actual parameters are out of order.
> The result is the SetMem operation has no effect. The fix is to put =
the
actual
> parameters in the correct order.
>=20
> Signed-off-by: Chris Stewart <chris.stewart@hp.com>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> CC: Jiewen Yao <jiewen.yao@intel.com>
> CC: Jian J Wang <jian.j.wang@intel.com>
> CC: Xiaoyu Lu <xiaoyux.lu@intel.com>
> CC: Guomin Jiang <guomin.jiang@intel.com>
> ---
>  CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
> b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
> index ff7f6488f2..970e9b94a0 100644
> --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
> +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
> @@ -155,7 +155,7 @@ ConvertAsn1TimeToEfiTime (
>    }
>=20
>    Str =3D (CONST CHAR8*)Asn1Time->data;
> -  SetMem (EfiTime, 0, sizeof (EFI_TIME));
> +  SetMem (EfiTime, sizeof (EFI_TIME), 0);
>=20
>    Index =3D 0;
>    if (Asn1Time->type =3D=3D V_ASN1_UTCTIME) {               /* two =
digit
> year */
> --
> 2.19.2.windows.1