From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242])
 by mx.groups.io with SMTP id smtpd.web09.48862.1629253391863485877
 for <devel@edk2.groups.io>;
 Tue, 17 Aug 2021 19:23:13 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn)
Received: from DESKTOPS6D0PVI ([58.246.60.130])
	(envelope-sender <gaoliming@byosoft.com.cn>)
	by 192.168.6.13 with ESMTP
	for <afish@apple.com>; Wed, 18 Aug 2021 10:23:04 +0800
X-WM-Sender: gaoliming@byosoft.com.cn
X-Originating-IP: 58.246.60.130
X-WM-AuthFlag: YES
X-WM-AuthUser: gaoliming@byosoft.com.cn
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>,
	<yuwei.chen@intel.com>
Cc: "'Bob Feng'" <bob.c.feng@intel.com>,
	"'Andrew Fish'" <afish@apple.com>,
	"'Leif Lindholm'" <leif@nuviainc.com>,
	"'Michael D Kinney'" <michael.d.kinney@intel.com>
References: <20210817062041.755-1-yuwei.chen@intel.com>
In-Reply-To: <20210817062041.755-1-yuwei.chen@intel.com>
Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIDEvMV0gQmFzZVRvb2xzL0dlbkZkczogQ2hhbmdlIEZWIEhlYWRlciB0byBGaWxlU3lzdGVtR3VpZDMsIGVkazItc3RhYmxlMjAyMTA4?=
Date: Wed, 18 Aug 2021 10:23:06 +0800
Message-ID: <023001d793d7$fab58210$f0208630$@byosoft.com.cn>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQGsZi2loRMHtQcxJMO3d5IrCKf9uqvO0u2Q
Content-Type: text/plain;
	charset="gb2312"
Content-Transfer-Encoding: quoted-printable
Content-Language: zh-cn

Yuwei:
  This change may impact the third part tool. Customer may have their tool
to parse BIOS image. They may not support FileSystemGuid3.=20

  So, I suggest to defer this patch to next stable tag so that there are
enough time to collect the feedback.=20

  For this patch, I add my comments below.=20

Thanks
Liming
> -----=D3=CA=BC=FE=D4=AD=BC=FE-----
> =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io <devel@edk2.groups.io> =B4=FA=B1=
=ED Yuwei Chen
> =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA8=D4=C217=C8=D5 14:21
> =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io
> =B3=AD=CB=CD: Bob Feng <bob.c.feng@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Andrew Fish <afish@apple.com>; Leif
> Lindholm <leif@nuviainc.com>; Michael D Kinney
> <michael.d.kinney@intel.com>
> =D6=F7=CC=E2: [edk2-devel] [PATCH 1/1] BaseTools/GenFds: Change FV Header=
 to
> FileSystemGuid3, edk2-stable202108
>=20
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3566
>=20
> Following PI spec: when there has Ffs with EFI_FFS_FILE_HEADER2,
> the Parent Fv of the Ffs need set to FileSystemGuid3; when all
> the Ffs with EFI_FFS_FILE_HEADER, the Parent Fv of the Ffs need
> set to FileSystemGuid2.
> Currently, when changing the Ffs in Fv from EFI_FFS_FILE_HEADER
> to EFI_FFS_FILE_HEADER2, the Fv FileSystemGuid does not changed
> consistent with Ffs type.That caused build issue.
>=20
> This patch fixes this issue.
> As FileSystemGuid3 is compatible with FileSystemGuid2, change all
> the Fv header to FileSystemGuid3.
>=20
> Signed-off-by: Yuwei Chen <yuwei.chen@intel.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  BaseTools/Source/C/GenFv/GenFv.c                       | 2 +-
>  BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/BaseTools/Source/C/GenFv/GenFv.c
> b/BaseTools/Source/C/GenFv/GenFv.c
> index 43cc5cd3fe82..af0c21db062a 100644
> --- a/BaseTools/Source/C/GenFv/GenFv.c
> +++ b/BaseTools/Source/C/GenFv/GenFv.c
> @@ -225,7 +225,7 @@ Routine Description:
>    //
>    // Set the default FvGuid
>    //
> -  memcpy (&mFvDataInfo.FvFileSystemGuid,
> &mEfiFirmwareFileSystem2Guid, sizeof (EFI_GUID));
> +  memcpy (&mFvDataInfo.FvFileSystemGuid,
> &mEfiFirmwareFileSystem3Guid, sizeof (EFI_GUID));
>    mFvDataInfo.ForceRebase =3D -1;
>=20
>    //
> diff --git a/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py
> b/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py
> index 25f9d54874d3..fa559793824d 100644
> --- a/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py
> +++ b/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py
> @@ -599,6 +599,8 @@ class GenFdsGlobalVariable:
>          if MapFile:
>              Cmd +=3D ("-m", MapFile)
>          if FileSystemGuid:
> +            if FileSystemGuid =3D=3D EFI_FIRMWARE_FILE_SYSTEM2_GUID:
> +                FileSystemGuid =3D EFI_FIRMWARE_FILE_SYSTEM3_GUID
[Liming] I don=A1=AFt find EFI_FIRMWARE_FILE_SYSTEM2_GUID definition. Do yo=
u
verify this logic?
And, does =3D=3D support the case insensitive string comparison? =20

Liming
Thanks
>              Cmd +=3D ("-g", FileSystemGuid)
>          Cmd +=3D ("-o", Output)
>          for I in Input:
> --
> 2.26.1.windows.1
>=20
>=20
>=20
>=20
>=20