From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web11.18577.1629685258052416959 for ; Sun, 22 Aug 2021 19:20:59 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Mon, 23 Aug 2021 10:20:50 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , , "'Stewart, Chris \(SW Architect\)'" Cc: "'Wang, Jian J'" , "'Lu, XiaoyuX'" , "'Jiang, Guomin'" , "'Leif Lindholm'" , "'Andrew Fish'" , "'Kinney, Michael D'" References: <022f01d793ce$ece73380$c6b59a80$@byosoft.com.cn> <169C955ADD5C610A.22901@groups.io> In-Reply-To: <169C955ADD5C610A.22901@groups.io> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0g5Zue5aSNOiBbZWRrMi1zdGFibGUyMDIxMDhdIFBhY2thZ2U6IENyeXB0b1BrZy9CYXNlQ3J5cHRMaWI6IGZpeCBpbmNvcnJlY3QgcGFyYW0gb3JkZXI=?= Date: Mon, 23 Aug 2021 10:20:51 +0800 Message-ID: <023801d797c5$7e8bed90$7ba3c8b0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQKC90wVx8tHc433LIhfm5L2TNsQmAJ/6zLhAjkDxduqA9TdoA== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Create PR https://github.com/tianocore/edk2/pull/1908 for this fix.=20 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 gaoliming > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B48=E6=9C=8819=E6=97=A5 = 10:49 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; jiewen.yao@intel.com; = 'Stewart, Chris (SW > Architect)' > =E6=8A=84=E9=80=81: 'Wang, Jian J' ; 'Lu, XiaoyuX' > ; 'Jiang, Guomin' ; 'Leif > Lindholm' ; 'Andrew Fish' ; 'Kinney, > Michael D' > =E4=B8=BB=E9=A2=98: =E5=9B=9E=E5=A4=8D: [edk2-devel] =E5=9B=9E=E5=A4=8D: = [edk2-stable202108] Package: > CryptoPkg/BaseCryptLib: fix incorrect param order >=20 > Sure. I will merge this patch. >=20 > Thanks > Liming >=20 > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =E4=BB=A3=E8=A1=A8 Yao, > Jiewen > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B48=E6=9C=8818=E6=97= =A5 9:20 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; gaoliming@byosoft.co= m.cn; 'Stewart, Chris > > (SW Architect)' > > =E6=8A=84=E9=80=81: Wang, Jian J ; Lu, XiaoyuX > > ; Jiang, Guomin ; 'Leif > > Lindholm' ; 'Andrew Fish' ; Kinney, > > Michael D ; Yao, Jiewen > > > > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] =E5=9B=9E=E5=A4=8D: [edk2-stable20= 2108] Package: > > CryptoPkg/BaseCryptLib: fix incorrect param order > > > > Reviewed-by: Jiewen Yao > > > > Thanks Liming. Yes. I agree to merge it for stable tag. > > Will you help to do that? > > > > > -----Original Message----- > > > From: devel@edk2.groups.io On Behalf Of > > gaoliming > > > Sent: Wednesday, August 18, 2021 9:18 AM > > > To: 'Stewart, Chris (SW Architect)' ; > > > devel@edk2.groups.io > > > Cc: Yao, Jiewen ; Wang, Jian J > > ; > > > Lu, XiaoyuX ; Jiang, Guomin > > ; > > > 'Leif Lindholm' ; 'Andrew Fish' ; > > Kinney, > > > Michael D > > > Subject: [edk2-devel] =E5=9B=9E=E5=A4=8D: [edk2-stable202108] Package= : > > > CryptoPkg/BaseCryptLib: fix incorrect param order > > > > > > Reviewed-by: Liming Gao > > > > > > This is a clear bug fix. I suggest to merge it for this stable tag 20= 2108. > > > > > > Thanks > > > Liming > > > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > > > =E5=8F=91=E4=BB=B6=E4=BA=BA: Stewart, Chris (SW Architect) > > > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B48=E6=9C=8817=E6= =97=A5 20:48 > > > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > > > > =E6=8A=84=E9=80=81: jiewen.yao@intel.com; jian.j.wang@intel.com; > > xiaoyux.lu@intel.com; > > > > guomin.jiang@intel.com; gaoliming@byosoft.com.cn; Stewart, Chris (S= W > > > > Architect) > > > > =E4=B8=BB=E9=A2=98: [PATCH] Package: CryptoPkg/BaseCryptLib: fix in= correct param > > order > > > > > > > > [PATCH] Package: CryptoPkg/BaseCryptLib: fix incorrect param order > > > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3550 > > > > > > > > Function ConvertAsn1TimeToEfiTime initializes timestamp to zeroes w= ith > > > > SetMem, but the actual parameters are out of order. > > > > The result is the SetMem operation has no effect. The fix is to put= the > > > actual > > > > parameters in the correct order. > > > > > > > > Signed-off-by: Chris Stewart > > > > Reviewed-by: Liming Gao > > > > CC: Jiewen Yao > > > > CC: Jian J Wang > > > > CC: Xiaoyu Lu > > > > CC: Guomin Jiang > > > > --- > > > > CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c > > > > b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c > > > > index ff7f6488f2..970e9b94a0 100644 > > > > --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c > > > > +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c > > > > @@ -155,7 +155,7 @@ ConvertAsn1TimeToEfiTime ( > > > > } > > > > > > > > Str =3D (CONST CHAR8*)Asn1Time->data; > > > > - SetMem (EfiTime, 0, sizeof (EFI_TIME)); > > > > + SetMem (EfiTime, sizeof (EFI_TIME), 0); > > > > > > > > Index =3D 0; > > > > if (Asn1Time->type =3D=3D V_ASN1_UTCTIME) { /* > two > > digit > > > > year */ > > > > -- > > > > 2.19.2.windows.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >=20 >=20 >=20 >=20 >=20 >=20 >=20