回复: [edk2-stable202108] Package: CryptoPkg/BaseCryptLib: fix incorrect param order

回复: [edk2-stable202108] Package: CryptoPkg/BaseCryptLib: fix incorrect param order

[gaoliming]

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

This is a clear bug fix. I suggest to merge it for this stable tag 202108. 

Thanks
Liming
> -----邮件原件-----
> 发件人: Stewart, Chris (SW Architect) <chris.stewart@hp.com>
> 发送时间: 2021年8月17日 20:48
> 收件人: devel@edk2.groups.io
> 抄送: jiewen.yao@intel.com; jian.j.wang@intel.com; xiaoyux.lu@intel.com;
> guomin.jiang@intel.com; gaoliming@byosoft.com.cn; Stewart, Chris (SW
> Architect) <chris.stewart@hp.com>
> 主题: [PATCH] Package: CryptoPkg/BaseCryptLib: fix incorrect param order
> 
> [PATCH] Package: CryptoPkg/BaseCryptLib: fix incorrect param order
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3550
> 
> Function ConvertAsn1TimeToEfiTime initializes timestamp to zeroes with
> SetMem, but the actual parameters are out of order.
> The result is the SetMem operation has no effect. The fix is to put the
actual
> parameters in the correct order.
> 
> Signed-off-by: Chris Stewart <chris.stewart@hp.com>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> CC: Jiewen Yao <jiewen.yao@intel.com>
> CC: Jian J Wang <jian.j.wang@intel.com>
> CC: Xiaoyu Lu <xiaoyux.lu@intel.com>
> CC: Guomin Jiang <guomin.jiang@intel.com>
> ---
>  CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
> b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
> index ff7f6488f2..970e9b94a0 100644
> --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
> +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
> @@ -155,7 +155,7 @@ ConvertAsn1TimeToEfiTime (
>    }
> 
>    Str = (CONST CHAR8*)Asn1Time->data;
> -  SetMem (EfiTime, 0, sizeof (EFI_TIME));
> +  SetMem (EfiTime, sizeof (EFI_TIME), 0);
> 
>    Index = 0;
>    if (Asn1Time->type == V_ASN1_UTCTIME) {               /* two digit
> year */
> --
> 2.19.2.windows.1

Re: [edk2-devel] 回复: [edk2-stable202108] Package: CryptoPkg/BaseCryptLib: fix incorrect param order

[Yao, Jiewen]

Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

Thanks Liming. Yes. I agree to merge it for stable tag.
Will you help to do that?

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming
> Sent: Wednesday, August 18, 2021 9:18 AM
> To: 'Stewart, Chris (SW Architect)' <chris.stewart@hp.com>;
> devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>;
> Lu, XiaoyuX <xiaoyux.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>;
> 'Leif Lindholm' <leif@nuviainc.com>; 'Andrew Fish' <afish@apple.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>
> Subject: [edk2-devel] 回复: [edk2-stable202108] Package:
> CryptoPkg/BaseCryptLib: fix incorrect param order
> 
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> 
> This is a clear bug fix. I suggest to merge it for this stable tag 202108.
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Stewart, Chris (SW Architect) <chris.stewart@hp.com>
> > 发送时间: 2021年8月17日 20:48
> > 收件人: devel@edk2.groups.io
> > 抄送: jiewen.yao@intel.com; jian.j.wang@intel.com; xiaoyux.lu@intel.com;
> > guomin.jiang@intel.com; gaoliming@byosoft.com.cn; Stewart, Chris (SW
> > Architect) <chris.stewart@hp.com>
> > 主题: [PATCH] Package: CryptoPkg/BaseCryptLib: fix incorrect param order
> >
> > [PATCH] Package: CryptoPkg/BaseCryptLib: fix incorrect param order
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3550
> >
> > Function ConvertAsn1TimeToEfiTime initializes timestamp to zeroes with
> > SetMem, but the actual parameters are out of order.
> > The result is the SetMem operation has no effect. The fix is to put the
> actual
> > parameters in the correct order.
> >
> > Signed-off-by: Chris Stewart <chris.stewart@hp.com>
> > Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> > CC: Jiewen Yao <jiewen.yao@intel.com>
> > CC: Jian J Wang <jian.j.wang@intel.com>
> > CC: Xiaoyu Lu <xiaoyux.lu@intel.com>
> > CC: Guomin Jiang <guomin.jiang@intel.com>
> > ---
> >  CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
> > b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
> > index ff7f6488f2..970e9b94a0 100644
> > --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
> > +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
> > @@ -155,7 +155,7 @@ ConvertAsn1TimeToEfiTime (
> >    }
> >
> >    Str = (CONST CHAR8*)Asn1Time->data;
> > -  SetMem (EfiTime, 0, sizeof (EFI_TIME));
> > +  SetMem (EfiTime, sizeof (EFI_TIME), 0);
> >
> >    Index = 0;
> >    if (Asn1Time->type == V_ASN1_UTCTIME) {               /* two digit
> > year */
> > --
> > 2.19.2.windows.1
> 
> 
> 
> 
> 
> 
> 

回复: [edk2-devel] 回复: [edk2-stable202108] Package: CryptoPkg/BaseCryptLib: fix incorrect param order

[gaoliming]

Sure. I will merge this patch. 

Thanks
Liming

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Yao, Jiewen
> 发送时间: 2021年8月18日 9:20
> 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn; 'Stewart, Chris
> (SW Architect)' <chris.stewart@hp.com>
> 抄送: Wang, Jian J <jian.j.wang@intel.com>; Lu, XiaoyuX
> <xiaoyux.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>; 'Leif
> Lindholm' <leif@nuviainc.com>; 'Andrew Fish' <afish@apple.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>
> 主题: Re: [edk2-devel] 回复: [edk2-stable202108] Package:
> CryptoPkg/BaseCryptLib: fix incorrect param order
> 
> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> 
> Thanks Liming. Yes. I agree to merge it for stable tag.
> Will you help to do that?
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> gaoliming
> > Sent: Wednesday, August 18, 2021 9:18 AM
> > To: 'Stewart, Chris (SW Architect)' <chris.stewart@hp.com>;
> > devel@edk2.groups.io
> > Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>;
> > Lu, XiaoyuX <xiaoyux.lu@intel.com>; Jiang, Guomin
> <guomin.jiang@intel.com>;
> > 'Leif Lindholm' <leif@nuviainc.com>; 'Andrew Fish' <afish@apple.com>;
> Kinney,
> > Michael D <michael.d.kinney@intel.com>
> > Subject: [edk2-devel] 回复: [edk2-stable202108] Package:
> > CryptoPkg/BaseCryptLib: fix incorrect param order
> >
> > Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> >
> > This is a clear bug fix. I suggest to merge it for this stable tag 202108.
> >
> > Thanks
> > Liming
> > > -----邮件原件-----
> > > 发件人: Stewart, Chris (SW Architect) <chris.stewart@hp.com>
> > > 发送时间: 2021年8月17日 20:48
> > > 收件人: devel@edk2.groups.io
> > > 抄送: jiewen.yao@intel.com; jian.j.wang@intel.com;
> xiaoyux.lu@intel.com;
> > > guomin.jiang@intel.com; gaoliming@byosoft.com.cn; Stewart, Chris (SW
> > > Architect) <chris.stewart@hp.com>
> > > 主题: [PATCH] Package: CryptoPkg/BaseCryptLib: fix incorrect param
> order
> > >
> > > [PATCH] Package: CryptoPkg/BaseCryptLib: fix incorrect param order
> > >
> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3550
> > >
> > > Function ConvertAsn1TimeToEfiTime initializes timestamp to zeroes with
> > > SetMem, but the actual parameters are out of order.
> > > The result is the SetMem operation has no effect. The fix is to put the
> > actual
> > > parameters in the correct order.
> > >
> > > Signed-off-by: Chris Stewart <chris.stewart@hp.com>
> > > Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> > > CC: Jiewen Yao <jiewen.yao@intel.com>
> > > CC: Jian J Wang <jian.j.wang@intel.com>
> > > CC: Xiaoyu Lu <xiaoyux.lu@intel.com>
> > > CC: Guomin Jiang <guomin.jiang@intel.com>
> > > ---
> > >  CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
> > > b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
> > > index ff7f6488f2..970e9b94a0 100644
> > > --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
> > > +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
> > > @@ -155,7 +155,7 @@ ConvertAsn1TimeToEfiTime (
> > >    }
> > >
> > >    Str = (CONST CHAR8*)Asn1Time->data;
> > > -  SetMem (EfiTime, 0, sizeof (EFI_TIME));
> > > +  SetMem (EfiTime, sizeof (EFI_TIME), 0);
> > >
> > >    Index = 0;
> > >    if (Asn1Time->type == V_ASN1_UTCTIME) {               /* two
> digit
> > > year */
> > > --
> > > 2.19.2.windows.1
> >
> >
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 

回复: [edk2-devel] 回复: [edk2-stable202108] Package: CryptoPkg/BaseCryptLib: fix incorrect param order

[gaoliming]

Create PR https://github.com/tianocore/edk2/pull/1908 for this fix. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 gaoliming
> 发送时间: 2021年8月19日 10:49
> 收件人: devel@edk2.groups.io; jiewen.yao@intel.com; 'Stewart, Chris (SW
> Architect)' <chris.stewart@hp.com>
> 抄送: 'Wang, Jian J' <jian.j.wang@intel.com>; 'Lu, XiaoyuX'
> <xiaoyux.lu@intel.com>; 'Jiang, Guomin' <guomin.jiang@intel.com>; 'Leif
> Lindholm' <leif@nuviainc.com>; 'Andrew Fish' <afish@apple.com>; 'Kinney,
> Michael D' <michael.d.kinney@intel.com>
> 主题: 回复: [edk2-devel] 回复: [edk2-stable202108] Package:
> CryptoPkg/BaseCryptLib: fix incorrect param order
> 
> Sure. I will merge this patch.
> 
> Thanks
> Liming
> 
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Yao,
> Jiewen
> > 发送时间: 2021年8月18日 9:20
> > 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn; 'Stewart, Chris
> > (SW Architect)' <chris.stewart@hp.com>
> > 抄送: Wang, Jian J <jian.j.wang@intel.com>; Lu, XiaoyuX
> > <xiaoyux.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>; 'Leif
> > Lindholm' <leif@nuviainc.com>; 'Andrew Fish' <afish@apple.com>; Kinney,
> > Michael D <michael.d.kinney@intel.com>; Yao, Jiewen
> > <jiewen.yao@intel.com>
> > 主题: Re: [edk2-devel] 回复: [edk2-stable202108] Package:
> > CryptoPkg/BaseCryptLib: fix incorrect param order
> >
> > Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> >
> > Thanks Liming. Yes. I agree to merge it for stable tag.
> > Will you help to do that?
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > gaoliming
> > > Sent: Wednesday, August 18, 2021 9:18 AM
> > > To: 'Stewart, Chris (SW Architect)' <chris.stewart@hp.com>;
> > > devel@edk2.groups.io
> > > Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J
> > <jian.j.wang@intel.com>;
> > > Lu, XiaoyuX <xiaoyux.lu@intel.com>; Jiang, Guomin
> > <guomin.jiang@intel.com>;
> > > 'Leif Lindholm' <leif@nuviainc.com>; 'Andrew Fish' <afish@apple.com>;
> > Kinney,
> > > Michael D <michael.d.kinney@intel.com>
> > > Subject: [edk2-devel] 回复: [edk2-stable202108] Package:
> > > CryptoPkg/BaseCryptLib: fix incorrect param order
> > >
> > > Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> > >
> > > This is a clear bug fix. I suggest to merge it for this stable tag 202108.
> > >
> > > Thanks
> > > Liming
> > > > -----邮件原件-----
> > > > 发件人: Stewart, Chris (SW Architect) <chris.stewart@hp.com>
> > > > 发送时间: 2021年8月17日 20:48
> > > > 收件人: devel@edk2.groups.io
> > > > 抄送: jiewen.yao@intel.com; jian.j.wang@intel.com;
> > xiaoyux.lu@intel.com;
> > > > guomin.jiang@intel.com; gaoliming@byosoft.com.cn; Stewart, Chris (SW
> > > > Architect) <chris.stewart@hp.com>
> > > > 主题: [PATCH] Package: CryptoPkg/BaseCryptLib: fix incorrect param
> > order
> > > >
> > > > [PATCH] Package: CryptoPkg/BaseCryptLib: fix incorrect param order
> > > >
> > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3550
> > > >
> > > > Function ConvertAsn1TimeToEfiTime initializes timestamp to zeroes with
> > > > SetMem, but the actual parameters are out of order.
> > > > The result is the SetMem operation has no effect. The fix is to put the
> > > actual
> > > > parameters in the correct order.
> > > >
> > > > Signed-off-by: Chris Stewart <chris.stewart@hp.com>
> > > > Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> > > > CC: Jiewen Yao <jiewen.yao@intel.com>
> > > > CC: Jian J Wang <jian.j.wang@intel.com>
> > > > CC: Xiaoyu Lu <xiaoyux.lu@intel.com>
> > > > CC: Guomin Jiang <guomin.jiang@intel.com>
> > > > ---
> > > >  CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
> > > > b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
> > > > index ff7f6488f2..970e9b94a0 100644
> > > > --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
> > > > +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
> > > > @@ -155,7 +155,7 @@ ConvertAsn1TimeToEfiTime (
> > > >    }
> > > >
> > > >    Str = (CONST CHAR8*)Asn1Time->data;
> > > > -  SetMem (EfiTime, 0, sizeof (EFI_TIME));
> > > > +  SetMem (EfiTime, sizeof (EFI_TIME), 0);
> > > >
> > > >    Index = 0;
> > > >    if (Asn1Time->type == V_ASN1_UTCTIME) {               /*
> two
> > digit
> > > > year */
> > > > --
> > > > 2.19.2.windows.1
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 
> 
>