[PATCH 1/1] OvmfPkg/AmdSev: reserve snp pages

[PATCH 1/1] OvmfPkg/AmdSev: reserve snp pages

[Gerd Hoffmann]

The SNP patch series updated the OvmfPkgX64 build but forgot the AmdSev
variant, resulting in a broken OvmfSevMetadata table.

Fixes: cca9cd3dd6bf ("OvmfPkg: reserve CPUID page")
Fixes: 707c71a01b9d ("OvmfPkg: reserve SNP secrets page")
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 OvmfPkg/AmdSev/AmdSevX64.fdf | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/OvmfPkg/AmdSev/AmdSevX64.fdf b/OvmfPkg/AmdSev/AmdSevX64.fdf
index 14b5b5593f97..31f2be66361f 100644
--- a/OvmfPkg/AmdSev/AmdSevX64.fdf
+++ b/OvmfPkg/AmdSev/AmdSevX64.fdf
@@ -68,6 +68,12 @@ [FD.MEMFD]
 0x00D000|0x001000
 gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecGhcbBackupBase|gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecGhcbBackupSize
 
+0x00E000|0x001000
+gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSnpSecretsBase|gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSnpSecretsSize
+
+0x00F000|0x001000
+gUefiOvmfPkgTokenSpaceGuid.PcdOvmfCpuidBase|gUefiOvmfPkgTokenSpaceGuid.PcdOvmfCpuidSize
+
 0x010000|0x010000
 gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecPeiTempRamBase|gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecPeiTempRamSize
 
-- 
2.35.1

Re: [PATCH 1/1] OvmfPkg/AmdSev: reserve snp pages

[Brijesh Singh]

On 2/16/22 01:00, Gerd Hoffmann wrote:
> The SNP patch series updated the OvmfPkgX64 build but forgot the AmdSev
> variant, resulting in a broken OvmfSevMetadata table.
> 
> Fixes: cca9cd3dd6bf ("OvmfPkg: reserve CPUID page")
> Fixes: 707c71a01b9d ("OvmfPkg: reserve SNP secrets page")
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Thanks Gerd

Reviewed-by: Brijesh Singh <brijesh.singh@amd.com>

回复: [edk2-devel] [PATCH 1/1] OvmfPkg/AmdSev: reserve snp pages

[gaoliming]

Gerd and Brijesh:
 I see six FDF files include AmdSevDxe. But, only CloudHvX64 and OvmfPkgX64 adds reserve snp pages. So, I want to confirm whether others require reserve snp pages. 

AmdSev\AmdSevX64.fdf
Bhyve\BhyveX64.fdf
CloudHv\CloudHvX64.fdf
OvmfPkgIa32X64.fdf
OvmfPkgX64.fdf
OvmfXen.fdf

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Brijesh Singh
> via groups.io
> 发送时间: 2022年2月17日 0:28
> 收件人: Gerd Hoffmann <kraxel@redhat.com>; devel@edk2.groups.io
> 抄送: brijesh.singh@amd.com; Jordan Justen <jordan.l.justen@intel.com>;
> James Bottomley <jejb@linux.ibm.com>; Pawel Polawski
> <ppolawsk@redhat.com>; Erdem Aktas <erdemaktas@google.com>; Ard
> Biesheuvel <ardb+tianocore@kernel.org>; Tom Lendacky
> <thomas.lendacky@amd.com>; Min Xu <min.m.xu@intel.com>; Jiewen Yao
> <jiewen.yao@intel.com>
> 主题: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/AmdSev: reserve snp pages
> 
> 
> 
> On 2/16/22 01:00, Gerd Hoffmann wrote:
> > The SNP patch series updated the OvmfPkgX64 build but forgot the AmdSev
> > variant, resulting in a broken OvmfSevMetadata table.
> >
> > Fixes: cca9cd3dd6bf ("OvmfPkg: reserve CPUID page")
> > Fixes: 707c71a01b9d ("OvmfPkg: reserve SNP secrets page")
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> 
> Thanks Gerd
> 
> Reviewed-by: Brijesh Singh <brijesh.singh@amd.com>
> 
> 
> 
> 
> 

Re: 回复: [edk2-devel] [PATCH 1/1] OvmfPkg/AmdSev: reserve snp pages

[Brijesh Singh]

Hi Liming,

The said PCD is applicable for the SNP. SNP is supported on x86 64-bit 
only, and most of the development is focused around Qemu/OVMF. In other 
words, the Bhyve, Xen, and CloudHV do not support the SNP yet. We can 
revisit it when those HV starts supporting the SNP.

thanks
Brijesh

On 2/16/22 23:13, gaoliming wrote:
> Gerd and Brijesh:
>   I see six FDF files include AmdSevDxe. But, only CloudHvX64 and OvmfPkgX64 adds reserve snp pages. So, I want to confirm whether others require reserve snp pages.
> 
> AmdSev\AmdSevX64.fdf
> Bhyve\BhyveX64.fdf
> CloudHv\CloudHvX64.fdf
> OvmfPkgIa32X64.fdf
> OvmfPkgX64.fdf
> OvmfXen.fdf
> 
> Thanks
> Liming
>> -----邮件原件-----
>> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Brijesh Singh
>> via groups.io
>> 发送时间: 2022年2月17日 0:28
>> 收件人: Gerd Hoffmann <kraxel@redhat.com>; devel@edk2.groups.io
>> 抄送: brijesh.singh@amd.com; Jordan Justen <jordan.l.justen@intel.com>;
>> James Bottomley <jejb@linux.ibm.com>; Pawel Polawski
>> <ppolawsk@redhat.com>; Erdem Aktas <erdemaktas@google.com>; Ard
>> Biesheuvel <ardb+tianocore@kernel.org>; Tom Lendacky
>> <thomas.lendacky@amd.com>; Min Xu <min.m.xu@intel.com>; Jiewen Yao
>> <jiewen.yao@intel.com>
>> 主题: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/AmdSev: reserve snp pages
>>
>>
>>
>> On 2/16/22 01:00, Gerd Hoffmann wrote:
>>> The SNP patch series updated the OvmfPkgX64 build but forgot the AmdSev
>>> variant, resulting in a broken OvmfSevMetadata table.
>>>
>>> Fixes: cca9cd3dd6bf ("OvmfPkg: reserve CPUID page")
>>> Fixes: 707c71a01b9d ("OvmfPkg: reserve SNP secrets page")
>>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>>
>> Thanks Gerd
>>
>> Reviewed-by: Brijesh Singh <brijesh.singh@amd.com>
>>
>>
>>
>> 
>>
> 
> 
> 

Re: 回复: [edk2-devel] [PATCH 1/1] OvmfPkg/AmdSev: reserve snp pages

[Gerd Hoffmann]

On Mon, Feb 21, 2022 at 09:07:17AM -0600, Brijesh Singh wrote:
> Hi Liming,
> 
> The said PCD is applicable for the SNP. SNP is supported on x86 64-bit only,
> and most of the development is focused around Qemu/OVMF. In other words, the
> Bhyve, Xen, and CloudHV do not support the SNP yet. We can revisit it when
> those HV starts supporting the SNP.

Is there some #define set when building with support for SEV and/or SNP?
If not, should we add one?

I think it would make sense to just not include the OvmfSevMetadata
table (and other metadata) at all when the build doesn't support it.

take care,
  Gerd

Re: 回复: [edk2-devel] [PATCH 1/1] OvmfPkg/AmdSev: reserve snp pages

[Yao, Jiewen]

Acked-by: Jiewen Yao <Jiewen.yao@intel.com>

> -----Original Message-----
> From: Brijesh Singh <brijesh.singh@amd.com>
> Sent: Monday, February 21, 2022 11:07 PM
> To: Gao, Liming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; 'Gerd
> Hoffmann' <kraxel@redhat.com>
> Cc: brijesh.singh@amd.com; Justen, Jordan L <jordan.l.justen@intel.com>;
> 'James Bottomley' <jejb@linux.ibm.com>; 'Pawel Polawski'
> <ppolawsk@redhat.com>; Aktas, Erdem <erdemaktas@google.com>; 'Ard
> Biesheuvel' <ardb+tianocore@kernel.org>; 'Tom Lendacky'
> <thomas.lendacky@amd.com>; Xu, Min M <min.m.xu@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>
> Subject: Re: 回复: [edk2-devel] [PATCH 1/1] OvmfPkg/AmdSev: reserve snp
> pages
> 
> Hi Liming,
> 
> The said PCD is applicable for the SNP. SNP is supported on x86 64-bit
> only, and most of the development is focused around Qemu/OVMF. In other
> words, the Bhyve, Xen, and CloudHV do not support the SNP yet. We can
> revisit it when those HV starts supporting the SNP.
> 
> thanks
> Brijesh
> 
> On 2/16/22 23:13, gaoliming wrote:
> > Gerd and Brijesh:
> >   I see six FDF files include AmdSevDxe. But, only CloudHvX64 and OvmfPkgX64
> adds reserve snp pages. So, I want to confirm whether others require reserve
> snp pages.
> >
> > AmdSev\AmdSevX64.fdf
> > Bhyve\BhyveX64.fdf
> > CloudHv\CloudHvX64.fdf
> > OvmfPkgIa32X64.fdf
> > OvmfPkgX64.fdf
> > OvmfXen.fdf
> >
> > Thanks
> > Liming
> >> -----邮件原件-----
> >> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Brijesh Singh
> >> via groups.io
> >> 发送时间: 2022年2月17日 0:28
> >> 收件人: Gerd Hoffmann <kraxel@redhat.com>; devel@edk2.groups.io
> >> 抄送: brijesh.singh@amd.com; Jordan Justen <jordan.l.justen@intel.com>;
> >> James Bottomley <jejb@linux.ibm.com>; Pawel Polawski
> >> <ppolawsk@redhat.com>; Erdem Aktas <erdemaktas@google.com>; Ard
> >> Biesheuvel <ardb+tianocore@kernel.org>; Tom Lendacky
> >> <thomas.lendacky@amd.com>; Min Xu <min.m.xu@intel.com>; Jiewen Yao
> >> <jiewen.yao@intel.com>
> >> 主题: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/AmdSev: reserve snp pages
> >>
> >>
> >>
> >> On 2/16/22 01:00, Gerd Hoffmann wrote:
> >>> The SNP patch series updated the OvmfPkgX64 build but forgot the AmdSev
> >>> variant, resulting in a broken OvmfSevMetadata table.
> >>>
> >>> Fixes: cca9cd3dd6bf ("OvmfPkg: reserve CPUID page")
> >>> Fixes: 707c71a01b9d ("OvmfPkg: reserve SNP secrets page")
> >>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> >>
> >> Thanks Gerd
> >>
> >> Reviewed-by: Brijesh Singh <brijesh.singh@amd.com>
> >>
> >>
> >>
> >> 
> >>
> >
> >
> >

Re: 回复: [edk2-devel] [PATCH 1/1] OvmfPkg/AmdSev: reserve snp pages

[Yao, Jiewen]

Merged - 65212ff

https://github.com/tianocore/edk2/pull/2553

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao, Jiewen
> Sent: Monday, February 28, 2022 10:17 AM
> To: Brijesh Singh <brijesh.singh@amd.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; 'Gerd Hoffmann'
> <kraxel@redhat.com>
> Cc: Justen, Jordan L <jordan.l.justen@intel.com>; 'James Bottomley'
> <jejb@linux.ibm.com>; 'Pawel Polawski' <ppolawsk@redhat.com>; Aktas,
> Erdem <erdemaktas@google.com>; 'Ard Biesheuvel'
> <ardb+tianocore@kernel.org>; 'Tom Lendacky' <thomas.lendacky@amd.com>;
> Xu, Min M <min.m.xu@intel.com>
> Subject: Re: 回复: [edk2-devel] [PATCH 1/1] OvmfPkg/AmdSev: reserve snp
> pages
> 
> Acked-by: Jiewen Yao <Jiewen.yao@intel.com>
> 
> > -----Original Message-----
> > From: Brijesh Singh <brijesh.singh@amd.com>
> > Sent: Monday, February 21, 2022 11:07 PM
> > To: Gao, Liming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; 'Gerd
> > Hoffmann' <kraxel@redhat.com>
> > Cc: brijesh.singh@amd.com; Justen, Jordan L <jordan.l.justen@intel.com>;
> > 'James Bottomley' <jejb@linux.ibm.com>; 'Pawel Polawski'
> > <ppolawsk@redhat.com>; Aktas, Erdem <erdemaktas@google.com>; 'Ard
> > Biesheuvel' <ardb+tianocore@kernel.org>; 'Tom Lendacky'
> > <thomas.lendacky@amd.com>; Xu, Min M <min.m.xu@intel.com>; Yao,
> Jiewen
> > <jiewen.yao@intel.com>
> > Subject: Re: 回复: [edk2-devel] [PATCH 1/1] OvmfPkg/AmdSev: reserve snp
> > pages
> >
> > Hi Liming,
> >
> > The said PCD is applicable for the SNP. SNP is supported on x86 64-bit
> > only, and most of the development is focused around Qemu/OVMF. In other
> > words, the Bhyve, Xen, and CloudHV do not support the SNP yet. We can
> > revisit it when those HV starts supporting the SNP.
> >
> > thanks
> > Brijesh
> >
> > On 2/16/22 23:13, gaoliming wrote:
> > > Gerd and Brijesh:
> > >   I see six FDF files include AmdSevDxe. But, only CloudHvX64 and
> OvmfPkgX64
> > adds reserve snp pages. So, I want to confirm whether others require reserve
> > snp pages.
> > >
> > > AmdSev\AmdSevX64.fdf
> > > Bhyve\BhyveX64.fdf
> > > CloudHv\CloudHvX64.fdf
> > > OvmfPkgIa32X64.fdf
> > > OvmfPkgX64.fdf
> > > OvmfXen.fdf
> > >
> > > Thanks
> > > Liming
> > >> -----邮件原件-----
> > >> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Brijesh Singh
> > >> via groups.io
> > >> 发送时间: 2022年2月17日 0:28
> > >> 收件人: Gerd Hoffmann <kraxel@redhat.com>; devel@edk2.groups.io
> > >> 抄送: brijesh.singh@amd.com; Jordan Justen <jordan.l.justen@intel.com>;
> > >> James Bottomley <jejb@linux.ibm.com>; Pawel Polawski
> > >> <ppolawsk@redhat.com>; Erdem Aktas <erdemaktas@google.com>; Ard
> > >> Biesheuvel <ardb+tianocore@kernel.org>; Tom Lendacky
> > >> <thomas.lendacky@amd.com>; Min Xu <min.m.xu@intel.com>; Jiewen Yao
> > >> <jiewen.yao@intel.com>
> > >> 主题: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/AmdSev: reserve snp pages
> > >>
> > >>
> > >>
> > >> On 2/16/22 01:00, Gerd Hoffmann wrote:
> > >>> The SNP patch series updated the OvmfPkgX64 build but forgot the
> AmdSev
> > >>> variant, resulting in a broken OvmfSevMetadata table.
> > >>>
> > >>> Fixes: cca9cd3dd6bf ("OvmfPkg: reserve CPUID page")
> > >>> Fixes: 707c71a01b9d ("OvmfPkg: reserve SNP secrets page")
> > >>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > >>
> > >> Thanks Gerd
> > >>
> > >> Reviewed-by: Brijesh Singh <brijesh.singh@amd.com>
> > >>
> > >>
> > >>
> > >>
> > >>
> > >
> > >
> > >
> 
> 
> 
>