From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from zrleap.intel-email.com (zrleap.intel-email.com [114.80.218.36]) by mx.groups.io with SMTP id smtpd.web10.2643.1683593652158227089 for ; Mon, 08 May 2023 17:54:13 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=ictNz8cX; spf=pass (domain: byosoft.com.cn, ip: 114.80.218.36, mailfrom: gaoliming@byosoft.com.cn) Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 1052FA32E0DC for ; Tue, 9 May 2023 08:54:06 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1683593646; bh=yqthrrgybR2mEWv/hFZPGvdBwKVrJRqEpiGjKjZBV/0=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=ictNz8cXlrEaDg+UeOhT5jMoITmLarH5wAwQrLl+Wc8DetL24vBJ+097daPl4u8ru 5mLMO8onda5vxB2QjqELPu5/tiKl4YmkFbEFC1lNA3LRRWzm0aJzf1Sm7ktoxJd28j U7xp0A5oOLl8fBdbPHDIz993klbISNgHZL11KegA= Received: from localhost (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id E8CAFA32E111 for ; Tue, 9 May 2023 08:54:05 +0800 (CST) Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 9EB1FA32E0C7 for ; Tue, 9 May 2023 08:54:05 +0800 (CST) Authentication-Results: zrleap.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by zrleap.intel-email.com (Postfix) with SMTP id 25104A32E0E3 for ; Tue, 9 May 2023 08:54:02 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Tue, 09 May 2023 08:53:53 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , "'Rebecca Cran'" Cc: "'Bob Feng'" , "'Yuwei Chen'" , "'Andrew Fish'" , "'Leif Lindholm'" , "'Michael D Kinney'" References: <20230506182311.14023-1-rebecca@bsdio.com> <175CA4E73380D66F.2502@groups.io> <3e01cc9e-ac5f-bf4d-0359-adfc1aa21c4b@bsdio.com> <7e3cccac-ade2-7a5c-29e0-50c080a31abe@bsdio.com> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIDEvMV0gUmVtb3ZlIGJhc2hpc21zIGZyb20gZWRrc2V0dXAuc2ggYW5kIEJhc2VUb29scy9CdWlsZEVudg==?= Date: Tue, 9 May 2023 08:53:55 +0800 Message-ID: <025401d98210$bb90b1d0$32b21570$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQG3FSmQUN67Y6GM0pTnTG9Mun8yRwJWeOVPARDazyAB7bchPQKYVL9eAe/dwnkCCdk05K82vlkQ Sender: "gaoliming" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Reviewed-by: Liming Gao > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Pedro Falcato > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B45=E6=9C=887=E6=97=A5 1= 1:51 > =E6=94=B6=E4=BB=B6=E4=BA=BA: Rebecca Cran > =E6=8A=84=E9=80=81: devel@edk2.groups.io; Liming Gao ; Bob > Feng ; Yuwei Chen ; Andrew > Fish ; Leif Lindholm ; > Michael D Kinney > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH 1/1] Remove bashisms from edk= setup.sh and > BaseTools/BuildEnv >=20 > On Sun, May 7, 2023 at 4:31=E2=80=AFAM Rebecca Cran w= rote: > > > > On 5/6/23 15:48, Pedro Falcato wrote: > > > > > > My local installations of Net (latest stable) and FreeBSD (13.1 with = a > > > hacked-up kernel) do not have a python3 symlink. > > > > > > I'm slightly worried that this breaks something. I know requiring > > > whereis isn't ideal, but I'm fairly sure it did handle this situation= ? > > > > I uninstalled the python and python3 packages, leaving only python39. > > > > I got the following results on edk2 master: > > > > > > [bcran@maxamd ~/src/uefi/edk2]$ whereis python3 > > python3: > > > > [bcran@maxamd ~/src/uefi/edk2]$ ls /usr/local/bin | grep python > > > > python3.9 > > > > python3.9-config > > > > [bcran@maxamd ~/src/uefi/edk2]$ . edksetup.sh > > Using EDK2 in-source Basetools > > WORKSPACE: /home/bcran/src/uefi/edk2 > > EDK_TOOLS_PATH: /home/bcran/src/uefi/edk2/BaseTools > > > > CONF_PATH: /home/bcran/src/uefi/edk2/Conf > > > > > > [bcran@maxamd ~/src/uefi/edk2]$ echo $PYTHON_COMMAND > > > > [bcran@maxamd ~/src/uefi/edk2]$ gmake -C BaseTools/ -j16 > > gmake: Entering directory '/usr/home/bcran/src/uefi/edk2/BaseTools' > > gmake -C Source/C > > gmake -C Source/Python > > gmake[1]: Entering directory > > '/usr/home/bcran/src/uefi/edk2/BaseTools/Source/C' > > gmake[1]: Entering directory > > '/usr/home/bcran/src/uefi/edk2/BaseTools/Source/Python' > > gmake[1]: Nothing to be done for 'all'. > > gmake[1]: Leaving directory > > '/usr/home/bcran/src/uefi/edk2/BaseTools/Source/Python' > > Attempting to detect HOST_ARCH from 'uname -m': amd64 > > Detected HOST_ARCH of X64 using uname. > > mkdir -p . > > mkdir ./libs > > mkdir ./bin > > gmake -C VfrCompile VfrLexer.h > > gmake -C Common > > gmake[2]: Entering directory > > '/usr/home/bcran/src/uefi/edk2/BaseTools/Source/C/VfrCompile' > > gmake[2]: Entering directory > > '/usr/home/bcran/src/uefi/edk2/BaseTools/Source/C/Common' > > > > ..... > > > > Finished building BaseTools C Tools with HOST_ARCH=3DX64 > > gmake[1]: Leaving directory > > '/usr/home/bcran/src/uefi/edk2/BaseTools/Source/C' > > gmake -C Tests > > gmake[1]: Entering directory > '/usr/home/bcran/src/uefi/edk2/BaseTools/Tests' > > /bin/sh: python: not found > > gmake[1]: *** [GNUmakefile:11: test] Error 127 > > gmake[1]: Leaving directory > '/usr/home/bcran/src/uefi/edk2/BaseTools/Tests' > > gmake: *** [GNUmakefile:19: Tests] Error 2 > > gmake: Leaving directory '/usr/home/bcran/src/uefi/edk2/BaseTools' > > ... > > > > [bcran@maxamd ~/src/uefi/edk2]$ build -p OvmfPkg/OvmfPkgX64.dsc -a > X64 > > -t GCC -b RELEASE > > /home/bcran/src/uefi/edk2/BaseTools/BinWrappers/PosixLike/build: line > > 14: exec: python: not found >=20 > Thank you for your testing. I asked around and came to the conclusion > it's a FreeBSD "meta-package" that lots of people don't have > installed. >=20 > If this doesn't break anything, I'm ok with it. Although there should > really be a better solution, the status quo sucks. >=20 > That said, the rest of the POSIX sh conversion looks ok to me. >=20 > Acked-by: Pedro Falcato >=20 > Although there's a small fixup you may want to do at > >echo "source $SCRIPTNAME" > Since source is not POSIX, but '.' is. >=20 > -- > Pedro >=20 >=20 >=20 >=20