From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from zrleap.intel-email.com (zrleap.intel-email.com [114.80.218.36]) by mx.groups.io with SMTP id smtpd.web11.28885.1683351584419154002 for ; Fri, 05 May 2023 22:39:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=exM0zPUq; spf=pass (domain: byosoft.com.cn, ip: 114.80.218.36, mailfrom: gaoliming@byosoft.com.cn) Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 25885A32E02B for ; Sat, 6 May 2023 13:39:39 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1683351579; bh=9kIx66QPuu/KXuJ7k6/Dlz1XTEXxZnF60WdUOxhGBaM=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=exM0zPUqA9QMDdAW6VLi/F3cflJvDIhD/O3BfxC9nfpQKCFz51NCT/wYpTe+f4Dsk 3YgcAwpgTOos2JI1AboFQArrO0AIp3HOUdUmY5H59yYyKW9i8EKoIKUDvxIRJ8+sBw nkBkQ55iqV3XTa0UkO0SAF5+Fd31Aiq1j4IiQCE8= Received: from localhost (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 1207CA32E000 for ; Sat, 6 May 2023 13:39:39 +0800 (CST) Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id A27B0A32DFDE for ; Sat, 6 May 2023 13:39:38 +0800 (CST) Authentication-Results: zrleap.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by zrleap.intel-email.com (Postfix) with SMTP id 16456A32E03E for ; Sat, 6 May 2023 13:39:35 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Sat, 06 May 2023 13:39:31 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Kinney, Michael D'" , Cc: "'Rebecca Cran'" , "'Feng, Bob C'" , "'Chen, Christine'" References: <20230506024636.1245-1-michael.d.kinney@intel.com> <024501d97fc7$02d010f0$087032d0$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BhdGNoIDEvMV0gQmFzZVRvb2xzL0NvbmY6IEFkZCBxdW90ZXMgdG8gQUREREVCVUdGTEFHIGluIHRvb2xzX2RlZi50eHQ=?= Date: Sat, 6 May 2023 13:39:31 +0800 Message-ID: <026301d97fdd$21f3dc30$65db9490$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQKsbFUGusFL+cZinLUiUsNZifAx+wG0llDsAbkN4GCti3Mt4A== Sender: "gaoliming" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Mike: I also see GCC_DLINK2_FLAGS_COMMON option uses / as the file path. Does i= t bring the same problem in Windows OS? DEFINE GCC_DLINK2_FLAGS_COMMON =3D -Wl,--script=3D$(EDK_TOOLS_PATH)/Scr= ipts/GccBase.lds=20 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: Kinney, Michael D > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B45=E6=9C=886=E6=97=A5 1= 2:55 > =E6=94=B6=E4=BB=B6=E4=BA=BA: Gao, Liming ; deve= l@edk2.groups.io > =E6=8A=84=E9=80=81: 'Rebecca Cran' ; Feng, Bob C > ; Chen, Christine ; Kinney, > Michael D > =E4=B8=BB=E9=A2=98: RE: [edk2-devel] [Patch 1/1] BaseTools/Conf: Add quot= es to > ADDDEBUGFLAG in tools_def.txt >=20 > The issue I saw was a mix of / and \ in the file path. On Windows > $(DEBUG_DIR) would > Have '\' in path and then a '/' before $(MODULE_NAME). Without the > quotes, this > would generate an error. With quotes, it would get the full filename cor= rect. >=20 > On Linux, only '/' are used for the whole path and everything works with = and > Without quotes. >=20 > Mike >=20 > > -----Original Message----- > > From: gaoliming > > Sent: Friday, May 5, 2023 8:01 PM > > To: devel@edk2.groups.io; Kinney, Michael D > > > Cc: 'Rebecca Cran' ; Feng, Bob C > > ; Chen, Christine > > Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] [Patch 1/1] BaseTools/Conf: A= dd quotes to > > ADDDEBUGFLAG in tools_def.txt > > > > Mike: > > Do you mean $(DEBUG_DIR)/$(MODULE_NAME).debug file path may > have > > space on > > windows OS? Does the workspace directory include the space? > > > > Thanks > > Liming > > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =E4=BB=A3=E8=A1=A8 Michael > D > > > Kinney > > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B45=E6=9C=886=E6=97= =A5 10:47 > > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > > > =E6=8A=84=E9=80=81: Rebecca Cran ; Liming Gao > > > ; Bob Feng ; Yuwei > > Chen > > > > > > =E4=B8=BB=E9=A2=98: [edk2-devel] [Patch 1/1] BaseTools/Conf: Add quot= es to > > > ADDDEBUGFLAG in tools_def.txt > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4448 > > > > > > Update tools_def.txt to add quotes around the file target in > > > OBJCOPY_ADDDEBUGFLAGS for compatibility with GCC like tool > > > chains used on Windows. > > > > > > Cc: Rebecca Cran > > > Cc: Liming Gao > > > Cc: Bob Feng > > > Cc: Yuwei Chen > > > Signed-off-by: Michael D Kinney > > > --- > > > BaseTools/Conf/tools_def.template | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/BaseTools/Conf/tools_def.template > > > b/BaseTools/Conf/tools_def.template > > > index 1b3a9e7a540a..535dda1d5d99 100755 > > > --- a/BaseTools/Conf/tools_def.template > > > +++ b/BaseTools/Conf/tools_def.template > > > @@ -731,9 +731,9 @@ NOOPT_VS2019_AARCH64_DLINK_FLAGS =3D > > > /NOLOGO /NODEFAULTLIB /IGNORE:4001 /OPT:REF > > > *_*_*_OBJCOPY_FLAGS =3D objcopy not needed for > > > *_*_*_SYMRENAME_PATH =3D echo > > > *_*_*_SYMRENAME_FLAGS =3D Symbol renaming not > needed for > > > -DEBUG_*_*_OBJCOPY_ADDDEBUGFLAG =3D > > > --add-gnu-debuglink=3D$(DEBUG_DIR)/$(MODULE_NAME).debug > > > +DEBUG_*_*_OBJCOPY_ADDDEBUGFLAG =3D > > > --add-gnu-debuglink=3D"$(DEBUG_DIR)/$(MODULE_NAME).debug" > > > RELEASE_*_*_OBJCOPY_ADDDEBUGFLAG =3D > > > -NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG =3D > > > --add-gnu-debuglink=3D$(DEBUG_DIR)/$(MODULE_NAME).debug > > > +NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG =3D > > > --add-gnu-debuglink=3D"$(DEBUG_DIR)/$(MODULE_NAME).debug" > > > *_*_*_OBJCOPY_STRIPFLAG =3D --strip-unneeded > -R .eh_frame > > > *_*_*_DTC_FLAGS =3D -H epapr > > > *_*_*_DTCPP_PATH =3D DEF(DTCPP_BIN) > > > -- > > > 2.40.1.windows.1 > > > > > > > > > > > >=20 > > > > > > >