From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from walk.intel-email.com (walk.intel-email.com [101.227.64.242]) by mx.groups.io with SMTP id smtpd.web11.2778.1667869421236446550 for ; Mon, 07 Nov 2022 17:03:46 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=JvJlbzF3; spf=pass (domain: byosoft.com.cn, ip: 101.227.64.242, mailfrom: gaoliming@byosoft.com.cn) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id E4425CD1F748 for ; Tue, 8 Nov 2022 09:03:35 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1667869416; bh=15DqCSXx9rhnTwpTlzxyjqXXdAhTaXkztX59tRwN/hk=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=JvJlbzF3xZgX18iOYuStToeRyqc6Ood9YyOygrr+Phmzc+B6um+0VO8yw902w/qKW ce/y7M76wW/l1EJeF9cjg2lFROpKJbv3Uhz5eC647AoDFJEZI62PDkefF2AbrGk4K9 y9gUWBCqfNFyoXR/1GHCT1PwZkg9m8aHOdFXdEaM= Received: from localhost (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id E02AFCD1F72B for ; Tue, 8 Nov 2022 09:03:35 +0800 (CST) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id B0FAFCD1F6F4 for ; Tue, 8 Nov 2022 09:03:35 +0800 (CST) Authentication-Results: walk.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by walk.intel-email.com (Postfix) with SMTP id 18934CD1F737 for ; Tue, 8 Nov 2022 09:03:31 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Tue, 08 Nov 2022 09:03:30 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , Cc: "'Feng, Bob C'" , "'Chen, Christine'" References: <20221105203536.1559-1-michael.d.kinney@intel.com> <019501d8f260$9f2194f0$dd64bed0$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0g5Zue5aSNOiBbUGF0Y2ggMS8xXSBCYXNlVG9vbHMvU291cmNlL0M6IFVzZSAvWjcgaW5zdGVhZCBvZiAvWmkgZm9yIGhvc3QgdG9vbHM=?= Date: Tue, 8 Nov 2022 09:03:30 +0800 Message-ID: <026401d8f30d$eac5ddf0$c05199d0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQI3bM1RRZg3F7dM/jU9dlifsWhGVALL3110Af9tTyGtUObg4A== Sender: "gaoliming" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Mike: I agree there is no impact with debug symbol in the binary C tools.=20 But, the release version binary C tools should be better for the developer= . If you think this change is big, I will submit one BZ for future stable t= ag release.=20 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Michael D > Kinney > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B411=E6=9C=887=E6=97=A5 = 15:21 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; Gao, Liming ; > Kinney, Michael D > =E6=8A=84=E9=80=81: Feng, Bob C ; Chen, Christine > > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] =E5=9B=9E=E5=A4=8D: [Patch 1/1] Base= Tools/Source/C: Use /Z7 > instead of /Zi for host tools >=20 > Hi Liming, >=20 > That seems like a bigger change. >=20 > I see no harm in always producing symbols when build C host tools. >=20 > Mike >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of > gaoliming via groups.io > > Sent: Sunday, November 6, 2022 8:23 PM > > To: Kinney, Michael D ; > devel@edk2.groups.io > > Cc: Feng, Bob C ; Chen, Christine > > > Subject: [edk2-devel] =E5=9B=9E=E5=A4=8D: [Patch 1/1] BaseTools/Source/= C: Use /Z7 > instead of /Zi for host tools > > > > Mike: > > I suggest to remove /Zi and /DEBUG option for BaseTools C tool > generation, > > because only tool developer may require the debug version C tool. > > > > Thanks > > Liming > > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > > =E5=8F=91=E4=BB=B6=E4=BA=BA: Michael D Kinney > > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B411=E6=9C=886=E6=97= =A5 4:36 > > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > > > =E6=8A=84=E9=80=81: Bob Feng ; Liming Gao > > > ; Yuwei Chen > > > =E4=B8=BB=E9=A2=98: [Patch 1/1] BaseTools/Source/C: Use /Z7 instead o= f /Zi for host > > tools > > > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4139 > > > > > > Update ms.common and *.mak files to use /Z7 instead of /Zi to embed > > > symbol information in obj files for host tools built with VS compiler= s. > > > This prevents vcxxx.pdb files from being generated in the root of > > > the local edk2 repository or in BaseTools directories. > > > > > > Cc: Bob Feng > > > Cc: Liming Gao > > > Cc: Yuwei Chen > > > Signed-off-by: Michael D Kinney > > > --- > > > BaseTools/Source/C/Makefiles/ms.common | 5 > ++--- > > > BaseTools/Source/C/VfrCompile/Pccts/antlr/AntlrDDK.mak | 4 ++-- > > > BaseTools/Source/C/VfrCompile/Pccts/antlr/AntlrMS.mak | 6 +++--- > > > BaseTools/Source/C/VfrCompile/Pccts/dlg/DlgDDK.mak | 4 ++-- > > > BaseTools/Source/C/VfrCompile/Pccts/dlg/DlgMS.mak | 7 > +++---- > > > 5 files changed, 12 insertions(+), 14 deletions(-) > > > > > > diff --git a/BaseTools/Source/C/Makefiles/ms.common > > > b/BaseTools/Source/C/Makefiles/ms.common > > > index b2dbcf376c04..8391f10d5dd2 100644 > > > --- a/BaseTools/Source/C/Makefiles/ms.common > > > +++ b/BaseTools/Source/C/Makefiles/ms.common > > > @@ -57,6 +57,5 @@ LINKER =3D $(LD) > > > > > > INC =3D $(INC) -I . -I $(SOURCE_PATH)\Include -I $(ARCH_INCLUDE) -I > > > $(SOURCE_PATH)\Common > > > > > > -CFLAGS =3D $(CFLAGS) /nologo /Zi /c /O2 /MT /W4 /WX /D > > > _CRT_SECURE_NO_DEPRECATE /D _CRT_NONSTDC_NO_DEPRECATE > > > -CPPFLAGS =3D $(CPPFLAGS) /EHsc /nologo /Zi /c /O2 /MT /D > > > _CRT_SECURE_NO_DEPRECATE /D _CRT_NONSTDC_NO_DEPRECATE > > > - > > > +CFLAGS =3D $(CFLAGS) /nologo /Z7 /c /O2 /MT /W4 /WX /D > > > _CRT_SECURE_NO_DEPRECATE /D _CRT_NONSTDC_NO_DEPRECATE > > > +CPPFLAGS =3D $(CPPFLAGS) /EHsc /nologo /Z7 /c /O2 /MT /D > > > _CRT_SECURE_NO_DEPRECATE /D _CRT_NONSTDC_NO_DEPRECATE > > > diff --git a/BaseTools/Source/C/VfrCompile/Pccts/antlr/AntlrDDK.mak > > > b/BaseTools/Source/C/VfrCompile/Pccts/antlr/AntlrDDK.mak > > > index 71b7c6b0b141..cde91a47159e 100644 > > > --- a/BaseTools/Source/C/VfrCompile/Pccts/antlr/AntlrDDK.mak > > > +++ b/BaseTools/Source/C/VfrCompile/Pccts/antlr/AntlrDDK.mak > > > @@ -16,7 +16,7 @@ SET=3D$(PCCTS_HOME)\support\set > > > # Compiler stuff > > > CC =3D cl > > > CFLAGS =3D /nologo -I "." -I "$(PCCTS_H)" -I "$(SET)" -D "USER_ZZSYN= " -D > > "PC" > > > \ > > > - -D "ZZLEXBUFSIZE=3D65536" -D "LONGFILENAMES" /Zi /W3 > > > -D__USE_PROTOS /wd4700 > > > + -D "ZZLEXBUFSIZE=3D65536" -D "LONGFILENAMES" /Z7 /W3 > > > -D__USE_PROTOS /wd4700 > > > > > > ANTLR_OBJS =3D antlr.obj scan.obj err.obj bits.obj build.obj fset2.o= bj \ > > > fset.obj gen.obj globals.obj hash.obj lex.obj main.obj \ > > > @@ -225,7 +225,7 @@ set.obj: $(SET)\set.c \ > > > > > > $(CC) -c $(CFLAGS) $(SET)\set.c > > > > > > -clean: > > > +clean: > > > del *.obj > > > > > > distclean: > > > diff --git a/BaseTools/Source/C/VfrCompile/Pccts/antlr/AntlrMS.mak > > > b/BaseTools/Source/C/VfrCompile/Pccts/antlr/AntlrMS.mak > > > index b30a73bb7424..6fc4d5c15d6c 100644 > > > --- a/BaseTools/Source/C/VfrCompile/Pccts/antlr/AntlrMS.mak > > > +++ b/BaseTools/Source/C/VfrCompile/Pccts/antlr/AntlrMS.mak > > > @@ -16,8 +16,8 @@ SET=3D$(PCCTS_HOME)\support\set > > > # Compiler stuff > > > CC =3D cl > > > CFLAGS =3D /nologo -I "." -I "$(PCCTS_H)" -I "$(SET)" -D "USER_ZZSYN= " -D > > "PC" > > > \ > > > - -D "ZZLEXBUFSIZE=3D65536" /D "LONGFILENAMES" /Zi /W3 > > > -D__USE_PROTOS /wd4700 \ > > > - /D _CRT_SECURE_NO_DEPRECATE /D > > > _CRT_NONSTDC_NO_DEPRECATE > > > + -D "ZZLEXBUFSIZE=3D65536" /D "LONGFILENAMES" /Z7 /W3 > > > -D__USE_PROTOS /wd4700 \ > > > + /D _CRT_SECURE_NO_DEPRECATE /D > > > _CRT_NONSTDC_NO_DEPRECATE > > > > > > ANTLR_OBJS =3D antlr.obj scan.obj err.obj bits.obj build.obj fset2.o= bj \ > > > fset.obj gen.obj globals.obj hash.obj lex.obj main.obj \ > > > @@ -226,7 +226,7 @@ set.obj: $(SET)\set.c \ > > > > > > $(CC) -c $(CFLAGS) $(SET)\set.c > > > > > > -clean: > > > +clean: > > > -del *.obj > > > -del *.ilk > > > -del *.pdb > > > diff --git a/BaseTools/Source/C/VfrCompile/Pccts/dlg/DlgDDK.mak > > > b/BaseTools/Source/C/VfrCompile/Pccts/dlg/DlgDDK.mak > > > index 156d524acc94..dcc259543c4c 100644 > > > --- a/BaseTools/Source/C/VfrCompile/Pccts/dlg/DlgDDK.mak > > > +++ b/BaseTools/Source/C/VfrCompile/Pccts/dlg/DlgDDK.mak > > > @@ -16,7 +16,7 @@ SET=3D$(PCCTS_HOME)\support\set > > > # Compiler stuff > > > CC =3D cl > > > CFLAGS =3D /nologo -I "." -I "$(PCCTS_H)" -I "$(SET)" -D "USER_ZZSYN= " -D > > "PC" > > > \ > > > - -D "ZZLEXBUFSIZE=3D65536" /D "LONGFILENAMES" /W3 /Zi > > > + -D "ZZLEXBUFSIZE=3D65536" /D "LONGFILENAMES" /W3 /Z7 > > > > > > DLG_OBJS =3D dlg_p.obj dlg_a.obj main.obj err.obj support.obj \ > > > output.obj relabel.obj automata.obj > > > @@ -113,7 +113,7 @@ set.obj: $(SET)\set.c \ > > > > > > $(CC) -c $(CFLAGS) $(SET)\set.c > > > > > > -clean: > > > +clean: > > > del *.obj > > > > > > distclean: > > > diff --git a/BaseTools/Source/C/VfrCompile/Pccts/dlg/DlgMS.mak > > > b/BaseTools/Source/C/VfrCompile/Pccts/dlg/DlgMS.mak > > > index 2714308d4fa0..c2cac00f53df 100644 > > > --- a/BaseTools/Source/C/VfrCompile/Pccts/dlg/DlgMS.mak > > > +++ b/BaseTools/Source/C/VfrCompile/Pccts/dlg/DlgMS.mak > > > @@ -16,8 +16,8 @@ SET=3D$(PCCTS_HOME)\support\set > > > # Compiler stuff > > > CC =3D cl > > > CFLAGS =3D /nologo -I "." -I "$(PCCTS_H)" -I "$(SET)" -D "USER_ZZSYN= " -D > > "PC" > > > \ > > > - -D "ZZLEXBUFSIZE=3D65536" /D "LONGFILENAMES" /W3 /Zi \ > > > - /D _CRT_SECURE_NO_DEPRECATE /D > > > _CRT_NONSTDC_NO_DEPRECATE > > > + -D "ZZLEXBUFSIZE=3D65536" /D "LONGFILENAMES" /W3 /Z7 \ > > > + /D _CRT_SECURE_NO_DEPRECATE /D > > > _CRT_NONSTDC_NO_DEPRECATE > > > > > > DLG_OBJS =3D dlg_p.obj dlg_a.obj main.obj err.obj support.obj \ > > > output.obj relabel.obj automata.obj > > > @@ -112,7 +112,7 @@ set.obj: $(SET)\set.c \ > > > > > > $(CC) -c $(CFLAGS) $(SET)\set.c > > > > > > -clean: > > > +clean: > > > -del *.obj > > > -del *.ilk > > > -del *.pdb > > > @@ -123,4 +123,3 @@ cleanall: > > > -del *.pdb > > > -del *.exe > > > -del $(EDK_TOOLS_PATH)\Bin\Win32\dlg.exe > > > - > > > -- > > > 2.37.1.windows.1 > > > > > > > > > > > > > > >=20 >=20 >=20 >=20 >=20