From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id AAC29D801B0 for ; Thu, 16 Nov 2023 00:55:35 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=2NcKZkT/abxnEQftz6dnUbklypj3vy8nvjLjz4b0RFM=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20140610; t=1700096134; v=1; b=JKLhht/7NfJ6YT2LCJDnjvmhW8aVsmOLBjWBGtnhnwXaA/WTkaB8WlEZ1klqoFLn+fFPqZtV bBPIGvWC93D97ZPyhxNRyyMDaKRBrn/38pcEgfyneIVDMqVtXzzCuTUd0XsrUE++rTZGM+Kb+EQ mjtAl7KjhiEE/dXIuILk1i2Q= X-Received: by 127.0.0.2 with SMTP id zBCPYY7687511x74b8wz1gNt; Wed, 15 Nov 2023 16:55:34 -0800 X-Received: from zrleap.intel-email.com (zrleap.intel-email.com [114.80.218.36]) by mx.groups.io with SMTP id smtpd.web10.30176.1700096132641343931 for ; Wed, 15 Nov 2023 16:55:33 -0800 X-Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 0FEC9A32DFEC for ; Thu, 16 Nov 2023 08:55:28 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id C2685A32E168 for ; Thu, 16 Nov 2023 08:55:28 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by zrleap.intel-email.com (Postfix) with SMTP id 9DF37A32E1A1 for ; Thu, 16 Nov 2023 08:55:25 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Thu, 16 Nov 2023 08:55:15 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: "'Kinney, Michael D'" , "'Chang, Abner'" , "'Leif Lindholm'" , , "'Mike Maslenkin'" , Cc: "'Nickle Wang'" References: <20231114142815.1604-1-igork@ami.com> <3e8c08dc-a665-41f1-8c51-d4e2743bdac1@quicinc.com> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBlZGsyLXN0YWJsZTIwMjMxMSBDb2RlIGZyZWV6ZSBwcm9jZXNzIHZpb2xhdGlvbiBSZTogW2VkazItZGV2ZWxdIFtQQVRDSCB2NSAyLzJdIFJlZGZpc2hQa2c6IFJlZGZpc2hEaXNjb3ZlckR4ZTogT3B0aW1pemUgdGhlIFJlZGZpc2ggRGlzY292ZXIgZmxvdw==?= Date: Thu, 16 Nov 2023 08:55:18 +0800 Message-ID: <026801da1827$919456e0$b4bd04a0$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQHqXRFaHNEdLnO8P7Tj5qLmjZk0pwJT0rE4AtI0MmUCKVcsvAKW8bQmAUTjiVMCUwlCPwGKyZ5GAgciYhIB9SBina/DaQ8Q Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: CnBSKUghvzjMum9JpkzHsIEhx7686176AA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="JKLhht/7"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none Mike: Yes. We should set Read access in code freeze phase. Abner: In hard code freeze phase, the critical issue is still allowed to be merg= ed after it got approval from Stewards. Can you resend the patch with edk2-= stable202311 title to get maintainer review and Stewards approval? For the = merged code, I agree Lefi to revert it first.=20 Leif: This is my mistake. I should set the correct access in the code freeze ph= ase. For this patch, I suggest Abner goes through the critical patch review= process if this patch needs to catch this stable tag.=20 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: Kinney, Michael D > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B411=E6=9C=8816=E6=97=A5= 1:29 > =E6=94=B6=E4=BB=B6=E4=BA=BA: Chang, Abner ; Leif Lin= dholm > ; devel@edk2.groups.io; Mike Maslenkin > ; igork@ami.com; Gao, Liming > > =E6=8A=84=E9=80=81: Nickle Wang ; Kinney, Michael D > > =E4=B8=BB=E9=A2=98: RE: edk2-stable202311 Code freeze process violation R= e: [edk2-devel] > [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Disco= ver > flow >=20 > Hello, >=20 > Looks like the process for permissions needs to be adjusted during soft/h= ard > freeze. >=20 > Liming reduced EDK II Maintainers team to "Triage" for edk2 repo. >=20 > But from this documentation lists Triage as allowing add/remove labels. >=20 > https://docs.github.com/en/organizations/managing-user-access-to-your-org > anizations-repositories/managing-repository-roles/repository-roles-for-an= -org > anization >=20 > Looks like reducing to EDK II Maintainer team to "Read" is the right sett= ing for > soft/hard freeze. >=20 > Mike >=20 >=20 > > -----Original Message----- > > From: Chang, Abner > > Sent: Wednesday, November 15, 2023 3:55 AM > > To: Leif Lindholm ; devel@edk2.groups.io; > > Mike Maslenkin ; igork@ami.com; Gao, > Liming > > ; Kinney, Michael D > > > > Cc: Nickle Wang > > Subject: RE: edk2-stable202311 Code freeze process violation Re: > > [edk2-devel] [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize > > the Redfish Discover flow > > > > [AMD Official Use Only - General] > > > > Ok, Liming as we are going to revert that two commits. Is that > > possible to wait for Igor sending out another patch to address Leif's > > comment? This may delay the stable release a little bit. > > As without this patch, users may encounter the problem when sending > > request to Redfish service on the platform which have multiple NIC > > installed, > > > > Let us know, thanks! > > Abner > > > > > -----Original Message----- > > > From: Chang, Abner > > > Sent: Wednesday, November 15, 2023 7:07 PM > > > To: Leif Lindholm ; devel@edk2.groups.io; > > Mike > > > Maslenkin ; igork@ami.com; Gao, Liming > > > ; Kinney, Michael D > > > > > > Cc: Nickle Wang > > > Subject: RE: edk2-stable202311 Code freeze process violation Re: > > [edk2- > > > devel] [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the > > Redfish > > > Discover flow > > > > > > Hi Leif, > > > As we requested Liming to wait for this change last week, he > > accepted to wait > > > for the PR. But you are right, suppose I shouldn't be allowed to > > merge the > > > change during code freeze. Maybe only certain people have privilege > > to merge > > > the code during code freeze. If I still can merge the code then the > > mechanism > > > may be broken. I am fine if you would like to revert these commits. > > > > > > Regards, > > > Abner > > > > > > > -----Original Message----- > > > > From: Leif Lindholm > > > > Sent: Wednesday, November 15, 2023 6:59 PM > > > > To: devel@edk2.groups.io; Chang, Abner ; > Mike > > > > Maslenkin ; igork@ami.com; Gao, Liming > > > > ; Kinney, Michael D > > > > > > > > Cc: Nickle Wang > > > > Subject: edk2-stable202311 Code freeze process violation Re: > > [edk2-devel] > > > > [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the > > Redfish > > > > Discover flow > > > > > > > > Caution: This message originated from an External Source. Use > > proper > > > caution > > > > when opening attachments, clicking links, or responding. > > > > > > > > > > > > On 2023-11-15 03:55, Chang, Abner via groups.io wrote: > > > > > [AMD Official Use Only - General] > > > > > > > > > > Just let you know I just merged this change. Igor can help to > > follow up the > > > > suggestions given by Leif and Mike. > > > > > > > > I was under the impression merging was disabled for everyone > > except Mike > > > > and Liming during code freeze specifically to avoid this > > situation. > > > > Apparently, that isn't working. > > > > > > > > Regardless, this is a violation of the stable tag process. > > > > Liming: can you please revert these commits? > > > > > > > > Regards, > > > > > > > > Leif > > > > > > > > > Thanks > > > > > Abner > > > > > > > > > >> -----Original Message----- > > > > >> From: Chang, Abner > > > > >> Sent: Wednesday, November 15, 2023 9:20 AM > > > > >> To: Mike Maslenkin ; > > > devel@edk2.groups.io; > > > > >> igork@ami.com > > > > >> Cc: Leif Lindholm ; Nickle Wang > > > > >> > > > > >> Subject: RE: [edk2-devel] [PATCH v5 2/2] RedfishPkg: > > > RedfishDiscoverDxe: > > > > >> Optimize the Redfish Discover flow > > > > >> > > > > >> Hi Mike and Leif, > > > > >> Thanks for your comments on this change. As we are rushing to > > get this > > > > >> change to be pulled in stable release 202312 this week, I will > > just merge > > > this > > > > >> code to master branch and let the discussing keeps going. > > > > >> I think there is no functionality difference base on your > > suggestions, but > > > it's > > > > >> about the coding practice and readability. > > > > >> > > > > >> Hi Igor, > > > > >> Could you please resend the V6 after stable tag is released if > > Mike and > > > Leif's > > > > >> comment is reasonable to you? > > > > >> > > > > >> Thanks > > > > >> Abner > > > > >> > > > > >>> -----Original Message----- > > > > >>> From: Mike Maslenkin > > > > >>> Sent: Wednesday, November 15, 2023 7:53 AM > > > > >>> To: devel@edk2.groups.io; igork@ami.com > > > > >>> Cc: Leif Lindholm ; Chang, Abner > > > > >>> ; Nickle Wang > > > > >>> Subject: Re: [edk2-devel] [PATCH v5 2/2] RedfishPkg: > > > RedfishDiscoverDxe: > > > > >>> Optimize the Redfish Discover flow > > > > >>> > > > > >>> Caution: This message originated from an External Source. Use > > proper > > > > >> caution > > > > >>> when opening attachments, clicking links, or responding. > > > > >>> > > > > >>> > > > > >>> On Tue, Nov 14, 2023 at 9:57=E2=80=AFPM Igor Kulchytskyy via gr= oups.io > > > > >>> wrote: > > > > >>>> > > > > >>>> Hi Leif, > > > > >>>> Please see my comments below. > > > > >>>> Thank you, > > > > >>>> Igor > > > > >>>> > > > > >>>> > > > > >>>> -----Original Message----- > > > > >>>> From: Leif Lindholm > > > > >>>> Sent: Tuesday, November 14, 2023 12:26 PM > > > > >>>> To: devel@edk2.groups.io; Igor Kulchytskyy > > > > >>>> Cc: Abner Chang ; Nickle Wang > > > > >>> > > > > >>>> Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v5 2/2] > > RedfishPkg: > > > > >>> RedfishDiscoverDxe: Optimize the Redfish Discover flow > > > > >>>> > > > > >>>> > > > > >>>> **CAUTION: The e-mail below is from an external source. > > Please > > > exercise > > > > >>> caution before opening attachments, clicking links, or > > following > > > > guidance.** > > > > >>>> > > > > >>>> On 2023-11-14 14:28, Igor Kulchytskyy via groups.io wrote: > > > > >>>>> Filter out the network interfaces which are not supported by > > > > >>>>> Redfish Host Interface. > > > > >>>>> > > > > >>>>> Cc: Abner Chang > > > > >>>>> Cc: Nickle Wang > > > > >>>>> Signed-off-by: Igor Kulchytskyy > > > > >>>>> --- > > > > >>>>> RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > | > > 163 > > > > >>> ++++++++++++++------ > > > > >>>>> RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverInternal.h | > > 6 + > > > > >>>>> 2 files changed, 120 insertions(+), 49 deletions(-) > > > > >>>>> > > > > >>>>> diff --git > > a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > > > > >>> b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > > > > >>>>> index 0f622e05a9..ae83cd3c97 100644 > > > > >>>>> --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > > > > >>>>> +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > > > > >>>> > > > > >>>> > > > > >>>>> @@ -1601,10 +1681,22 @@ BuildupNetworkInterface ( > > > > >>>>> EFI_REDFISH_DISCOVER_REST_EX_INSTANCE_INTERNAL > > > > >>> *RestExInstance; > > > > >>>>> EFI_TPL > > OldTpl; > > > > >>>>> BOOLEAN > > NewNetworkInterfaceInstalled; > > > > >>>>> + UINT8 > IpType; > > > > >>>>> + UINTN > > ListCount; > > > > >>>>> > > > > >>>>> + ListCount =3D (sizeof > > (gRequiredProtocol) / sizeof > > > > >>> (REDFISH_DISCOVER_REQUIRED_PROTOCOL)); > > > > >>>>> NewNetworkInterfaceInstalled =3D FALSE; > > > > >>>>> Index =3D 0; > > > > >>>>> - do { > > > > >>>>> + > > > > >>>>> + // Get IP Type to filter out unnecessary network protocol > > if possible > > > > >>>>> + IpType =3D GetHiIpProtocolType (); > > > > >>>>> + > > > > >>>>> + for (Index =3D 0; Index < ListCount; Index++) { > > > > >>>>> + // Check IP Type and skip an unnecessary network > > protocol if does > > > > >> not > > > > >>> match > > > > >>>>> + if (IS_TCP4_MATCH (IpType) || IS_TCP6_MATCH (IpType)) { > > > > >>>> > > > > >>>> The logic of these macros is inverted compared to their > > names, though. > > > > >>>> > > > > >>>> You want this test to read > > > > >>>> if (!IS_TCP4_MATCH (IpType) && !IS_TCP6_MATCH (IpType)) { > > > > >>>> > > > > >>>>> + continue; > > > > >>>>> + } > > > > >>>>> + > > > > >>>>> Status =3D gBS->OpenProtocol ( > > > > >>>>> // Already in list? > > > > >>>>> ControllerHandle, > > > > >>>> > > > > >>>>> diff --git > > a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverInternal.h > > > > >>> b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverInternal.h > > > > >>>>> index 01454acc1d..3093eea0d5 100644 > > > > >>>>> --- > > a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverInternal.h > > > > >>>>> +++ > > b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverInternal.h > > > > >>>>> @@ -39,6 +39,12 @@ > > > > >>>>> #define REDFISH_DISCOVER_VERSION > > 0x00010000 > > > > >>>>> #define > EFI_REDFISH_DISCOVER_NETWORK_INTERFACE_TPL > > > > >> TPL_NOTIFY > > > > >>>>> > > > > >>>>> +#define MAC_COMPARE(ThisNetworkInterface, > > > > >> TargetNetworkInterface) > > > > >>> (CompareMem ((VOID *)&ThisNetworkInterface->MacAddress, > > > > >>> &TargetNetworkInterface->MacAddress, ThisNetworkInterface- > > > > >>>> HwAddressSize)) > > > > >>>>> +#define VALID_TCP6(TargetNetworkInterface, > > ThisNetworkInterface) > > > > >>> (TargetNetworkInterface->IsIpv6 && (ThisNetworkInterface- > > > > >>>> NetworkProtocolType =3D=3D ProtocolTypeTcp6)) > > > > >>>>> +#define VALID_TCP4(TargetNetworkInterface, > > ThisNetworkInterface) > > > > >>> (!TargetNetworkInterface->IsIpv6 && (ThisNetworkInterface- > > > > >>>> NetworkProtocolType =3D=3D ProtocolTypeTcp4)) > > > > >>>>> +#define IS_TCP4_MATCH(IpType) > > > > >>> ((gRequiredProtocol[Index].ProtocolType =3D=3D ProtocolTypeTcp4= ) > > && > > > > >> (IpType !=3D > > > > >>> REDFISH_HOST_INTERFACE_HOST_IP_ADDRESS_FORMAT_IP4)) > > > > >>>>> +#define IS_TCP6_MATCH(IpType) > > > > >>> ((gRequiredProtocol[Index].ProtocolType =3D=3D ProtocolTypeTcp6= ) > > && > > > > >> (IpType !=3D > > > > >>> REDFISH_HOST_INTERFACE_HOST_IP_ADDRESS_FORMAT_IP6)) > > > > >>>> > > > > >>>> And these macros to test for =3D=3D, not !=3D > > > > >>>> > > > > >>>> > > > > >>>> Igor: First version tested "=3D=3D", but we agreed that it may > > not work if we > > > > >> have > > > > >>> a wrong value of IpType. > > > > >>>> > > > > >>>> Otherwise the code reads like it does the opposite of what it > > does. > > > > >>>> > > > > >>>> (You could also keep the logic and call the macros > > IS_TCP#_MISMATCH, > > > > but > > > > >>>> that feels a bit convoluted.) > > > > >>>> > > > > >>>> Igor: I would prefer to go with IS_TCP#_MISMATCH names. > > > > >>>> > > > > >>>> Regards, > > > > >>>> > > > > >>>> Leif > > > > >>> > > > > >>> Sorry, could I add my 2 cents? > > > > >>> > > > > >>> For me all newly added defines looks bad, just because those > > > > >>> implicitly use reference to a global variable > > > > >>> plus local variable state (i.e current cycle index). > > > > >>> > > > > >>> Could we rewrite code in a simple and straight forward manner, > > similar > > > to: > > > > >>> > > > > >>> if (IpType =3D=3D > > > > >>> > REDFISH_HOST_INTERFACE_HOST_IP_ADDRESS_FORMAT_UNKNOWN) > > > { > > > > >>> // The protocol type is not specified in SMBIOS table type > > 42h > > > > >>> return EFI_UNSUPPORTED; > > > > >>> } > > > > >>> > > > > >>> for (Index =3D 0; Index < ListCount; Index++) { > > > > >>> if ((gRequiredProtocol[Index].ProtocolType =3D=3D > > ProtocolTypeTcp4) && > > > > >>> (IpType !=3D > > > > >> REDFISH_HOST_INTERFACE_HOST_IP_ADDRESS_FORMAT_IP4)) { > > > > >>> continue; > > > > >>> } > > > > >>> if ((gRequiredProtocol[Index].ProtocolType =3D=3D > > ProtocolTypeTcp6) && > > > > >>> (IpType !=3D > > > > >> REDFISH_HOST_INTERFACE_HOST_IP_ADDRESS_FORMAT_IP6)) { > > > > >>> continue; > > > > >>> } > > > > >>> > > > > >>> > > > > >>> Regards, > > > > >>> Mike. > > > > > > > > > > > > > > >=20 > > > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111295): https://edk2.groups.io/g/devel/message/111295 Mute This Topic: https://groups.io/mt/102618505/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-