From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.85]) by mx.groups.io with SMTP id smtpd.web09.656.1665003014275324251 for ; Wed, 05 Oct 2022 13:50:14 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=k4cve+y3; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.92.85, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SJ6vSyG4vylmg2vhVFYW5PW5VPppdIvXjSevW2UZyleKbTsla7Pi2/LXI9xtsYrom0/J+H6ExoHbfEk++nJWJDF0agAojhss0IlsK4fEhqGiChM53l3hpkW1r8aXZxh1klRZIjLTOXhbNbCwfTCj5FNzVXff8ANSeQBb1jp+Md/QdNOfCEKgoDjzlw+UzBpqfLEmrRqqorD+TiCH80k0+rDDANOtzBaaZLvh4RESeK3DV7Ug1vzdcRxAdZePSsNM4cyifkyOnn/gkOc+ENv3cvmtfkqVA9dfXqYtzpGPA6RrexRYDyrslDlZZJpH/tW6pLBSzeRV2ZLmjDMcAGSKQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gv7YsZb4OJ4qpXhk2txcIToUv8KUP88M3Y3EHQjwOFw=; b=SNnpTmmjnOXm5jCTM0bd8R8xZNBJRMUmLG61xUZp8FYk5M8Hv5DoA/6SlVp97RE2L1vUpH+qg8l003saphBvlaz2V5/AUFQCquGB9iGGhQmwzKhMXsD7+z5PEqXnUWwbJ43VYnNSELDbGL5rankw+ZhEB38bQaO2OLWLBke2MEia6I338YjpUN88wUcD2iWyl0WbY5jUWdmDiM0pa2vHVtByKlOrup/L/M++skp6HkBhDWeRmsGWOcUx4R3fmVjgicvDRVC2JB0loFaObX+gsg2Xbs5xkzHbWbwQ5y1kam9PeJvp8uQqHgI2iCJdyOCR7OzVeOpqOMJhTJ5YSy2SIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gv7YsZb4OJ4qpXhk2txcIToUv8KUP88M3Y3EHQjwOFw=; b=k4cve+y34vBEtrCCnFPWTNqS76jyNFVzgFLdkgXdVR3XPp9ejyG3jJxm0QG6o9MuGP9lMWgrGuBSd0qYU7FuxHV1zLzhHN/Bk4WiXz4oCLg9PkjhkFmR2pgfgztIHh8nCIvNzCROt9m2fwJ8YWbZYCvni6oCQ6xbeuNQrOuU8FI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) by CH3PR12MB7762.namprd12.prod.outlook.com (2603:10b6:610:151::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Wed, 5 Oct 2022 20:50:11 +0000 Received: from DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::c175:4c:c0d:1396]) by DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::c175:4c:c0d:1396%4]) with mapi id 15.20.5676.033; Wed, 5 Oct 2022 20:50:11 +0000 Message-ID: <027865f7-6d49-6f57-5db2-95fa5b51cc2d@amd.com> Date: Wed, 5 Oct 2022 15:50:09 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v7 3/7] MdeModulePkg: Notify BeforeExitBootServices in CoreExitBootServices To: Dionna Glaze , devel@edk2.groups.io Cc: Gerd Hoffmann , James Bottomley , Jiewen Yao , Ard Biesheuvel , "Min M. Xu" , Andrew Fish , "Michael D. Kinney" , Ray Ni References: <20221005203329.469866-1-dionnaglaze@google.com> <20221005203329.469866-4-dionnaglaze@google.com> From: "Lendacky, Thomas" In-Reply-To: <20221005203329.469866-4-dionnaglaze@google.com> X-ClientProxiedBy: MN2PR08CA0026.namprd08.prod.outlook.com (2603:10b6:208:239::31) To DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) Return-Path: Thomas.Lendacky@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB5229:EE_|CH3PR12MB7762:EE_ X-MS-Office365-Filtering-Correlation-Id: 1b8a6e50-8d17-48fd-95b1-08daa7133240 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +Yw1+lOhCK/97caRwAFZ2b8KYtu9VD5SWuUxrUjblNfm9yptgoSUxbsvC/G4gM0ipC+o3DpmyyWSLlr9WZXz8lBR2VHH3NZg+cfUKIUtRLUJq2eWm7OOMcEpNboPDp8r49U3Gkco+j4afWD1yNdMhfAqAd6RiaHhQGjSelNddGsYS+Esny1dR3/8mjFFPB/U3BAi5fiYscIr1DHTZAbhVwasArkyULBu+i7Gri6g44LFguqNwnM58PQBs7+qvX6fk1HTMZX+MAti3NfIfdvx+VwS638y2mY02vWsEF6ETNC0QmbEyT6n4o97H1XCLQM/dt/6x7VBwX6qkNaIW0gdkypsdKCI/ZEL5tYrNyguHkPhzd9Z82n3asqcfqtmyoxfcfBbsN/Nct3Cuxv7W+eN96xi0W4Qy2nVto3rBpA4nH+iwc5dTupgP8OI1yy6zpUW8gFV2rUqjgK+ikWzl9Unh5vR5jCDfdfKtmUwp2G/kr3h02TvwrUkdQndbC0jj/KebBR24biFdJl8PI/lrga7TPaFHpOf5IMGWvrJ0i76Z8+zyOpBRgq/+QQL+ieQyRgpPxF3QRozsAGZDThM2GkyDiT2ZBs8Z9J7DZUWHm0C4lFVxWC4ZjkIMRNJRISt8Cwqx4SKtIiaOu6gBvrMMmvI4wZE7MsMG3HpoyEds4jc5Rabl1JE/IGZHrCnYAYgl/uUqHqOfU9zfT9ulQO9DHPw1mWNRGundEK5gXxCFI2qg97sNviZxUyZEg6Rm9t0zS4YeKLaDpxp0vmLvKUxLrQs8sC+HwNtmr7ccyFX+J4mG2Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5229.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(366004)(136003)(396003)(39860400002)(451199015)(8676002)(54906003)(7416002)(66556008)(66946007)(38100700002)(6486002)(4326008)(478600001)(66476007)(19627235002)(53546011)(86362001)(41300700001)(2906002)(31696002)(5660300002)(26005)(36756003)(6512007)(6506007)(8936002)(83380400001)(31686004)(2616005)(66899015)(316002)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmcydDFlVWtyaDBhRDMvaW15UUh0MFl3QkFYOWY1UHZBT2FnSW16SmJoNlVv?= =?utf-8?B?TVpkcWhJUkhpRFBWZlNaNU5RZEdBL2pnT2daWGMyNWhIQXZDVGN2cXFqZ1V2?= =?utf-8?B?Z3poNmVQdWJDQU9zak5TTVdPVE4zcFRXTDRXT2J5aWMxeE1RRk5LUWkxTW9B?= =?utf-8?B?aHZ4UUY3ZGJUODZBMXFSbi83U2dhWTRPdXdlbk11K1JuelhlOVZ6djF3a3JH?= =?utf-8?B?S3NhUUF3UzNrQ3VMUzBlRXUxRmZPaHZNbHRBTjJLc3ExaldXZnhyRjJvSklm?= =?utf-8?B?YVM1REFRbzY2MkV6OGVteHh5eFJ1MXhadks3Z3EvQXY5R00vUzhzUE91NkFO?= =?utf-8?B?R3krRVhFcU1nWTFJeWFpRkxxYjJuWEJKQWtFR0tkMTU4TEd1MWIrZS84N3dY?= =?utf-8?B?b2NTcGlnY1lsWTgzaWJzOEdyZnd2OEx6TnhMSStSdlZjMFZjSHZWYXBneTRw?= =?utf-8?B?Q2VPancrQjlLdGk1RUdxZHRId1N2TFJWVmhKTWQxbmlSaTVGeS84R2RXTEYz?= =?utf-8?B?RU9IcTNTaUdSRTRPT0hYR2hMMkoyMDBHT21HUit3S2lWdDBGYkZSR2hjb0gx?= =?utf-8?B?ZUdvejd1UXFjL0hjS09vZFp4TC8yU3ZwVmZzYVh1SmExSXVBUk5oN1BUZFZm?= =?utf-8?B?b1dvRW9HcHMyWmxpcFBUelVOVUdoNjhHaFRrczVyeGxJaVFhM1d2cUtrQlVu?= =?utf-8?B?NzhuVEdseFVVMDJMd050MXdQV2lDTHFFeTltNnJaTU1PdjB0aHJWVXRmcVBy?= =?utf-8?B?bXFJSWREenpDbjhFcThaQUhTaGR4L0s2VnBHK1pVVTFuREpKTXp1Z1VhOEpk?= =?utf-8?B?TGJzaFhKMFdFUmNhY0paNW43eXNwemJ1Q2Y1YXBSK1JaelFFbkpPNGx1eU54?= =?utf-8?B?TU1BbWI0bEZaSjFGQlhpOG5sdTlBdVlDTkwwRG5EdkpwdWI0OEZIU21kQ1V6?= =?utf-8?B?WGcrYmRGRnBoQTQyZFdBUGo2TVFjbDZyRituVXRoYyt2cXkxMGNldTA5KzZm?= =?utf-8?B?aE9QblZvYUZUZStzOEZLbjZFbWRPbjFPRTM5T1AwRFlBZmdrSjNXeGI3UWpV?= =?utf-8?B?V2hRWk9FcGlUVmhxRlYvNGhOU0FIMzdITytYVjc3cXFEY3NCU0dzbVNjQlJj?= =?utf-8?B?YWNLRzhtVnJoVVhEZTFyUmFVMTdxY2F5YlhYVUErMFZsdzF3UnJydzlxdi82?= =?utf-8?B?SlFBUjUvMDdwY0l6a3ExV2kzWit1bHR5cHdPdWROaW11UTZicmNiOGFidlpU?= =?utf-8?B?S3JBTWJLRnR4WHYzOW9rMzFpK2NVV1pKL2NsU0xpd2VjL2oyUG1VRGpZZGd6?= =?utf-8?B?K3lsM2kyR1REVVN1aFFOVTF0VGtJL3h5SWI1bnlKTmRnOGRiVkhaWEk5M0Jq?= =?utf-8?B?RnFESGdZVUZmK1ZsOGhjT3pPWnVZWUYyRzh6VlR2Z01vaGVldHI3a0NwUzVN?= =?utf-8?B?OXJrSktVZzdQQlQrT1ZhS0RUWHJzQ1JCN3hRNk5sejJVSmtDVkdmRW9PSUJl?= =?utf-8?B?Vi80WmEvZksvbFJ2aUVJR1J4RFhhc2RiZW9oK05JdlpmR2lLTjdKTUpCcHFt?= =?utf-8?B?c1hUSTlJS2pkM2dRMm4yYlZjNTdwY1M1eU8xaVR5TkR0dEF2bm1JNTlRWXlk?= =?utf-8?B?aHdOamxteko5S2xqVDJtNDVJbTFnL0JhYkNqSkcwcjNld2NDZmpKRkFTUjhm?= =?utf-8?B?Q1ZpeTBXVG5DYmxWaWRmNXVIMW1uOVhoV1hIamx0OUdoeXBXQktSNnVISzBO?= =?utf-8?B?WDIydkQ5SWwxQmdBNDdKS0gxTFZOdWttbVR5UzAyNjNYWmg4M1VWNGt4QkVa?= =?utf-8?B?eHNNekJOK0VvcndZUXNKcWE4M2w3RVIzUnZTKzFUR1N5Yk9XLzJqcGltTitG?= =?utf-8?B?Q3UzcDZUcEI2d3FhVUczRjBwSWVlOUxqQmM0SDV3MDRzZEp3M0NTNzNsTVVv?= =?utf-8?B?MXRhWHNwTzVIdWRKbEhPU3BFS3pvVDVDZ0lmc2lVRFpMQVlRVFFCYXM4cHBi?= =?utf-8?B?MHpjZUNHQ2hycE5uR2x0cngyeDJWb1hYa25rZnN6UVVRQWFwbkJQd3dhR0Vk?= =?utf-8?B?aVRTb1ZBS1YwVGY1QU5sMFF1b3JPdzVWclNRZ2QvNzFtOVZZTWFZTE1VK28x?= =?utf-8?Q?xOGuoYFXIXZcfaQT2bcRGw+kd?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b8a6e50-8d17-48fd-95b1-08daa7133240 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2022 20:50:11.7218 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oeIQrRkxwGPr+eQVQGWA8cfpFYq+3cNNVJsiZ6AoazaAxw1XcagH3Uvql8T+QspevAB7dHkzwfPTWrK+DdFi0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7762 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/5/22 15:33, Dionna Glaze wrote: > Location of notification is has been specified in UEFI v2.9. > > Cc: Gerd Hoffmann > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Tom Lendacky > Cc: Ard Biesheuvel > Cc: "Min M. Xu" > Cc: Andrew Fish > Cc: "Michael D. Kinney" > Cc: Ray Ni > > Signed-off-by: Dionna Glaze > --- > MdeModulePkg/Core/Dxe/DxeMain.inf | 1 + > MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c | 6 ++++++ > 2 files changed, 7 insertions(+) > > diff --git a/MdeModulePkg/Core/Dxe/DxeMain.inf b/MdeModulePkg/Core/Dxe/DxeMain.inf > index e4bca89577..35d5bf0dee 100644 > --- a/MdeModulePkg/Core/Dxe/DxeMain.inf > +++ b/MdeModulePkg/Core/Dxe/DxeMain.inf > @@ -100,6 +100,7 @@ > gEfiEventVirtualAddressChangeGuid ## CONSUMES ## Event > ## CONSUMES ## Event > ## PRODUCES ## Event > + gEfiEventBeforeExitBootServicesGuid > gEfiEventExitBootServicesGuid > gEfiHobMemoryAllocModuleGuid ## SOMETIMES_CONSUMES ## HOB > gEfiFirmwareFileSystem2Guid ## CONSUMES ## GUID # Used to compare with FV's file system guid and get the FV's file system format > diff --git a/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c b/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c > index 5733f0c8ec..4683016ed7 100644 > --- a/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c > +++ b/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c > @@ -763,6 +763,12 @@ CoreExitBootServices ( > { > EFI_STATUS Status; > > + // > + // Notify other drivers of their last chance to use boot services > + // before the memory map is terminated. > + // > + CoreNotifySignalList (&gEfiEventBeforeExitBootServicesGuid); Isn't this supposed to be after disabling the timer? Thanks, Tom > + > // > // Disable Timer > //