From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 891D074003A for ; Tue, 13 Feb 2024 11:57:54 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=vLlNHreAzbMjHvyp7Ca8S1am00M+qTRYAU1AGtvRoh8=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:CC:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1707825473; v=1; b=FVTkFTZhewr3HFd9uh7GL9J0PgPZNCgFnWpvPfIFBmoRmZAzknTmVlVw95OpljuWpS1gVtFW cEtp+UmzRlh+cpjBmJNkSEeKUPQli5nt/Px2PK2mqVAtQOsGi9nandJyJJMdBBaUNfKYZ1dSqqn fC0V4vFr82aGcXG0yhL3Msto= X-Received: by 127.0.0.2 with SMTP id Ag85YY7687511xxky7oHQ9tS; Tue, 13 Feb 2024 03:57:53 -0800 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web10.9773.1707825472241853148 for ; Tue, 13 Feb 2024 03:57:52 -0800 X-Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41D5dbNk015764; Tue, 13 Feb 2024 11:57:48 GMT X-Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3w7ww5s236-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Feb 2024 11:57:47 +0000 (GMT) X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 41DBvid0005777 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Feb 2024 11:57:44 GMT X-Received: from [10.111.132.144] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Tue, 13 Feb 2024 03:57:43 -0800 Message-ID: <027c65be-3aa0-4e0a-806f-b58703d54003@quicinc.com> Date: Tue, 13 Feb 2024 11:57:41 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [edk2-stable202402][Patch V3 1/7] MdePkg/Include: Rename _DEBUG() to address name collision To: , CC: Liming Gao , Zhiguang Liu References: <20240209203253.488-1-michael.d.kinney@intel.com> <20240209203253.488-2-michael.d.kinney@intel.com> From: "Leif Lindholm" In-Reply-To: <20240209203253.488-2-michael.d.kinney@intel.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: hS8A-d-c0M5_MdC4B8DB6qrT-R8rSqJf X-Proofpoint-ORIG-GUID: hS8A-d-c0M5_MdC4B8DB6qrT-R8rSqJf Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 8gtaqAmKckT1CTDfCmh4fA8hx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=FVTkFTZh; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 2024-02-09 20:32, Michael D Kinney wrote: > When VS20xx host-based unit tests are built with debug > libraries a name collision occurs with the DebubLib.h Typo: DebubLib.h -> DebugLib.h With that fixed: Reviewed-by: Leif Lindholm > internal macro _DEBUG(). Rename this internal macro > to _DEBUGLIB_DEBUG() to address the name collision. >=20 > Cc: Liming Gao > Cc: Zhiguang Liu > Signed-off-by: Michael D Kinney > --- > MdePkg/Include/Library/DebugLib.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/MdePkg/Include/Library/DebugLib.h b/MdePkg/Include/Library/D= ebugLib.h > index 40772f2e0f7b..0db3b78ec86d 100644 > --- a/MdePkg/Include/Library/DebugLib.h > +++ b/MdePkg/Include/Library/DebugLib.h > @@ -375,9 +375,9 @@ UnitTestDebugAssert ( > DebugPrint (PrintLevel, ##__VA_ARGS__); \ > } \ > } while (FALSE) > -#define _DEBUG(Expression) _DEBUG_PRINT Expression > +#define _DEBUGLIB_DEBUG(Expression) _DEBUG_PRINT Expression > #else > -#define _DEBUG(Expression) DebugPrint Expression > +#define _DEBUGLIB_DEBUG(Expression) DebugPrint Expression > #endif > =20 > /** > @@ -422,7 +422,7 @@ UnitTestDebugAssert ( > #define DEBUG(Expression) \ > do { \ > if (DebugPrintEnabled ()) { \ > - _DEBUG (Expression); \ > + _DEBUGLIB_DEBUG (Expression); \ > } \ > } while (FALSE) > #else -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115382): https://edk2.groups.io/g/devel/message/115382 Mute This Topic: https://groups.io/mt/104267256/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-