public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-devel] [PATCH 1/2] MdeModulePkg: Dxe: add LOONGARCH64 to mMachineTypeInfo
@ 2024-01-16  7:11 Dongyan Qian
  2024-01-16  7:11 ` [edk2-devel] [PATCH 2/2] ShellPkg: Update smbiosview for LoongArch Dongyan Qian
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Dongyan Qian @ 2024-01-16  7:11 UTC (permalink / raw)
  To: devel; +Cc: Liming Gao, Chao Li

This fixes messages like:
"Image type X64 can't be loaded on <Unknown> UEFI system"

Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Chao Li <lichao@loongson.cn>
Signed-off-by: Dongyan Qian <qiandongyan@loongson.cn>
---
 MdeModulePkg/Core/Dxe/Image/Image.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/MdeModulePkg/Core/Dxe/Image/Image.c b/MdeModulePkg/Core/Dxe/Image/Image.c
index 6bc3a549ae..66d9840b7b 100644
--- a/MdeModulePkg/Core/Dxe/Image/Image.c
+++ b/MdeModulePkg/Core/Dxe/Image/Image.c
@@ -77,12 +77,13 @@ typedef struct {
 } MACHINE_TYPE_INFO;
 
 GLOBAL_REMOVE_IF_UNREFERENCED MACHINE_TYPE_INFO  mMachineTypeInfo[] = {
-  { EFI_IMAGE_MACHINE_IA32,           L"IA32"    },
-  { EFI_IMAGE_MACHINE_IA64,           L"IA64"    },
-  { EFI_IMAGE_MACHINE_X64,            L"X64"     },
-  { EFI_IMAGE_MACHINE_ARMTHUMB_MIXED, L"ARM"     },
-  { EFI_IMAGE_MACHINE_AARCH64,        L"AARCH64" },
-  { EFI_IMAGE_MACHINE_RISCV64,        L"RISCV64" },
+  { EFI_IMAGE_MACHINE_IA32,           L"IA32"        },
+  { EFI_IMAGE_MACHINE_IA64,           L"IA64"        },
+  { EFI_IMAGE_MACHINE_X64,            L"X64"         },
+  { EFI_IMAGE_MACHINE_ARMTHUMB_MIXED, L"ARM"         },
+  { EFI_IMAGE_MACHINE_AARCH64,        L"AARCH64"     },
+  { EFI_IMAGE_MACHINE_RISCV64,        L"RISCV64"     },
+  { EFI_IMAGE_MACHINE_LOONGARCH64,    L"LOONGARCH64" },
 };
 
 UINT16  mDxeCoreImageMachineType = 0;
-- 
2.27.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113870): https://edk2.groups.io/g/devel/message/113870
Mute This Topic: https://groups.io/mt/103757732/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [edk2-devel] [PATCH 2/2] ShellPkg: Update smbiosview for LoongArch
  2024-01-16  7:11 [edk2-devel] [PATCH 1/2] MdeModulePkg: Dxe: add LOONGARCH64 to mMachineTypeInfo Dongyan Qian
@ 2024-01-16  7:11 ` Dongyan Qian
  2024-01-16 12:12   ` Chao Li
  2024-01-16 12:11 ` [edk2-devel] [PATCH 1/2] MdeModulePkg: Dxe: add LOONGARCH64 to mMachineTypeInfo Chao Li
  2024-01-31  9:56 ` 回复: " gaoliming via groups.io
  2 siblings, 1 reply; 7+ messages in thread
From: Dongyan Qian @ 2024-01-16  7:11 UTC (permalink / raw)
  To: devel; +Cc: Zhichao Gao, Chao Li

According to SMBIOS spec3.6, LoongArch information support has been added,
so this patch is submitted for display as information in smbiosview.

Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Chao Li <lichao@loongson.cn>
Signed-off-by: Dongyan Qian <qiandongyan@loongson.cn>
---
 .../SmbiosView/PrintInfo.c                    | 68 +++++++++++++++++++
 .../SmbiosView/QueryTable.c                   |  8 +++
 2 files changed, 76 insertions(+)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
index b6968cb36a..ba6e7b15fc 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
@@ -2610,6 +2610,74 @@ DisplayProcessorFamily2 (
       Print (L"RISC-V RV128\n");
       break;
 
+    case 0x258:
+      Print (L"LoongArch\n");
+      break;
+
+    case 0x259:
+      Print (L"Loongson1\n");
+      break;
+
+    case 0x25a:
+      Print (L"Loongson2\n");
+      break;
+
+    case 0x25b:
+      Print (L"Loongson3\n");
+      break;
+
+    case 0x25c:
+      Print (L"Loongson2K\n");
+      break;
+
+    case 0x25d:
+      Print (L"Loongson3A\n");
+      break;
+
+    case 0x25e:
+      Print (L"Loongson3B\n");
+      break;
+
+    case 0x25f:
+      Print (L"Loongson3C\n");
+      break;
+
+    case 0x260:
+      Print (L"Loongson3D\n");
+      break;
+
+    case 0x261:
+      Print (L"Loongson3E\n");
+      break;
+
+    case 0x262:
+      Print (L"DualCoreLoongson2K\n");
+      break;
+
+    case 0x26C:
+      Print (L"QuadCoreLoongson3A\n");
+      break;
+
+    case 0x26D:
+      Print (L"MultiCoreLoongson3A\n");
+      break;
+
+    case 0x26E:
+      Print (L"QuadCoreLoongson3B\n");
+      break;
+
+    case 0x26F:
+      Print (L"MultiCoreLoongson3B\n");
+      break;
+
+    case 0x270:
+      Print (L"MultiCoreLoongson3C\n");
+      break;
+
+    case 0x271:
+      Print (L"MultiCoreLoongson3D\n");
+      break;
+
     default:
       ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_SMBIOSVIEW_PRINTINFO_UNDEFINED_PROC_FAMILY), gShellDebug1HiiHandle);
   }
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
index 82bb7a41f0..f57093c91c 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
@@ -3652,6 +3652,14 @@ TABLE_ITEM  ProcessorArchitectureTypesTable[] = {
   {
     8,
     L" 128-bit RISC-V (RV128) "
+  },
+  {
+    9,
+    L" 32-bit LoongArch (LoongArch32) "
+  },
+  {
+    10,
+    L" 64-bit LoongArch (LoongArch64) "
   }
 };
 
-- 
2.27.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113871): https://edk2.groups.io/g/devel/message/113871
Mute This Topic: https://groups.io/mt/103757733/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [edk2-devel] [PATCH 1/2] MdeModulePkg: Dxe: add LOONGARCH64 to mMachineTypeInfo
  2024-01-16  7:11 [edk2-devel] [PATCH 1/2] MdeModulePkg: Dxe: add LOONGARCH64 to mMachineTypeInfo Dongyan Qian
  2024-01-16  7:11 ` [edk2-devel] [PATCH 2/2] ShellPkg: Update smbiosview for LoongArch Dongyan Qian
@ 2024-01-16 12:11 ` Chao Li
  2024-01-31  7:00   ` Dongyan Qian
  2024-01-31  9:56 ` 回复: " gaoliming via groups.io
  2 siblings, 1 reply; 7+ messages in thread
From: Chao Li @ 2024-01-16 12:11 UTC (permalink / raw)
  To: devel, qiandongyan; +Cc: Liming Gao

[-- Attachment #1: Type: text/plain, Size: 2070 bytes --]

Looks good to me.

Reviewed-by: Chao Li <lichao@loongson.cn>

Hi Liming,

Please help review this patch.


Thanks,
Chao
On 2024/1/16 15:11, Dongyan Qian wrote:
> This fixes messages like:
> "Image type X64 can't be loaded on <Unknown> UEFI system"
>
> Cc: Liming Gao<gaoliming@byosoft.com.cn>
> Cc: Chao Li<lichao@loongson.cn>
> Signed-off-by: Dongyan Qian<qiandongyan@loongson.cn>
> ---
>   MdeModulePkg/Core/Dxe/Image/Image.c | 13 +++++++------
>   1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/MdeModulePkg/Core/Dxe/Image/Image.c b/MdeModulePkg/Core/Dxe/Image/Image.c
> index 6bc3a549ae..66d9840b7b 100644
> --- a/MdeModulePkg/Core/Dxe/Image/Image.c
> +++ b/MdeModulePkg/Core/Dxe/Image/Image.c
> @@ -77,12 +77,13 @@ typedef struct {
>   } MACHINE_TYPE_INFO;
>   
>   GLOBAL_REMOVE_IF_UNREFERENCED MACHINE_TYPE_INFO  mMachineTypeInfo[] = {
> -  { EFI_IMAGE_MACHINE_IA32,           L"IA32"    },
> -  { EFI_IMAGE_MACHINE_IA64,           L"IA64"    },
> -  { EFI_IMAGE_MACHINE_X64,            L"X64"     },
> -  { EFI_IMAGE_MACHINE_ARMTHUMB_MIXED, L"ARM"     },
> -  { EFI_IMAGE_MACHINE_AARCH64,        L"AARCH64" },
> -  { EFI_IMAGE_MACHINE_RISCV64,        L"RISCV64" },
> +  { EFI_IMAGE_MACHINE_IA32,           L"IA32"        },
> +  { EFI_IMAGE_MACHINE_IA64,           L"IA64"        },
> +  { EFI_IMAGE_MACHINE_X64,            L"X64"         },
> +  { EFI_IMAGE_MACHINE_ARMTHUMB_MIXED, L"ARM"         },
> +  { EFI_IMAGE_MACHINE_AARCH64,        L"AARCH64"     },
> +  { EFI_IMAGE_MACHINE_RISCV64,        L"RISCV64"     },
> +  { EFI_IMAGE_MACHINE_LOONGARCH64,    L"LOONGARCH64" },
>   };
>   
>   UINT16  mDxeCoreImageMachineType = 0;


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113890): https://edk2.groups.io/g/devel/message/113890
Mute This Topic: https://groups.io/mt/103757732/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 3510 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [edk2-devel] [PATCH 2/2] ShellPkg: Update smbiosview for LoongArch
  2024-01-16  7:11 ` [edk2-devel] [PATCH 2/2] ShellPkg: Update smbiosview for LoongArch Dongyan Qian
@ 2024-01-16 12:12   ` Chao Li
  2024-01-22  1:34     ` Gao, Zhichao
  0 siblings, 1 reply; 7+ messages in thread
From: Chao Li @ 2024-01-16 12:12 UTC (permalink / raw)
  To: devel, qiandongyan; +Cc: Zhichao Gao

[-- Attachment #1: Type: text/plain, Size: 3637 bytes --]

Looks good to me.

Reviewed-by: Chao Li <lichao@loongson.cn>

Hi Zhichao,

Please help review this patch.


Thanks,
Chao
On 2024/1/16 15:11, Dongyan Qian wrote:
> According to SMBIOS spec3.6, LoongArch information support has been added,
> so this patch is submitted for display as information in smbiosview.
>
> Cc: Zhichao Gao<zhichao.gao@intel.com>
> Cc: Chao Li<lichao@loongson.cn>
> Signed-off-by: Dongyan Qian<qiandongyan@loongson.cn>
> ---
>   .../SmbiosView/PrintInfo.c                    | 68 +++++++++++++++++++
>   .../SmbiosView/QueryTable.c                   |  8 +++
>   2 files changed, 76 insertions(+)
>
> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> index b6968cb36a..ba6e7b15fc 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> @@ -2610,6 +2610,74 @@ DisplayProcessorFamily2 (
>         Print (L"RISC-V RV128\n");
>         break;
>   
> +    case 0x258:
> +      Print (L"LoongArch\n");
> +      break;
> +
> +    case 0x259:
> +      Print (L"Loongson1\n");
> +      break;
> +
> +    case 0x25a:
> +      Print (L"Loongson2\n");
> +      break;
> +
> +    case 0x25b:
> +      Print (L"Loongson3\n");
> +      break;
> +
> +    case 0x25c:
> +      Print (L"Loongson2K\n");
> +      break;
> +
> +    case 0x25d:
> +      Print (L"Loongson3A\n");
> +      break;
> +
> +    case 0x25e:
> +      Print (L"Loongson3B\n");
> +      break;
> +
> +    case 0x25f:
> +      Print (L"Loongson3C\n");
> +      break;
> +
> +    case 0x260:
> +      Print (L"Loongson3D\n");
> +      break;
> +
> +    case 0x261:
> +      Print (L"Loongson3E\n");
> +      break;
> +
> +    case 0x262:
> +      Print (L"DualCoreLoongson2K\n");
> +      break;
> +
> +    case 0x26C:
> +      Print (L"QuadCoreLoongson3A\n");
> +      break;
> +
> +    case 0x26D:
> +      Print (L"MultiCoreLoongson3A\n");
> +      break;
> +
> +    case 0x26E:
> +      Print (L"QuadCoreLoongson3B\n");
> +      break;
> +
> +    case 0x26F:
> +      Print (L"MultiCoreLoongson3B\n");
> +      break;
> +
> +    case 0x270:
> +      Print (L"MultiCoreLoongson3C\n");
> +      break;
> +
> +    case 0x271:
> +      Print (L"MultiCoreLoongson3D\n");
> +      break;
> +
>       default:
>         ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_SMBIOSVIEW_PRINTINFO_UNDEFINED_PROC_FAMILY), gShellDebug1HiiHandle);
>     }
> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
> index 82bb7a41f0..f57093c91c 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
> @@ -3652,6 +3652,14 @@ TABLE_ITEM  ProcessorArchitectureTypesTable[] = {
>     {
>       8,
>       L" 128-bit RISC-V (RV128) "
> +  },
> +  {
> +    9,
> +    L" 32-bit LoongArch (LoongArch32) "
> +  },
> +  {
> +    10,
> +    L" 64-bit LoongArch (LoongArch64) "
>     }
>   };
>   


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113891): https://edk2.groups.io/g/devel/message/113891
Mute This Topic: https://groups.io/mt/103757733/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 4924 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [edk2-devel] [PATCH 2/2] ShellPkg: Update smbiosview for LoongArch
  2024-01-16 12:12   ` Chao Li
@ 2024-01-22  1:34     ` Gao, Zhichao
  0 siblings, 0 replies; 7+ messages in thread
From: Gao, Zhichao @ 2024-01-22  1:34 UTC (permalink / raw)
  To: devel@edk2.groups.io, lichao@loongson.cn, qiandongyan@loongson.cn

[-- Attachment #1: Type: text/plain, Size: 4123 bytes --]

Reviewed-by: Zhichao Gao zhichao.gao@intel.com<mailto:zhichao.gao@intel.com>

Thanks,
Zhichao

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chao Li
Sent: Tuesday, January 16, 2024 8:13 PM
To: devel@edk2.groups.io; qiandongyan@loongson.cn
Cc: Gao, Zhichao <zhichao.gao@intel.com>
Subject: Re: [edk2-devel] [PATCH 2/2] ShellPkg: Update smbiosview for LoongArch


Looks good to me.

Reviewed-by: Chao Li <lichao@loongson.cn><mailto:lichao@loongson.cn>

Hi Zhichao,

Please help review this patch.

Thanks,
Chao
On 2024/1/16 15:11, Dongyan Qian wrote:

According to SMBIOS spec3.6, LoongArch information support has been added,

so this patch is submitted for display as information in smbiosview.



Cc: Zhichao Gao <zhichao.gao@intel.com><mailto:zhichao.gao@intel.com>

Cc: Chao Li <lichao@loongson.cn><mailto:lichao@loongson.cn>

Signed-off-by: Dongyan Qian <qiandongyan@loongson.cn><mailto:qiandongyan@loongson.cn>

---

 .../SmbiosView/PrintInfo.c                    | 68 +++++++++++++++++++

 .../SmbiosView/QueryTable.c                   |  8 +++

 2 files changed, 76 insertions(+)



diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c

index b6968cb36a..ba6e7b15fc 100644

--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c

+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c

@@ -2610,6 +2610,74 @@ DisplayProcessorFamily2 (

       Print (L"RISC-V RV128\n");

       break;



+    case 0x258:

+      Print (L"LoongArch\n");

+      break;

+

+    case 0x259:

+      Print (L"Loongson1\n");

+      break;

+

+    case 0x25a:

+      Print (L"Loongson2\n");

+      break;

+

+    case 0x25b:

+      Print (L"Loongson3\n");

+      break;

+

+    case 0x25c:

+      Print (L"Loongson2K\n");

+      break;

+

+    case 0x25d:

+      Print (L"Loongson3A\n");

+      break;

+

+    case 0x25e:

+      Print (L"Loongson3B\n");

+      break;

+

+    case 0x25f:

+      Print (L"Loongson3C\n");

+      break;

+

+    case 0x260:

+      Print (L"Loongson3D\n");

+      break;

+

+    case 0x261:

+      Print (L"Loongson3E\n");

+      break;

+

+    case 0x262:

+      Print (L"DualCoreLoongson2K\n");

+      break;

+

+    case 0x26C:

+      Print (L"QuadCoreLoongson3A\n");

+      break;

+

+    case 0x26D:

+      Print (L"MultiCoreLoongson3A\n");

+      break;

+

+    case 0x26E:

+      Print (L"QuadCoreLoongson3B\n");

+      break;

+

+    case 0x26F:

+      Print (L"MultiCoreLoongson3B\n");

+      break;

+

+    case 0x270:

+      Print (L"MultiCoreLoongson3C\n");

+      break;

+

+    case 0x271:

+      Print (L"MultiCoreLoongson3D\n");

+      break;

+

     default:

       ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_SMBIOSVIEW_PRINTINFO_UNDEFINED_PROC_FAMILY), gShellDebug1HiiHandle);

   }

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c

index 82bb7a41f0..f57093c91c 100644

--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c

+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c

@@ -3652,6 +3652,14 @@ TABLE_ITEM  ProcessorArchitectureTypesTable[] = {

   {

     8,

     L" 128-bit RISC-V (RV128) "

+  },

+  {

+    9,

+    L" 32-bit LoongArch (LoongArch32) "

+  },

+  {

+    10,

+    L" 64-bit LoongArch (LoongArch64) "

   }

 };





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114127): https://edk2.groups.io/g/devel/message/114127
Mute This Topic: https://groups.io/mt/103757733/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 11754 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [edk2-devel] [PATCH 1/2] MdeModulePkg: Dxe: add LOONGARCH64 to mMachineTypeInfo
  2024-01-16 12:11 ` [edk2-devel] [PATCH 1/2] MdeModulePkg: Dxe: add LOONGARCH64 to mMachineTypeInfo Chao Li
@ 2024-01-31  7:00   ` Dongyan Qian
  0 siblings, 0 replies; 7+ messages in thread
From: Dongyan Qian @ 2024-01-31  7:00 UTC (permalink / raw)
  To: devel, Liming Gao; +Cc: lichao

[-- Attachment #1: Type: text/plain, Size: 2390 bytes --]

Hi Liming,

Please can you give me a review?

Thanks
Dongyan

> 2024年1月16日 20:11,Chao Li <lichao@loongson.cn> 写道:
> 
> Looks good to me.
> 
> Reviewed-by: Chao Li <lichao@loongson.cn> <mailto:lichao@loongson.cn>
> Hi Liming,
> 
> Please help review this patch.
> 
> 
> Thanks,
> Chao
> On 2024/1/16 15:11, Dongyan Qian wrote:
>> This fixes messages like:
>> "Image type X64 can't be loaded on <Unknown> UEFI system"
>> 
>> Cc: Liming Gao <gaoliming@byosoft.com.cn> <mailto:gaoliming@byosoft.com.cn>
>> Cc: Chao Li <lichao@loongson.cn> <mailto:lichao@loongson.cn>
>> Signed-off-by: Dongyan Qian <qiandongyan@loongson.cn> <mailto:qiandongyan@loongson.cn>
>> ---
>>  MdeModulePkg/Core/Dxe/Image/Image.c | 13 +++++++------
>>  1 file changed, 7 insertions(+), 6 deletions(-)
>> 
>> diff --git a/MdeModulePkg/Core/Dxe/Image/Image.c b/MdeModulePkg/Core/Dxe/Image/Image.c
>> index 6bc3a549ae..66d9840b7b 100644
>> --- a/MdeModulePkg/Core/Dxe/Image/Image.c
>> +++ b/MdeModulePkg/Core/Dxe/Image/Image.c
>> @@ -77,12 +77,13 @@ typedef struct {
>>  } MACHINE_TYPE_INFO;
>>  
>>  GLOBAL_REMOVE_IF_UNREFERENCED MACHINE_TYPE_INFO  mMachineTypeInfo[] = {
>> -  { EFI_IMAGE_MACHINE_IA32,           L"IA32"    },
>> -  { EFI_IMAGE_MACHINE_IA64,           L"IA64"    },
>> -  { EFI_IMAGE_MACHINE_X64,            L"X64"     },
>> -  { EFI_IMAGE_MACHINE_ARMTHUMB_MIXED, L"ARM"     },
>> -  { EFI_IMAGE_MACHINE_AARCH64,        L"AARCH64" },
>> -  { EFI_IMAGE_MACHINE_RISCV64,        L"RISCV64" },
>> +  { EFI_IMAGE_MACHINE_IA32,           L"IA32"        },
>> +  { EFI_IMAGE_MACHINE_IA64,           L"IA64"        },
>> +  { EFI_IMAGE_MACHINE_X64,            L"X64"         },
>> +  { EFI_IMAGE_MACHINE_ARMTHUMB_MIXED, L"ARM"         },
>> +  { EFI_IMAGE_MACHINE_AARCH64,        L"AARCH64"     },
>> +  { EFI_IMAGE_MACHINE_RISCV64,        L"RISCV64"     },
>> +  { EFI_IMAGE_MACHINE_LOONGARCH64,    L"LOONGARCH64" },
>>  };
>>  
>>  UINT16  mDxeCoreImageMachineType = 0;
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114865): https://edk2.groups.io/g/devel/message/114865
Mute This Topic: https://groups.io/mt/103757732/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 4270 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* 回复: [edk2-devel] [PATCH 1/2] MdeModulePkg: Dxe: add LOONGARCH64 to mMachineTypeInfo
  2024-01-16  7:11 [edk2-devel] [PATCH 1/2] MdeModulePkg: Dxe: add LOONGARCH64 to mMachineTypeInfo Dongyan Qian
  2024-01-16  7:11 ` [edk2-devel] [PATCH 2/2] ShellPkg: Update smbiosview for LoongArch Dongyan Qian
  2024-01-16 12:11 ` [edk2-devel] [PATCH 1/2] MdeModulePkg: Dxe: add LOONGARCH64 to mMachineTypeInfo Chao Li
@ 2024-01-31  9:56 ` gaoliming via groups.io
  2 siblings, 0 replies; 7+ messages in thread
From: gaoliming via groups.io @ 2024-01-31  9:56 UTC (permalink / raw)
  To: devel, qiandongyan; +Cc: 'Chao Li'

This change is good. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Dongyan
> Qian
> 发送时间: 2024年1月16日 15:12
> 收件人: devel@edk2.groups.io
> 抄送: Liming Gao <gaoliming@byosoft.com.cn>; Chao Li
> <lichao@loongson.cn>
> 主题: [edk2-devel] [PATCH 1/2] MdeModulePkg: Dxe: add LOONGARCH64 to
> mMachineTypeInfo
> 
> This fixes messages like:
> "Image type X64 can't be loaded on <Unknown> UEFI system"
> 
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Chao Li <lichao@loongson.cn>
> Signed-off-by: Dongyan Qian <qiandongyan@loongson.cn>
> ---
>  MdeModulePkg/Core/Dxe/Image/Image.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/MdeModulePkg/Core/Dxe/Image/Image.c
> b/MdeModulePkg/Core/Dxe/Image/Image.c
> index 6bc3a549ae..66d9840b7b 100644
> --- a/MdeModulePkg/Core/Dxe/Image/Image.c
> +++ b/MdeModulePkg/Core/Dxe/Image/Image.c
> @@ -77,12 +77,13 @@ typedef struct {
>  } MACHINE_TYPE_INFO;
> 
>  GLOBAL_REMOVE_IF_UNREFERENCED MACHINE_TYPE_INFO
> mMachineTypeInfo[] = {
> -  { EFI_IMAGE_MACHINE_IA32,           L"IA32"    },
> -  { EFI_IMAGE_MACHINE_IA64,           L"IA64"    },
> -  { EFI_IMAGE_MACHINE_X64,            L"X64"     },
> -  { EFI_IMAGE_MACHINE_ARMTHUMB_MIXED, L"ARM"     },
> -  { EFI_IMAGE_MACHINE_AARCH64,        L"AARCH64" },
> -  { EFI_IMAGE_MACHINE_RISCV64,        L"RISCV64" },
> +  { EFI_IMAGE_MACHINE_IA32,           L"IA32"        },
> +  { EFI_IMAGE_MACHINE_IA64,           L"IA64"        },
> +  { EFI_IMAGE_MACHINE_X64,            L"X64"         },
> +  { EFI_IMAGE_MACHINE_ARMTHUMB_MIXED, L"ARM"         },
> +  { EFI_IMAGE_MACHINE_AARCH64,        L"AARCH64"     },
> +  { EFI_IMAGE_MACHINE_RISCV64,        L"RISCV64"     },
> +  { EFI_IMAGE_MACHINE_LOONGARCH64,    L"LOONGARCH64" },
>  };
> 
>  UINT16  mDxeCoreImageMachineType = 0;
> --
> 2.27.0
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114869): https://edk2.groups.io/g/devel/message/114869
Mute This Topic: https://groups.io/mt/104072139/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2024-01-31  9:56 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-16  7:11 [edk2-devel] [PATCH 1/2] MdeModulePkg: Dxe: add LOONGARCH64 to mMachineTypeInfo Dongyan Qian
2024-01-16  7:11 ` [edk2-devel] [PATCH 2/2] ShellPkg: Update smbiosview for LoongArch Dongyan Qian
2024-01-16 12:12   ` Chao Li
2024-01-22  1:34     ` Gao, Zhichao
2024-01-16 12:11 ` [edk2-devel] [PATCH 1/2] MdeModulePkg: Dxe: add LOONGARCH64 to mMachineTypeInfo Chao Li
2024-01-31  7:00   ` Dongyan Qian
2024-01-31  9:56 ` 回复: " gaoliming via groups.io

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox