From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by mx.groups.io with SMTP id smtpd.web10.468.1614273590094406927 for ; Thu, 25 Feb 2021 09:19:50 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=n1 header.b=nQqQu/QO; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 216.228.121.64, mailfrom: ashishsingha@nvidia.com) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 25 Feb 2021 09:19:49 -0800 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 25 Feb 2021 17:19:49 +0000 Received: from ashishsingha-lnx.nvidia.com (172.20.145.6) by mail.nvidia.com (172.20.187.15) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 25 Feb 2021 17:19:48 +0000 From: "Ashish Singhal" To: , , CC: Ashish Singhal Subject: [PATCH] ArmPkg/ArmGicLib: Fix setting GICv3 Interrupt Priority Date: Thu, 25 Feb 2021 10:19:46 -0700 Message-ID: <0284001c888f058e59853e725d4f02a00840506a.1614273201.git.ashishsingha@nvidia.com> X-Mailer: git-send-email 2.7.4 Return-Path: ashishsingha@nvidia.com MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1614273589; bh=wdWHaF8amjUWQb6/1yRdwkTuqFVXf/QdEcrDttw72vA=; h=From:To:CC:Subject:Date:Message-ID:X-Mailer:MIME-Version: Content-Type; b=nQqQu/QOx/Lbi0HxNMkDwLya8KvyJB1pHmsYR01hIaym8AT1MY3C6jp6FH/Yqa5KU 6e9CE0vdkVMieV7LFgIycb2M7TBiOeaPB6m73Ok389xmAaIi3FoHCVKgqNpEKtXcsa qG0mMM2zD6j70f9ZnC0BfYRNHg0twCs9712ixGZkSzbqw30LO2HrIAEGySXagOZMMu gqEQT+l787gLExm6Vr2K77d/u0lyZww5JE0TqmVcKqRXdlVaM3HZ3oE6tqNWg/mGuc +FSR5ZsuYgkGlnQV9OtWqL3XNDMX9HzUynkG7ss4WdDD0qM5L4azXu+s7sOU42mKDz 3gSl42f2lIWNQ== Content-Type: text/plain Incorrect register is being set for configuring interrupt priority. Correct register is located in SGI space and not in RD space. Signed-off-by: Ashish Singhal --- ArmPkg/Drivers/ArmGic/ArmGicLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ArmPkg/Drivers/ArmGic/ArmGicLib.c b/ArmPkg/Drivers/ArmGic/ArmGicLib.c index 8ef32b3..3c0bee6 100644 --- a/ArmPkg/Drivers/ArmGic/ArmGicLib.c +++ b/ArmPkg/Drivers/ArmGic/ArmGicLib.c @@ -236,7 +236,7 @@ ArmGicSetInterruptPriority ( } MmioAndThenOr32 ( - GicCpuRedistributorBase + ARM_GIC_ICDIPR + (4 * RegOffset), + GicCpuRedistributorBase + ARM_GICR_CTLR_FRAME_SIZE + ARM_GIC_ICDIPR + (4 * RegOffset), ~(0xff << RegShift), Priority << RegShift ); -- 2.7.4