> On Aug 8, 2019, at 2:08 PM, Michael D Kinney wrote: > > Laszlo, > > This sounds like a good improvement. > > Do you have a recommended set of settings you would like > to see checked in to the root of each EDK II related > repository that would be required settings for all EDK II > developers. > Crazy idea allert ..... Could edksetup.sh have a --git option to set preferred git defaults? Thanks, Andrew Fish > Do you want to enter a BZ and prepare a patch with this > new file for the edk2 repo. Once it is approved and added > to edk2 repo, we can propagate to the other EDK II related > repos. > > Thanks, > > Mike > >> -----Original Message----- >> From: devel@edk2.groups.io >> [mailto:devel@edk2.groups.io ] On Behalf Of Laszlo Ersek >> Sent: Thursday, August 8, 2019 1:58 PM >> To: devel@edk2.groups.io ; Justen, Jordan L >> >; Kinney, Michael D >> > >> Cc: Feng, Bob C >; Gao, Liming >> > >> Subject: Re: [edk2-devel] [Patch 3/3] >> BaseTools/PatchCheck: Disable text conversion in 'git >> show' >> >> On 08/07/19 21:42, Jordan Justen wrote: >> >>> I thought adding Laszlo's settings >>> to .gitattributes might amount to solving two issues >> with one change. >> >> Independently of the present patch, I would be very >> much in favor of tracking a .gitattributes file in the >> project root dir, *if* we could also automate the >> following setting: >> >> git config diff.ini.xfuncname '^\[[A-Za-z0-9_., >> ]+]' >> >> For me as a reviewer, that setting (on the submitter >> side) makes a huge difference. I keep asking people to >> do it manually, and that gets old really quick. >> Unfortunately, I don't know how to automate that config >> knob from within the source tree. :( >> >> Thanks, >> Laszlo >> >> > > >