From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@apple.com header.s=20180706 header.b=PmDgCzAl; spf=pass (domain: apple.com, ip: 17.151.62.68, mailfrom: afish@apple.com) Received: from nwk-aaemail-lapp03.apple.com (nwk-aaemail-lapp03.apple.com [17.151.62.68]) by groups.io with SMTP; Thu, 08 Aug 2019 14:15:44 -0700 Received: from pps.filterd (nwk-aaemail-lapp03.apple.com [127.0.0.1]) by nwk-aaemail-lapp03.apple.com (8.16.0.27/8.16.0.27) with SMTP id x78L6wbL022111; Thu, 8 Aug 2019 14:15:42 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apple.com; h=sender : from : message-id : content-type : mime-version : subject : date : in-reply-to : cc : to : references; s=20180706; bh=iA7AeE2LN5jyaBgfUZRinoiYsPUVXjY9R4sv0I4oG10=; b=PmDgCzAlVJcn5trtn0NZ4UZaKsjWTWgcyInDOvkDuu78HbaQWf+t35X9wP4dP7d0VeL0 CdQrnaOiBLHTKnq8W+GUy+hNZA0FrfsbyGPX0iuB8DVYVn326+Tu8Qui6VdHbKNzuxVG osE6hg638KwzBlFAfb4AOMywRGa8BhkeyDCg55z5MQ00a6OBtk7Jkx0btWsJxwO47tPH rq4ru6r+SBwK2Q78kwY5PprL6I33CKa3HeWO9k7zl9obv3ewAw5V1BoZ66HXuOmHH5WN Y70tyoIFY6XxA8z0QYb99MhzE9CdwtGbF6SNxCxn7GgqJVJ83J6d+VeHPvGepmYaH9Je XQ== Received: from ma1-mtap-s03.corp.apple.com (ma1-mtap-s03.corp.apple.com [17.40.76.7]) by nwk-aaemail-lapp03.apple.com with ESMTP id 2u5tgm65dt-20 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Thu, 08 Aug 2019 14:15:42 -0700 Received: from nwk-mmpp-sz10.apple.com (nwk-mmpp-sz10.apple.com [17.128.115.122]) by ma1-mtap-s03.corp.apple.com (Oracle Communications Messaging Server 8.0.2.4.20190507 64bit (built May 7 2019)) with ESMTPS id <0PVX00G4ESE1X990@ma1-mtap-s03.corp.apple.com>; Thu, 08 Aug 2019 14:15:40 -0700 (PDT) Received: from process_milters-daemon.nwk-mmpp-sz10.apple.com by nwk-mmpp-sz10.apple.com (Oracle Communications Messaging Server 8.0.2.4.20190507 64bit (built May 7 2019)) id <0PVX00K00S4XJW00@nwk-mmpp-sz10.apple.com>; Thu, 08 Aug 2019 14:15:40 -0700 (PDT) X-Va-A: X-Va-T-CD: e48e8dc3f6c377b8dc939b4126ad19f3 X-Va-E-CD: 49a3460155ec6dcb7ea0c38303e6e872 X-Va-R-CD: 622843811cbb4ae942e0e239d2568b8d X-Va-CD: 0 X-Va-ID: 2acc5fa6-890c-4409-9bb4-fd00c4528417 X-V-A: X-V-T-CD: e48e8dc3f6c377b8dc939b4126ad19f3 X-V-E-CD: 49a3460155ec6dcb7ea0c38303e6e872 X-V-R-CD: 622843811cbb4ae942e0e239d2568b8d X-V-CD: 0 X-V-ID: e4e76c5f-81dd-4d5b-a191-c298493a8000 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-08-08_08:,, signatures=0 Received: from [17.235.33.13] (unknown [17.235.33.13]) by nwk-mmpp-sz10.apple.com (Oracle Communications Messaging Server 8.0.2.4.20190507 64bit (built May 7 2019)) with ESMTPSA id <0PVX008B1SE2ROB0@nwk-mmpp-sz10.apple.com>; Thu, 08 Aug 2019 14:15:39 -0700 (PDT) Sender: afish@apple.com From: "Andrew Fish" Message-id: <028D7F84-9970-450F-B6A9-4FEC8E5557D6@apple.com> MIME-version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [edk2-devel] [Patch 3/3] BaseTools/PatchCheck: Disable text conversion in 'git show' Date: Thu, 08 Aug 2019 14:15:23 -0700 In-reply-to: Cc: "lersek@redhat.com" , Jordan Justen , "Feng, Bob C" , "Gao, Liming" To: devel@edk2.groups.io, Mike Kinney References: <20190802001314.25980-1-michael.d.kinney@intel.com> <20190802001314.25980-4-michael.d.kinney@intel.com> <156477054101.20290.17514635538979393303@jljusten-skl> <8d511f89-f2a8-4d29-65e3-cc76fee12017@redhat.com> <156520696314.20973.15022549262963633561@jljusten-skl> <3a753a0c-8df9-4bf1-94be-b3f2c25c61df@redhat.com> X-Mailer: Apple Mail (2.3445.104.11) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-08-08_08:,, signatures=0 Content-type: multipart/alternative; boundary="Apple-Mail=_6B6F174A-86A4-4725-914C-7446CB296ED6" --Apple-Mail=_6B6F174A-86A4-4725-914C-7446CB296ED6 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Aug 8, 2019, at 2:08 PM, Michael D Kinney wrote: >=20 > Laszlo, >=20 > This sounds like a good improvement. >=20 > Do you have a recommended set of settings you would like > to see checked in to the root of each EDK II related=20 > repository that would be required settings for all EDK II > developers. >=20 Crazy idea allert .....=20 Could edksetup.sh have a --git option to set preferred git defaults? Thanks, Andrew Fish > Do you want to enter a BZ and prepare a patch with this > new file for the edk2 repo. Once it is approved and added > to edk2 repo, we can propagate to the other EDK II related > repos. >=20 > Thanks, >=20 > Mike >=20 >> -----Original Message----- >> From: devel@edk2.groups.io >> [mailto:devel@edk2.groups.io ] On Behalf O= f Laszlo Ersek >> Sent: Thursday, August 8, 2019 1:58 PM >> To: devel@edk2.groups.io ; Justen, Jordan = L >> >; Kinney,= Michael D >> > >> Cc: Feng, Bob C >; G= ao, Liming >> > >> Subject: Re: [edk2-devel] [Patch 3/3] >> BaseTools/PatchCheck: Disable text conversion in 'git >> show' >>=20 >> On 08/07/19 21:42, Jordan Justen wrote: >>=20 >>> I thought adding Laszlo's settings >>> to .gitattributes might amount to solving two issues >> with one change. >>=20 >> Independently of the present patch, I would be very >> much in favor of tracking a .gitattributes file in the >> project root dir, *if* we could also automate the >> following setting: >>=20 >> git config diff.ini.xfuncname '^\[[A-Za-z0-9_., >> ]+]' >>=20 >> For me as a reviewer, that setting (on the submitter >> side) makes a huge difference. I keep asking people to >> do it manually, and that gets old really quick. >> Unfortunately, I don't know how to automate that config >> knob from within the source tree. :( >>=20 >> Thanks, >> Laszlo >>=20 >>=20 >=20 >=20 >=20 --Apple-Mail=_6B6F174A-86A4-4725-914C-7446CB296ED6 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii
On Aug 8,= 2019, at 2:08 PM, Michael D Kinney <michael.d.kinney@intel.com> wrote:

Laszlo,

<= span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size:= 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; = letter-spacing: normal; text-align: start; text-indent: 0px; text-transform= : none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: = 0px; text-decoration: none; float: none; display: inline !important;" class= = =3D"">This sounds like a good improvement.

Do you have a r= ecommended set of settings you would like
to see checked in to the root of each EDK II related 
repository that would be required settings for all= EDK II
developers.


Crazy idea allert = ..... 

Could edksetup.sh have a --= git option to set preferred git defaults?

Thanks,

Andrew Fish

Do you w= ant to enter a BZ and prepare a patch with this
new file for the edk2 repo.  Once it is appro= ved and added
to edk2 r= epo, we can propagate to the other EDK II related
repos.

Thanks,

Mike

-----Original Message-----
From: devel@edk2.groups.io
[<= a href=3D"mailto:devel@edk2.groups.io" class=3D"">mailto:devel@edk2.groups.= io] On Behalf Of Laszlo Ersek
Sent: Thursday, August 8, 2= 019 1:58 PM
To: devel@edk2.groups.i= o; Justen, Jordan L
<jordan.l.justen@intel.com>; Kinney, Michael D=
<michael.d.kinney@intel.com>
Cc: Feng, Bob C <bob.c.feng@intel.com>;= Gao, Liming
<liming.gao@intel.com>
Subject: Re: [edk2-devel]= [Patch 3/3]
BaseTools/PatchCheck: Disable text conversion in= 'git
show'

On 08/07/19 21:42, J= ordan Justen wrote:

I thought adding Laszlo's settings
to .gitattribut= es might amount to solving two issues
with one c= hange.

Independently of the present patch, I w= ould be very
much in favor of tracking a .gitattributes file = in the
project root dir, *if* we could also automate the
following setting:

git config diff.i= ni.xfuncname     '^\[[A-Za-z0-9_.,
]+]'
For me as a reviewer, that setting (on the subm= itter
side) makes a huge difference. I keep asking people to<= br class=3D"">do it manually, and that gets old really quick.
Unfortunately, I don't know how to automate that config
knob= from within the source tree. :(

Thanks,
Laszlo




--Apple-Mail=_6B6F174A-86A4-4725-914C-7446CB296ED6--