From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7E41CAC18EA for ; Wed, 31 Jan 2024 21:03:45 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=1bWOVIfIP6a02B1qQPMq/aZSSBsecH6xjnnJ2IZYhrI=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706735024; v=1; b=Bcb/qL1bh0lLj0+mzj4nD9NA6fF3hF+Dc3x8PGzZkZsYtO4E2Xu52r4taJkSHOtOBber8Rkk fZ41Yc+TweqvjJeKHGiUxLcLdyhoOQQnuNSMqi8ZcVKrAdjSlt/rWaU0ku4OV8DhJXyO5TY9HqD ikHBFt2Haj0dMYhFYSE2cepM= X-Received: by 127.0.0.2 with SMTP id 8zkiYY7687511xoCtR4iQRht; Wed, 31 Jan 2024 13:03:44 -0800 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.6668.1706735023396616619 for ; Wed, 31 Jan 2024 13:03:43 -0800 X-Received: from [192.168.4.22] (unknown [47.201.241.198]) by linux.microsoft.com (Postfix) with ESMTPSA id 7031120B2000; Wed, 31 Jan 2024 13:03:41 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7031120B2000 Message-ID: <0294a34b-0632-4fb9-8cbc-276854b3dec7@linux.microsoft.com> Date: Wed, 31 Jan 2024 16:03:40 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] Commits Spanning Packages To: devel@edk2.groups.io, pedro.falcato@gmail.com Cc: Andrew Fish , Leif Lindholm , Michael D Kinney , Pierre Gondois , Ard Biesheuvel , Abner Chang , Min Xu , Zhiguang Liu , Tuan Phan , Yu Pu , Ray Ni References: <67b9f5d7-c338-473c-9322-d26022ef8f32@linux.microsoft.com> From: "Michael Kubacki" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: riUAVZ0np85Ukv8kh7FDKvAkx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="Bcb/qL1b"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/31/2024 3:41 PM, Pedro Falcato wrote: > On Wed, Jan 31, 2024 at 6:58=E2=80=AFPM Michael Kubacki > wrote: >> >> Some commits have been spanning packages. For a monolithic upstream repo >> like edk2, this makes ingesting commits downstream more tedious if >> project requirements do not necessitate all packages to be maintained. >> >> Below are examples of commits spanning packages. Many of these are more >> problematic because "core" packages like MdePkg, MdeModule, SecurityPkg, >> UefiCpuPkg, etc. are involved. OvmfPkg and ArmVirtPkg seem to be a >> common pairing. To focus the examples below, I excluded commits with >> that pair. >> >> The request is to limit crossing package boundaries as much as possible >> and for maintainers to assess package impact when merging changes. >=20 > Personally I'm all for making downstreams' lives easier, but I don't > see how one could pull off many of the changes you linked, in 2+ > commits, without breaking bisection. >=20 > Pulling off 103fa647d159e3d76be2634d2653c2d215dd0d46 would require you > to duplicate the struct, change a bunch of usages of the old struct to > the new struct, then change the old one back. This is hugely annoying > and complicated, and we should avoid this kind of rigamarole if > possible. >=20 That is why the request is: "... to limit crossing package boundaries as much as possible and for maintainers to assess package impact when merging changes." Not an absolute rule. However, the rules currently seem ambiguous and=20 susceptible to convenience. To provide a counter example of a single change that could easily be=20 split up and couples MdePkg (highly used, mandatory, fundamental) with=20 RedfishPkg (much less frequently used, specialized) -=20 https://github.com/tianocore/edk2/commit/7275993dc64481b1c21d7d70af434bf. There are also dependency relationships between packages. The example=20 you cited is between ArmPkg and ArmPlatformPkg. Which has better=20 cohesion than something like the example I provided between MdePkg and=20 RedfishPkg. Or, all the packages involved in=20 https://github.com/tianocore/edk2/commit/2f981bddcbd6adde5f682caf0d3812b=20 (which could also easily been split up). Those should have been split up and could have with minimal effort. Not looking for anything more than to request devs understand impact,=20 package relationships/scope, and consider tooling to make this more=20 consistent and raise awareness when it relatively rarely comes up. - Michael -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114921): https://edk2.groups.io/g/devel/message/114921 Mute This Topic: https://groups.io/mt/104081468/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-