回复: [edk2-devel] [PATCH V2 1/2] MdePkg: Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0

["gaoliming via groups.io" <gaoliming=byosoft.com.cn@groups.io>]

Eduardo:
  The patch is good to me. Reviewed-by: Liming Gao
<gaoliming@byosoft.com.cn>

  Besides, I have one minor comment. Please see the below.

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Eduardo
> Cuevas Farfan
> 发送时间: 2023年8月11日 0:32
> 收件人: devel@edk2.groups.io
> 抄送: Eduardo Cuevas Farfan <eduardo.cuevas.farfan@intel.com>
> 主题: [edk2-devel] [PATCH V2 1/2] MdePkg: Add ProcessorUpgradeSocket
> definitions from SMBIOS 3.7.0
> 
> This patch adds below definitions from SMBIOS 3.7.0 into Smbios.h
> - ProcessorUpgradeSocketAM5
> - ProcessorUpgradeSocketSP5
> - ProcessorUpgradeSocketSP6
> - ProcessorUpgradeSocketBGA883
> - ProcessorUpgradeSocketBGA1190
> - ProcessorUpgradeSocketBGA4129
> - ProcessorUpgradeSocketLGA4710
> - ProcessorUpgradeSocketLGA7529
> 
> Signed-off-by: Eduardo Cuevas Farfan <eduardo.cuevas.farfan@intel.com>
> ---
>  MdePkg/Include/IndustryStandard/SmBios.h | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> b/MdePkg/Include/IndustryStandard/SmBios.h
> index 89985bb4186b..fb6ed2dee051 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -1,7 +1,7 @@
>  /** @file
> 
>    Industry Standard Definitions of SMBIOS Table Specification v3.6.0.
> 
[Liming] Please also update the version to v3.7.0

Thanks
Liming
> 
> 
> -Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.<BR>
> 
> +Copyright (c) 2006 - 2023, Intel Corporation. All rights reserved.<BR>
> 
>  (C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP<BR>
> 
>  (C) Copyright 2015 - 2019 Hewlett Packard Enterprise Development LP<BR>
> 
>  Copyright (c) 2022, AMD Incorporated. All rights reserved.<BR>
> 
> @@ -863,7 +863,15 @@ typedef enum {
>    ProcessorUpgradeSocketLGA1211   = 0x45,
> 
>    ProcessorUpgradeSocketLGA2422   = 0x46,
> 
>    ProcessorUpgradeSocketLGA5773   = 0x47,
> 
> -  ProcessorUpgradeSocketBGA5773   = 0x48
> 
> +  ProcessorUpgradeSocketBGA5773   = 0x48,
> 
> +  ProcessorUpgradeSocketAM5       = 0x49,
> 
> +  ProcessorUpgradeSocketSP5       = 0x4A,
> 
> +  ProcessorUpgradeSocketSP6       = 0x4B,
> 
> +  ProcessorUpgradeSocketBGA883    = 0x4C,
> 
> +  ProcessorUpgradeSocketBGA1190   = 0x4D,
> 
> +  ProcessorUpgradeSocketBGA4129   = 0x4E,
> 
> +  ProcessorUpgradeSocketLGA4710   = 0x4F,
> 
> +  ProcessorUpgradeSocketLGA7529   = 0x50
> 
>  } PROCESSOR_UPGRADE;
> 
> 
> 
>  ///
> 
> --
> 2.26.2.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#107695):
> https://edk2.groups.io/g/devel/message/107695
> Mute This Topic: https://groups.io/mt/100667109/4905953
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaoliming@byosoft.com.cn]
> -=-=-=-=-=-=
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108076): https://edk2.groups.io/g/devel/message/108076
Mute This Topic: https://groups.io/mt/101025757/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-