From: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>
To: Sami Mujawar <sami.mujawar@arm.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "nd@arm.com" <nd@arm.com>,
"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>,
"Stephanie.Hughes-Fitt@arm.com" <Stephanie.Hughes-Fitt@arm.com>
Subject: Re: [staging/dynamictables PATCH 0/2] Dynamic Tables Framework core
Date: Tue, 20 Mar 2018 22:07:32 +0000 [thread overview]
Message-ID: <02A34F284D1DA44BB705E61F7180EF0A980EFDBB@ORSMSX114.amr.corp.intel.com> (raw)
In-Reply-To: <20180319151847.85204-1-sami.mujawar@arm.com>
Please don't use the name DynamicTableManagerDxe. What does it manage? DynamicTables? How does adding the word "Manager" provide any useful information for the reader? I recommend the name "DynamicAcpiTableDxe". It makes it clear this this code is specifically for generating ACPI tables at runtime (as opposed to some sort of unnamed table), and it removes the unnecessary prose.
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Sami Mujawar
Sent: Monday, March 19, 2018 8:19 AM
To: edk2-devel@lists.01.org
Cc: nd@arm.com; leif.lindholm@linaro.org; Stephanie.Hughes-Fitt@arm.com
Subject: [edk2] [staging/dynamictables PATCH 0/2] Dynamic Tables Framework core
The Dynamic Tables Framework is a prototyped as a solution for automatically generating the firmware tables based on hardware description.
This patchset is the Dynamic Tables Framework core and implement the generic/standard modules for dynamically generating ACPI 6.2 tables for ARM platform. The platform specific modules are in the devel-dynamictables branch in the edk2-platforms repository at:
https://github.com/tianocore/edk2-platforms/tree/devel-dynamictables
The first patch in this patchset 'MdePkg: SMMUv3 updates for IORT'
is a precursor for the Dynamic Tables Framework and has been submitted independently to the edk2-devel mailing list where it is currently awaiting acceptance.
The sources for this patchset can be seen at:
https://github.com/samimujawar/edk2-staging/tree/187_dynamictables_v1
Sami Mujawar (2):
MdePkg: SMMUv3 updates for IORT table definitions
DynamicTablesPkg: Dynamic Tables Framework
DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/AcpiTableFactory/AcpiTableFactory.c | 226 +++
DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DeviceTreeTableFactory/DeviceTreeTableFactory.c | 225 +++
DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactory.h | 125 ++
DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.c | 84 +
DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf | 59 +
DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/SmbiosTableFactory/SmbiosTableFactory.c | 226 +++
DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.c | 533 +++++
DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf | 48 +
DynamicTablesPkg/DynamicTables.dsc.inc | 46 +
DynamicTablesPkg/DynamicTables.fdf.inc | 35 +
DynamicTablesPkg/DynamicTablesPkg.dec | 42 +
DynamicTablesPkg/Include/AcpiTableGenerator.h | 282 +++
DynamicTablesPkg/Include/ArmNameSpaceObjects.h | 587 ++++++
DynamicTablesPkg/Include/ConfigurationManagerHelper.h | 119 ++
DynamicTablesPkg/Include/ConfigurationManagerObject.h | 176 ++
DynamicTablesPkg/Include/DeviceTreeTableGenerator.h | 182 ++
DynamicTablesPkg/Include/Library/TableHelperLib.h | 70 +
DynamicTablesPkg/Include/Protocol/ConfigurationManagerProtocol.h | 128 ++
DynamicTablesPkg/Include/Protocol/DynamicTableFactoryProtocol.h | 140 ++
DynamicTablesPkg/Include/SmbiosTableGenerator.h | 240 +++
DynamicTablesPkg/Include/StandardNameSpaceObjects.h | 116 ++
DynamicTablesPkg/Include/TableGenerator.h | 252 +++
DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/AcpiDbg2LibArm.inf | 47 +
DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c | 440 +++++
DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/AcpiFadtLibArm.inf | 41 +
DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c | 666 +++++++
DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/AcpiGtdtLibArm.inf | 41 +
DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c | 670 +++++++
DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf | 41 +
DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c | 2046 ++++++++++++++++++++
DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.h | 50 +
DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/AcpiMadtLibArm.inf | 41 +
DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c | 717 +++++++
DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/AcpiMcfgLibArm.inf | 41 +
DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/McfgGenerator.c | 342 ++++
DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/AcpiRawLibArm.inf | 41 +
DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/RawGenerator.c | 142 ++
DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/AcpiSpcrLibArm.inf | 41 +
DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c | 324 ++++
DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c | 164 ++
DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf | 35 +
MdePkg/Include/IndustryStandard/IoRemappingTable.h | 11 +-
42 files changed, 9881 insertions(+), 1 deletion(-) create mode 100644 DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/AcpiTableFactory/AcpiTableFactory.c
create mode 100644 DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DeviceTreeTableFactory/DeviceTreeTableFactory.c
create mode 100644 DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactory.h
create mode 100644 DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.c
create mode 100644 DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf
create mode 100644 DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/SmbiosTableFactory/SmbiosTableFactory.c
create mode 100644 DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.c
create mode 100644 DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf
create mode 100644 DynamicTablesPkg/DynamicTables.dsc.inc
create mode 100644 DynamicTablesPkg/DynamicTables.fdf.inc
create mode 100644 DynamicTablesPkg/DynamicTablesPkg.dec
create mode 100644 DynamicTablesPkg/Include/AcpiTableGenerator.h
create mode 100644 DynamicTablesPkg/Include/ArmNameSpaceObjects.h
create mode 100644 DynamicTablesPkg/Include/ConfigurationManagerHelper.h
create mode 100644 DynamicTablesPkg/Include/ConfigurationManagerObject.h
create mode 100644 DynamicTablesPkg/Include/DeviceTreeTableGenerator.h
create mode 100644 DynamicTablesPkg/Include/Library/TableHelperLib.h
create mode 100644 DynamicTablesPkg/Include/Protocol/ConfigurationManagerProtocol.h
create mode 100644 DynamicTablesPkg/Include/Protocol/DynamicTableFactoryProtocol.h
create mode 100644 DynamicTablesPkg/Include/SmbiosTableGenerator.h
create mode 100644 DynamicTablesPkg/Include/StandardNameSpaceObjects.h
create mode 100644 DynamicTablesPkg/Include/TableGenerator.h
create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/AcpiDbg2LibArm.inf
create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c
create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/AcpiFadtLibArm.inf
create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c
create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/AcpiGtdtLibArm.inf
create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c
create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf
create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c
create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.h
create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/AcpiMadtLibArm.inf
create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c
create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/AcpiMcfgLibArm.inf
create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/McfgGenerator.c
create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/AcpiRawLibArm.inf
create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/RawGenerator.c
create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/AcpiSpcrLibArm.inf
create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c
create mode 100644 DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c
create mode 100644 DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2018-03-20 22:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 15:18 [staging/dynamictables PATCH 0/2] Dynamic Tables Framework core Sami Mujawar
2018-03-19 15:18 ` [staging/dynamictables PATCH 1/2] MdePkg: SMMUv3 updates for IORT table definitions Sami Mujawar
2018-03-19 15:21 ` Ard Biesheuvel
2018-03-19 15:27 ` Sami Mujawar
2018-03-19 16:16 ` Evan Lloyd
2018-03-19 15:18 ` [staging/dynamictables PATCH 2/2] DynamicTablesPkg: Dynamic Tables Framework Sami Mujawar
2018-03-19 16:16 ` Evan Lloyd
2018-03-20 22:07 ` Desimone, Nathaniel L [this message]
2018-03-21 13:23 ` [staging/dynamictables PATCH 0/2] Dynamic Tables Framework core Evan Lloyd
2018-03-23 23:46 ` Desimone, Nathaniel L
2018-03-21 2:56 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02A34F284D1DA44BB705E61F7180EF0A980EFDBB@ORSMSX114.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox