From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: nathaniel.l.desimone@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Tue, 23 Apr 2019 22:27:32 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Apr 2019 22:27:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,388,1549958400"; d="scan'208";a="133885030" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by orsmga007.jf.intel.com with ESMTP; 23 Apr 2019 22:27:31 -0700 Received: from orsmsx113.amr.corp.intel.com (10.22.240.9) by ORSMSX103.amr.corp.intel.com (10.22.225.130) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 23 Apr 2019 22:27:31 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.50]) by ORSMSX113.amr.corp.intel.com ([169.254.9.24]) with mapi id 14.03.0415.000; Tue, 23 Apr 2019 22:27:31 -0700 From: "Nate DeSimone" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: Laszlo Ersek , "Chiu, Chasel" , "Zeng, Star" , "Gao, Liming" , "Bi, Dandan" Subject: Re: [PATCH V2 6/8] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Decrease the name collisions Thread-Topic: [PATCH V2 6/8] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Decrease the name collisions Thread-Index: AQHU+lp88A3lVEQaF0Gh6sxukYaniKZKx+rw Date: Wed, 24 Apr 2019 05:27:30 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEA66254@ORSMSX114.amr.corp.intel.com> References: <20190424045827.19348-1-zhichao.gao@intel.com> <20190424045827.19348-7-zhichao.gao@intel.com> In-Reply-To: <20190424045827.19348-7-zhichao.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjFhNTdhOWQtNzcwYS00YjVjLTk4NWMtYThmMjhiMWY2YmQwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTjgxQiswakcxTmIxQUdMczN3SUhXSitNQTZGMWNqbnA1R1ZpV2l4ZFZFYlgyV1RZNHFsZDFUOVBTOWF3bzdzNCJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Update copyright year from 2016 to 2019. After that is done... Reviewed-by: Nate DeSimone -----Original Message----- From: Gao, Zhichao=20 Sent: Tuesday, April 23, 2019 9:58 PM To: devel@edk2.groups.io Cc: Laszlo Ersek ; Chiu, Chasel ;= Desimone, Nathaniel L ; Zeng, Star ; Gao, Liming ; Bi, Dandan Subject: [PATCH V2 6/8] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Decrease t= he name collisions REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1740 Add a 'static' descriptor to the global variables that only used in a singl= e file to minimize the name collisions. This is only for the varable named 'mExitBootServicesEvent'. Cc: Laszlo Ersek Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Liming Gao Cc: Dandan Bi Signed-off-by: Zhichao Gao --- IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c = b/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c index fe344a5327..459acc694b 100644 --- a/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c +++ b/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c @@ -39,7 +39,7 @@ extern EFI_GUID gAddPerfRecordProtocolGuid; extern EFI_G= UID gFspHobGuid; extern EFI_GUID gFspApiPerformanceGuid; =20 -EFI_EVENT mExitBootServicesEvent =3D NULL; +static EFI_EVENT mExitBootServicesEvent =3D NULL; =20 /** Relocate this image under 4G memory. -- 2.21.0.windows.1