public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "Kubacki, Michael A" <michael.a.kubacki@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Chiu, Chasel" <chasel.chiu@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-platforms/devel-MinPlatform][PATCH v1 1/2] KabylakeOpenBoardPkg/AcpiTables: Remove dead code
Date: Thu, 25 Apr 2019 18:13:47 +0000	[thread overview]
Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEA6DFEF@ORSMSX114.amr.corp.intel.com> (raw)
In-Reply-To: <20190425010855.21596-2-michael.a.kubacki@intel.com>

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: Kubacki, Michael A 
Sent: Wednesday, April 24, 2019 6:09 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: [edk2-platforms/devel-MinPlatform][PATCH v1 1/2] KabylakeOpenBoardPkg/AcpiTables: Remove dead code

Removes ASL code not referenced in the package.

Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
---
 .../KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl     | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl b/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl
index 56c27f3a63..d20e35f12e 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl
+++ b/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.as
+++ l
@@ -1,7 +1,7 @@
 /** @file
  Thunderbolt ACPI methods
 
-Copyright (c) 2018, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.<BR>
 This program and the accompanying materials are licensed and made available under  the terms and conditions of the BSD License that accompanies this distribution.
 The full text of the license may be found at @@ -106,14 +106,6 @@ External(\_SB.PCI0.RP24.PON, MethodObj)  External(\_SB.PCI0.PEG0.PG00._ON, MethodObj)  External(\_SB.PCI0.PEG1.PG01._ON, MethodObj)  External(\_SB.PCI0.PEG2.PG02._ON, MethodObj) -// -// SA:RestrictedBegin -// -External(\_SB.PCI0.LKEN, MethodObj) -External(\_SB.PCI0.LKDS, MethodObj) -// -// SA:RestrictedEnd -//
 
 Name(TRDO, 0) // 1 during TBT RTD3 _ON
 Name(TRD3, 0) // 1 during TBT RTD3 _OFF @@ -612,7 +604,7 @@ Scope(\_GPE)
       } Else {
         Return (OSUP(Local0, DTBT_CONTROLLER))
       }
-    } Else 
+    } Else
     {
       ADBG("Dev Present")
       Return (0)
--
2.16.2.windows.1


  parent reply	other threads:[~2019-04-25 18:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-25  1:08 [edk2-platforms/devel-MinPlatform][PATCH v1 0/2] Remove dead code Kubacki, Michael A
2019-04-25  1:08 ` [edk2-platforms/devel-MinPlatform][PATCH v1 1/2] KabylakeOpenBoardPkg/AcpiTables: " Kubacki, Michael A
2019-04-25  1:17   ` Chiu, Chasel
2019-04-25 18:13   ` Nate DeSimone [this message]
2019-04-25  1:08 ` [edk2-platforms/devel-MinPlatform][PATCH v1 2/2] ClevoOpenBoardPkg/AcpiTables: " Kubacki, Michael A
2019-04-25 18:13   ` Nate DeSimone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02A34F284D1DA44BB705E61F7180EF0AAEA6DFEF@ORSMSX114.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox