From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: nathaniel.l.desimone@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Thu, 25 Apr 2019 11:13:48 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2019 11:13:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,394,1549958400"; d="scan'208";a="318970788" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by orsmga005.jf.intel.com with ESMTP; 25 Apr 2019 11:13:48 -0700 Received: from orsmsx155.amr.corp.intel.com (10.22.240.21) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 25 Apr 2019 11:13:48 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.50]) by ORSMSX155.amr.corp.intel.com ([169.254.7.27]) with mapi id 14.03.0415.000; Thu, 25 Apr 2019 11:13:47 -0700 From: "Nate DeSimone" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Kinney, Michael D" Subject: Re: [edk2-platforms/devel-MinPlatform][PATCH v1 1/2] KabylakeOpenBoardPkg/AcpiTables: Remove dead code Thread-Topic: [edk2-platforms/devel-MinPlatform][PATCH v1 1/2] KabylakeOpenBoardPkg/AcpiTables: Remove dead code Thread-Index: AQHU+wOYbeZwhAE1QUS4VnUQuYBGXKZNLxMg Date: Thu, 25 Apr 2019 18:13:47 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEA6DFEF@ORSMSX114.amr.corp.intel.com> References: <20190425010855.21596-1-michael.a.kubacki@intel.com> <20190425010855.21596-2-michael.a.kubacki@intel.com> In-Reply-To: <20190425010855.21596-2-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWE4NTUxYjMtY2U2ZS00MjM3LWFmNDQtOGJjMDc1MzRhMzRkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibGdYQ0o0dVdsaFByQk5MMDVkeHFpQVorVlRQQ2ROZTNMTjhLQTFVMlJDUURpZ2RsSngwbTlHRXBCV2VwY0lhQSJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: Kubacki, Michael A=20 Sent: Wednesday, April 24, 2019 6:09 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Chiu, Chasel ; Kinney, Michael D Subject: [edk2-platforms/devel-MinPlatform][PATCH v1 1/2] KabylakeOpenBoard= Pkg/AcpiTables: Remove dead code Removes ASL code not referenced in the package. Cc: Nate DeSimone Cc: Chasel Chiu Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kubacki --- .../KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl | 12 ++------= ---- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tb= t.asl b/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl index 56c27f3a63..d20e35f12e 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl +++ b/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.as +++ l @@ -1,7 +1,7 @@ /** @file Thunderbolt ACPI methods =20 -Copyright (c) 2018, Intel Corporation. All rights reserved.
+Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made availabl= e under the terms and conditions of the BSD License that accompanies this = distribution. The full text of the license may be found at @@ -106,14 +106,6 @@ External= (\_SB.PCI0.RP24.PON, MethodObj) External(\_SB.PCI0.PEG0.PG00._ON, MethodOb= j) External(\_SB.PCI0.PEG1.PG01._ON, MethodObj) External(\_SB.PCI0.PEG2.P= G02._ON, MethodObj) -// -// SA:RestrictedBegin -// -External(\_SB.PCI0.LKEN= , MethodObj) -External(\_SB.PCI0.LKDS, MethodObj) -// -// SA:RestrictedEnd = -// =20 Name(TRDO, 0) // 1 during TBT RTD3 _ON Name(TRD3, 0) // 1 during TBT RTD3 _OFF @@ -612,7 +604,7 @@ Scope(\_GPE) } Else { Return (OSUP(Local0, DTBT_CONTROLLER)) } - } Else=20 + } Else { ADBG("Dev Present") Return (0) -- 2.16.2.windows.1