From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: nathaniel.l.desimone@intel.com) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Tue, 28 May 2019 17:45:25 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 May 2019 17:45:25 -0700 X-ExtLoop1: 1 Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by fmsmga001.fm.intel.com with ESMTP; 28 May 2019 17:45:24 -0700 Received: from orsmsx113.amr.corp.intel.com (10.22.240.9) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 28 May 2019 17:45:24 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.116]) by ORSMSX113.amr.corp.intel.com ([169.254.9.231]) with mapi id 14.03.0415.000; Tue, 28 May 2019 17:45:24 -0700 From: "Nate DeSimone" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: "Agyeman, Prince" , "Kubacki, Michael A" Subject: Re: [PATCH] Platform/Intel: Add fspapi build parameter Thread-Topic: [PATCH] Platform/Intel: Add fspapi build parameter Thread-Index: AQHVFSpOf9nYFhb3nECZyq6oHLwjw6aBRSVw Date: Wed, 29 May 2019 00:45:24 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEB5F91B@ORSMSX114.amr.corp.intel.com> References: <20190528075220.12576-1-chasel.chiu@intel.com> In-Reply-To: <20190528075220.12576-1-chasel.chiu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjFhZDc5YjYtYTE4Yy00M2FiLTk5NmItMzAwYmEzZDY2NWI2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTzBNaVg3ZEJNZTJoM1NVbXRcL2FFRU90UlNTbGQ0QjdoNnV1OVwvcmRoS01uNVwvK3pDTFVSQWJFMnVNXC9JM0xwdU0ifQ== x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: Chiu, Chasel=20 Sent: Tuesday, May 28, 2019 12:52 AM To: devel@edk2.groups.io Cc: Agyeman, Prince ; Desimone, Nathaniel L ; Kubacki, Michael A Subject: [PATCH] Platform/Intel: Add fspapi build parameter REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1824 Going forward FSP Dispatch mode will be default in KabylakeOpenBoardPkg and= requires fspapi build parameter to switch back to FSP API mode. When --fspapi given to build python script it will set gIntelFsp2WrapperTok= enSpaceGuid.PcdFspModeSelection to 1, otherwise the PCD will be the default= value defined by each *BoardPkg. Test: verified the PCD PcdFspModeSelection can be overridden by new build parameter. Cc: Agyeman Prince Cc: Nate DeSimone Cc: Michael Kubacki Signed-off-by: Chasel Chiu --- Platform/Intel/build_bios.py | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/Platform/Intel/build_bios.py b/Platform/Intel/build_bios.py in= dex 9effefc0c7..9f8d78f6e8 100644 --- a/Platform/Intel/build_bios.py +++ b/Platform/Intel/build_bios.py @@ -359,6 +359,11 @@ def build(config): command.append("-D") command.append("MAX_SOCKET=3D" + config["MAX_SOCKET"]) =20 + if config.get("API_MODE_FSP_WRAPPER_BUILD", "FALSE") =3D=3D "TRUE": + #Override PCD to enable API mode FSP wrapper. + command.append("--pcd") + =20 + command.append("gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection=3D1" + ) + shell =3D True if os.name =3D=3D "posix": shell =3D False @@ -840,6 +845,9 @@ def get_cmd_config_arguments(arguments): if arguments.fsp is True: result["FSP_WRAPPER_BUILD"] =3D "TRUE" =20 + if arguments.fspapi is True: + result["API_MODE_FSP_WRAPPER_BUILD"] =3D "TRUE" + return result =20 =20 @@ -910,9 +918,12 @@ def get_cmd_arguments(build_config): parser.add_argument("--performance", help=3D"performance build enabled= ", action=3D'store_true', dest=3D"performance") =20 - parser.add_argument("--fsp", help=3D"fsp build enabled", + parser.add_argument("--fsp", help=3D"fsp wrapper build enabled", action=3D'store_true', dest=3D"fsp") =20 + parser.add_argument("--fspapi", help=3D"API mode fsp wrapper build ena= bled", + action=3D'store_true', dest=3D"fspapi") + return parser.parse_args() =20 =20 -- 2.13.3.windows.1