public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Chiu, Chasel" <chasel.chiu@intel.com>
Cc: "Kubacki, Michael A" <michael.a.kubacki@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/2] KabylakeSiliconPkg: Add FSP Dispatch switch.
Date: Wed, 29 May 2019 01:12:29 +0000	[thread overview]
Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEB5FE96@ORSMSX114.amr.corp.intel.com> (raw)
In-Reply-To: <20190522083510.17476-2-chasel.chiu@intel.com>

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chiu, Chasel
Sent: Wednesday, May 22, 2019 1:35 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Kubacki, Michael A <michael.a.kubacki@intel.com>
Subject: [edk2-devel] [PATCH 1/2] KabylakeSiliconPkg: Add FSP Dispatch switch.

From: "Chasel, Chiu" <chasel.chiu@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1832

PcdFspModeSelection is used as switch for boot loader to consume FSP in API mode or Dispatch mode. For backward compatibility, if boot loader running in FSP API mode the KabylakeFspBinPkg will be used which does not have FSP 2.1 changes. For FSP Dispatch mode AmberLakeFspBinPkg will be used with FSP 2.1 support.
One INF was duplicate to include different DEC file in each build type.

Test: Booted Kabylake RVP3 to Windows successfully.

Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
---
 Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconPolicyInitLibFsp/PeiSiliconPolicyInitLibFspAml.inf | 146 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 146 insertions(+)

diff --git a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconPolicyInitLibFsp/PeiSiliconPolicyInitLibFspAml.inf b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconPolicyInitLibFsp/PeiSiliconPolicyInitLibFspAml.inf
new file mode 100644
index 0000000000..aebd3583bc
--- /dev/null
+++ b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconPolicyInitLibFs
+++ p/PeiSiliconPolicyInitLibFspAml.inf
@@ -0,0 +1,146 @@
+### @file
+# Library functions for Fsp Policy Initialization Library.
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> # # 
+SPDX-License-Identifier: BSD-2-Clause-Patent # ##
+
+#######################################################################
+#########
+#
+# Defines Section - statements that will be processed to create a Makefile.
+#
+#######################################################################
+#########
+[Defines]
+  INF_VERSION                    = 0x00010005
+  BASE_NAME                      = PeiSiliconPolicyInitLibFspAml
+  FILE_GUID                      = 930816C4-D182-4A23-BF21-9AED635AF06C
+  MODULE_TYPE                    = BASE
+  VERSION_STRING                 = 1.0
+  LIBRARY_CLASS                  = SiliconPolicyInitLib
+
+#
+# The following information is for reference only and not required by the build tools.
+#
+#  VALID_ARCHITECTURES           = IA32
+#
+
+#######################################################################
+#########
+#
+# Sources Section - list of files that are required for the build to succeed.
+#
+#######################################################################
+#########
+
+[Sources]
+  PeiFspPolicyInitLib.c
+  PeiFspSiPolicyInitLib.c
+  PeiFspPchPolicyInitLib.c
+  PeiFspCpuPolicyInitLib.c
+  PeiFspMePolicyInitLib.c
+  PeiFspSaPolicyInitLib.c
+  PeiFspMiscUpdInitLib.c
+
+  PeiPolicyInitPreMem.c
+  PeiPolicyInit.c
+  PeiPolicyInit.h
+
+#######################################################################
+#########
+#
+# Package Dependency Section - list of Package files that are required for
+#                              this module.
+#
+#######################################################################
+#########
+
+[Packages]
+  MdePkg/MdePkg.dec
+  MdeModulePkg/MdeModulePkg.dec
+  IntelFsp2Pkg/IntelFsp2Pkg.dec
+  IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
+  KabylakeSiliconPkg/SiPkg.dec
+  AmberLakeFspBinPkg/AmberLakeFspBinPkg.dec
+
+[LibraryClasses]
+  BaseMemoryLib
+  DebugLib
+  IoLib
+  PeiServicesLib
+  PcdLib
+  SmbusLib
+  MmPciLib
+  ConfigBlockLib
+  MemoryAllocationLib
+  DebugPrintErrorLevelLib
+  FspWrapperApiLib
+
+[Pcd]
+  gSiPkgTokenSpaceGuid.PcdTsegSize                    ## CONSUMES
+  gSiPkgTokenSpaceGuid.PcdSmbusBaseAddress            ## CONSUMES
+  gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamBase      ## CONSUMES
+  gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamSize      ## CONSUMES
+  gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize   ## CONSUMES
+  gIntelFsp2PkgTokenSpaceGuid.PcdFspReservedBufferSize ## CONSUMES
+  gIntelFsp2WrapperTokenSpaceGuid.PcdFspmUpdDataAddress ## CONSUMES
+  gIntelFsp2WrapperTokenSpaceGuid.PcdFspmBaseAddress    ## CONSUMES
+  gIntelFsp2WrapperTokenSpaceGuid.PcdFspsUpdDataAddress ## CONSUMES
+  gIntelFsp2WrapperTokenSpaceGuid.PcdFspsBaseAddress    ## CONSUMES
+
+[Ppis]
+  gSiPolicyPpiGuid                              ## CONSUMES
+  gSiPreMemPolicyPpiGuid                        ## CONSUMES
+
+[Guids]
+  gTraceHubPreMemConfigGuid                     ## CONSUMES
+  gSmbusPreMemConfigGuid                        ## CONSUMES
+  gDciPreMemConfigGuid                          ## CONSUMES
+  gHpetPreMemConfigGuid                         ## CONSUMES
+  gHsioPciePreMemConfigGuid                     ## CONSUMES
+  gHsioSataPreMemConfigGuid                     ## CONSUMES
+  gHsioPreMemConfigGuid                         ## CONSUMES
+  gPcieRpPreMemConfigGuid                       ## CONSUMES
+  gLpcPreMemConfigGuid                          ## CONSUMES
+  gPchGeneralPreMemConfigGuid                   ## CONSUMES
+  gWatchDogPreMemConfigGuid                     ## CONSUMES
+  gLanConfigGuid                                ## CONSUMES
+  gPcieRpConfigGuid                             ## CONSUMES
+  gSataConfigGuid                               ## CONSUMES
+  gHdAudioConfigGuid                            ## CONSUMES
+  gCio2ConfigGuid                               ## CONSUMES
+  gScsConfigGuid                                ## CONSUMES
+  gIshConfigGuid                                ## CONSUMES
+  gSpiConfigGuid                                ## CONSUMES
+  gSataConfigGuid                               ## CONSUMES
+  gUsbConfigGuid                                ## CONSUMES
+  gSerialIoConfigGuid                           ## CONSUMES
+  gInterruptConfigGuid                          ## CONSUMES
+  gLockDownConfigGuid                           ## CONSUMES
+  gSaMiscPeiPreMemConfigGuid                    ## PRODUCES
+  gMemoryConfigGuid                             ## CONSUMES
+  gMemoryConfigNoCrcGuid                        ## CONSUMES
+  gGraphicsPeiConfigGuid                        ## CONSUMES
+  gMePeiPreMemConfigGuid                        ## CONSUMES
+  gMePeiConfigGuid                              ## CONSUMES
+  gAmtPeiConfigGuid                             ## CONSUMES
+  gDmiConfigGuid                                ## CONSUMES
+  gFlashProtectionConfigGuid                    ## CONSUMES
+  gIoApicConfigGuid                             ## CONSUMES
+  gPmConfigGuid                                 ## CONSUMES
+  gP2sbConfigGuid                               ## CONSUMES
+  gPchGeneralConfigGuid                         ## CONSUMES
+  gPort61ConfigGuid                             ## CONSUMES
+  gSerialIrqConfigGuid                          ## CONSUMES
+  gThermalConfigGuid                            ## CONSUMES
+  gCpuSecurityPreMemConfigGuid                  ## CONSUMES
+  gCpuTxtPreMemConfigGuid                       ## CONSUMES
+  gCpuConfigGuid                                ## CONSUMES
+  gBiosGuardConfigGuid                          ## CONSUMES
+  gCpuOverclockingPreMemConfigGuid              ## CONSUMES
+  gCpuConfigLibPreMemConfigGuid                 ## CONSUMES
+  gCpuSgxConfigGuid                             ## CONSUMES
+  gCpuPowerMgmtBasicConfigGuid                  ## CONSUMES
+  gCpuPowerMgmtCustomConfigGuid                 ## CONSUMES
+  gCpuTestConfigGuid                            ## CONSUMES
+  gCpuPidTestConfigGuid                         ## CONSUMES
+  gCpuPowerMgmtTestConfigGuid                   ## CONSUMES
+  gSmramCpuDataHeaderGuid                       ## CONSUMES
+  gFspReservedMemoryResourceHobTsegGuid         ## CONSUMES
--
2.13.3.windows.1





  reply	other threads:[~2019-05-29  1:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-22  8:35 [PATCH 0/2] Add FSP Dispatch mode switch Chiu, Chasel
2019-05-22  8:35 ` [PATCH 1/2] KabylakeSiliconPkg: Add FSP Dispatch switch Chiu, Chasel
2019-05-29  1:12   ` Nate DeSimone [this message]
2019-05-22  8:35 ` [PATCH 2/2] KabylakeOpenBoardPkg: " Chiu, Chasel
2019-05-29  1:12   ` Nate DeSimone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02A34F284D1DA44BB705E61F7180EF0AAEB5FE96@ORSMSX114.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox