* [PATCH 0/2] Support DXE drivers in FSP 2.1. @ 2019-06-04 0:52 Chiu, Chasel 2019-06-04 0:52 ` [PATCH 1/2] Intel/MinPlatformPkg: " Chiu, Chasel 2019-06-04 0:52 ` [PATCH 2/2] KabylakeOpenBoardPkg: " Chiu, Chasel 0 siblings, 2 replies; 6+ messages in thread From: Chiu, Chasel @ 2019-06-04 0:52 UTC (permalink / raw) To: devel; +Cc: Michael Kubacki, Nate DeSimone, Liming Gao In dispatch mode FSP-S contains DXE drivers to be dispatched by boot loader dispatcher. 0001-Intel/MinPlatformPkg: Report FSP-S to DXE dispatcher 0002-KabylakeOpenBoardPkg: Skip FspWrapperNotifyDxe Cc: Michael Kubacki <michael.a.kubacki@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Liming Gao <liming.gao@intel.com> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com> Chasel, Chiu (2): Intel/MinPlatformPkg: Support DXE drivers in FSP 2.1. KabylakeOpenBoardPkg: Support DXE drivers in FSP 2.1. Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/FspWrapperHobProcessLib.c | 19 ++++++++++++++++--- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc | 6 +++++- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf | 9 +++++++-- Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/PeiFspWrapperHobProcessLib.inf | 5 ++++- 4 files changed, 32 insertions(+), 7 deletions(-) -- 2.13.3.windows.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] Intel/MinPlatformPkg: Support DXE drivers in FSP 2.1. 2019-06-04 0:52 [PATCH 0/2] Support DXE drivers in FSP 2.1 Chiu, Chasel @ 2019-06-04 0:52 ` Chiu, Chasel 2019-06-06 9:53 ` Nate DeSimone 2019-06-04 0:52 ` [PATCH 2/2] KabylakeOpenBoardPkg: " Chiu, Chasel 1 sibling, 1 reply; 6+ messages in thread From: Chiu, Chasel @ 2019-06-04 0:52 UTC (permalink / raw) To: devel; +Cc: Chasel, Chiu, Michael Kubacki, Nate DeSimone, Liming Gao From: "Chasel, Chiu" <chasel.chiu@intel.com> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1873 In dispatch mode FSP-S contains DXE drivers so needs to BuildFvHob for DXE dispatcher to dispatch this FV. Test: FSP API mode still boots successfully without impact. Cc: Michael Kubacki <michael.a.kubacki@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Liming Gao <liming.gao@intel.com> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com> --- Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/FspWrapperHobProcessLib.c | 19 ++++++++++++++++--- Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/PeiFspWrapperHobProcessLib.inf | 5 ++++- 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/FspWrapperHobProcessLib.c b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/FspWrapperHobProcessLib.c index e8df06dfb7..7ee4d3a31c 100644 --- a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/FspWrapperHobProcessLib.c +++ b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/FspWrapperHobProcessLib.c @@ -1,7 +1,7 @@ /** @file Provide FSP wrapper hob process related function. -Copyright (c) 2017, Intel Corporation. All rights reserved.<BR> +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR> SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -653,8 +653,21 @@ PostFspsHobProcess ( { EFI_STATUS Status; - ProcessFspHobList (FspHobList); - + if (PcdGet8 (PcdFspModeSelection) == 1) { + // + // Only in FSP API mode the wrapper has to build hobs basing on FSP output data. + // + ASSERT (FspHobList != NULL); + ProcessFspHobList (FspHobList); + } else { + // + // Only in FSP Dispatch mode, FSP-S should be reported to DXE dispatcher. + // + BuildFvHob ( + (EFI_PHYSICAL_ADDRESS) (UINTN) PcdGet32 (PcdFlashFvFspSBase), + PcdGet32 (PcdFlashFvFspSSize) + ); + } CheckFspGraphicsDeviceInfoHob (); DEBUG_CODE_BEGIN (); DumpFspSmbiosMemoryInfoHob (); diff --git a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/PeiFspWrapperHobProcessLib.inf b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/PeiFspWrapperHobProcessLib.inf index a76e3195d6..64f3302959 100644 --- a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/PeiFspWrapperHobProcessLib.inf +++ b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/PeiFspWrapperHobProcessLib.inf @@ -1,7 +1,7 @@ ## @file # Provide FSP wrapper hob process related function. # -# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR> +# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR> # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -65,6 +65,9 @@ gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress gMinPlatformPkgTokenSpaceGuid.PcdPciExpressRegionLength gMinPlatformPkgTokenSpaceGuid.PcdFspCpuPeiApWakeupBufferAddr + gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection + gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSBase + gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSSize [Guids] gFspReservedMemoryResourceHobGuid ## CONSUMES ## HOB -- 2.13.3.windows.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] Intel/MinPlatformPkg: Support DXE drivers in FSP 2.1. 2019-06-04 0:52 ` [PATCH 1/2] Intel/MinPlatformPkg: " Chiu, Chasel @ 2019-06-06 9:53 ` Nate DeSimone 2019-06-11 1:26 ` Chiu, Chasel 0 siblings, 1 reply; 6+ messages in thread From: Nate DeSimone @ 2019-06-06 9:53 UTC (permalink / raw) To: Chiu, Chasel, devel@edk2.groups.io; +Cc: Kubacki, Michael A, Gao, Liming The FSP specification allows FSP-S to contain an arbitrary number of Firmware Volumes. Your attached patch makes the assumption that it only contains one. I'm OK if you decide to commit this as-is for now since it is better than nothing, but I expect a Bugzilla to be filed to fix the 1 FV assumption. Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com> -----Original Message----- From: Chiu, Chasel Sent: Monday, June 3, 2019 5:53 PM To: devel@edk2.groups.io Cc: Chiu, Chasel <chasel.chiu@intel.com>; Kubacki, Michael A <michael.a.kubacki@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <liming.gao@intel.com> Subject: [PATCH 1/2] Intel/MinPlatformPkg: Support DXE drivers in FSP 2.1. From: "Chasel, Chiu" <chasel.chiu@intel.com> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1873 In dispatch mode FSP-S contains DXE drivers so needs to BuildFvHob for DXE dispatcher to dispatch this FV. Test: FSP API mode still boots successfully without impact. Cc: Michael Kubacki <michael.a.kubacki@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Liming Gao <liming.gao@intel.com> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com> --- Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/FspWrapperHobProcessLib.c | 19 ++++++++++++++++--- Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/PeiFspWrapperHobProcessLib.inf | 5 ++++- 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/FspWrapperHobProcessLib.c b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/FspWrapperHobProcessLib.c index e8df06dfb7..7ee4d3a31c 100644 --- a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/FspWrapperHobProcessLib.c +++ b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobP +++ rocessLib/FspWrapperHobProcessLib.c @@ -1,7 +1,7 @@ /** @file Provide FSP wrapper hob process related function. -Copyright (c) 2017, Intel Corporation. All rights reserved.<BR> +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR> SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -653,8 +653,21 @@ PostFspsHobProcess ( { EFI_STATUS Status; - ProcessFspHobList (FspHobList); - + if (PcdGet8 (PcdFspModeSelection) == 1) { + // + // Only in FSP API mode the wrapper has to build hobs basing on FSP output data. + // + ASSERT (FspHobList != NULL); + ProcessFspHobList (FspHobList); + } else { + // + // Only in FSP Dispatch mode, FSP-S should be reported to DXE dispatcher. + // + BuildFvHob ( + (EFI_PHYSICAL_ADDRESS) (UINTN) PcdGet32 (PcdFlashFvFspSBase), + PcdGet32 (PcdFlashFvFspSSize) + ); + } CheckFspGraphicsDeviceInfoHob (); DEBUG_CODE_BEGIN (); DumpFspSmbiosMemoryInfoHob (); diff --git a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/PeiFspWrapperHobProcessLib.inf b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/PeiFspWrapperHobProcessLib.inf index a76e3195d6..64f3302959 100644 --- a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/PeiFspWrapperHobProcessLib.inf +++ b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobP +++ rocessLib/PeiFspWrapperHobProcessLib.inf @@ -1,7 +1,7 @@ ## @file # Provide FSP wrapper hob process related function. # -# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR> +# Copyright (c) 2017 - 2019, Intel Corporation. All rights +reserved.<BR> # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -65,6 +65,9 @@ gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress gMinPlatformPkgTokenSpaceGuid.PcdPciExpressRegionLength gMinPlatformPkgTokenSpaceGuid.PcdFspCpuPeiApWakeupBufferAddr + gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection + gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSBase + gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSSize [Guids] gFspReservedMemoryResourceHobGuid ## CONSUMES ## HOB -- 2.13.3.windows.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] Intel/MinPlatformPkg: Support DXE drivers in FSP 2.1. 2019-06-06 9:53 ` Nate DeSimone @ 2019-06-11 1:26 ` Chiu, Chasel 0 siblings, 0 replies; 6+ messages in thread From: Chiu, Chasel @ 2019-06-11 1:26 UTC (permalink / raw) To: Desimone, Nathaniel L, devel@edk2.groups.io Cc: Kubacki, Michael A, Gao, Liming Agreed. Bugzilla filed for enhancement: https://bugzilla.tianocore.org/show_bug.cgi?id=1892 Thanks! Chasel > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Thursday, June 6, 2019 5:54 PM > To: Chiu, Chasel <chasel.chiu@intel.com>; devel@edk2.groups.io > Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Gao, Liming > <liming.gao@intel.com> > Subject: RE: [PATCH 1/2] Intel/MinPlatformPkg: Support DXE drivers in FSP 2.1. > > The FSP specification allows FSP-S to contain an arbitrary number of Firmware > Volumes. Your attached patch makes the assumption that it only contains one. > I'm OK if you decide to commit this as-is for now since it is better than nothing, > but I expect a Bugzilla to be filed to fix the 1 FV assumption. > > Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com> > > -----Original Message----- > From: Chiu, Chasel > Sent: Monday, June 3, 2019 5:53 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel <chasel.chiu@intel.com>; Kubacki, Michael A > <michael.a.kubacki@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desimone@intel.com>; Gao, Liming <liming.gao@intel.com> > Subject: [PATCH 1/2] Intel/MinPlatformPkg: Support DXE drivers in FSP 2.1. > > From: "Chasel, Chiu" <chasel.chiu@intel.com> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1873 > > In dispatch mode FSP-S contains DXE drivers so needs to BuildFvHob for DXE > dispatcher to dispatch this FV. > > Test: FSP API mode still boots successfully without impact. > > Cc: Michael Kubacki <michael.a.kubacki@intel.com> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > Cc: Liming Gao <liming.gao@intel.com> > Signed-off-by: Chasel Chiu <chasel.chiu@intel.com> > --- > > Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProce > ssLib/FspWrapperHobProcessLib.c | 19 ++++++++++++++++--- > > Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProce > ssLib/PeiFspWrapperHobProcessLib.inf | 5 ++++- > 2 files changed, 20 insertions(+), 4 deletions(-) > > diff --git > a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobPro > cessLib/FspWrapperHobProcessLib.c > b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobPro > cessLib/FspWrapperHobProcessLib.c > index e8df06dfb7..7ee4d3a31c 100644 > --- > a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobPro > cessLib/FspWrapperHobProcessLib.c > +++ > b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobP > +++ rocessLib/FspWrapperHobProcessLib.c > @@ -1,7 +1,7 @@ > /** @file > Provide FSP wrapper hob process related function. > > -Copyright (c) 2017, Intel Corporation. All rights reserved.<BR> > +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -653,8 +653,21 @@ PostFspsHobProcess ( { > EFI_STATUS Status; > > - ProcessFspHobList (FspHobList); > - > + if (PcdGet8 (PcdFspModeSelection) == 1) { > + // > + // Only in FSP API mode the wrapper has to build hobs basing on FSP output > data. > + // > + ASSERT (FspHobList != NULL); > + ProcessFspHobList (FspHobList); > + } else { > + // > + // Only in FSP Dispatch mode, FSP-S should be reported to DXE dispatcher. > + // > + BuildFvHob ( > + (EFI_PHYSICAL_ADDRESS) (UINTN) PcdGet32 (PcdFlashFvFspSBase), > + PcdGet32 (PcdFlashFvFspSSize) > + ); > + } > CheckFspGraphicsDeviceInfoHob (); > DEBUG_CODE_BEGIN (); > DumpFspSmbiosMemoryInfoHob (); > diff --git > a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobPro > cessLib/PeiFspWrapperHobProcessLib.inf > b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobPro > cessLib/PeiFspWrapperHobProcessLib.inf > index a76e3195d6..64f3302959 100644 > --- > a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobPro > cessLib/PeiFspWrapperHobProcessLib.inf > +++ > b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobP > +++ rocessLib/PeiFspWrapperHobProcessLib.inf > @@ -1,7 +1,7 @@ > ## @file > # Provide FSP wrapper hob process related function. > # > -# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR> > +# Copyright (c) 2017 - 2019, Intel Corporation. All rights > +reserved.<BR> > # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -65,6 +65,9 @@ > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress > gMinPlatformPkgTokenSpaceGuid.PcdPciExpressRegionLength > gMinPlatformPkgTokenSpaceGuid.PcdFspCpuPeiApWakeupBufferAddr > + gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection > + gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSBase > + gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSSize > > [Guids] > gFspReservedMemoryResourceHobGuid ## CONSUMES ## > HOB > -- > 2.13.3.windows.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] KabylakeOpenBoardPkg: Support DXE drivers in FSP 2.1. 2019-06-04 0:52 [PATCH 0/2] Support DXE drivers in FSP 2.1 Chiu, Chasel 2019-06-04 0:52 ` [PATCH 1/2] Intel/MinPlatformPkg: " Chiu, Chasel @ 2019-06-04 0:52 ` Chiu, Chasel 2019-06-06 9:53 ` Nate DeSimone 1 sibling, 1 reply; 6+ messages in thread From: Chiu, Chasel @ 2019-06-04 0:52 UTC (permalink / raw) To: devel; +Cc: Chasel, Chiu, Michael Kubacki, Nate DeSimone, Liming Gao From: "Chasel, Chiu" <chasel.chiu@intel.com> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1873 In dispatch mode since FSP DXE drivers will be dispatched directly by boot loader dispatcher, FspWrapperNotifyDxe driver should be skipped. Test: FSP API mode still boots successfully without impact. Cc: Michael Kubacki <michael.a.kubacki@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Liming Gao <liming.gao@intel.com> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com> --- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc | 6 +++++- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf | 9 +++++++-- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc index 1dfe49a7ad..653e17c8e4 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc @@ -329,8 +329,12 @@ # $(PLATFORM_PACKAGE)/PlatformInit/SiliconPolicyDxe/SiliconPolicyDxe.inf $(PLATFORM_PACKAGE)/PlatformInit/PlatformInitDxe/PlatformInitDxe.inf +!if gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection == 1 + # + # Below module is used by FSP API mode + # IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf - +!endif $(PLATFORM_PACKAGE)/FspWrapper/SaveMemoryConfig/SaveMemoryConfig.inf $(PLATFORM_PACKAGE)/Test/TestPointStubDxe/TestPointStubDxe.inf diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf index 0cff53e308..24dc29c129 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf @@ -1,7 +1,7 @@ ## @file # FDF file of Platform. # -# Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR> +# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR> # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -332,7 +332,12 @@ INF MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDxe.inf INF ShellPkg/Application/Shell/Shell.inf INF $(PLATFORM_PACKAGE)/PlatformInit/PlatformInitDxe/PlatformInitDxe.inf -INF IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf +!if gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection == 1 + # + # Below module is used by FSP API mode + # + INF IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf +!endif INF $(PLATFORM_PACKAGE)/Test/TestPointStubDxe/TestPointStubDxe.inf -- 2.13.3.windows.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] KabylakeOpenBoardPkg: Support DXE drivers in FSP 2.1. 2019-06-04 0:52 ` [PATCH 2/2] KabylakeOpenBoardPkg: " Chiu, Chasel @ 2019-06-06 9:53 ` Nate DeSimone 0 siblings, 0 replies; 6+ messages in thread From: Nate DeSimone @ 2019-06-06 9:53 UTC (permalink / raw) To: Chiu, Chasel, devel@edk2.groups.io; +Cc: Kubacki, Michael A, Gao, Liming Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com> -----Original Message----- From: Chiu, Chasel Sent: Monday, June 3, 2019 5:53 PM To: devel@edk2.groups.io Cc: Chiu, Chasel <chasel.chiu@intel.com>; Kubacki, Michael A <michael.a.kubacki@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <liming.gao@intel.com> Subject: [PATCH 2/2] KabylakeOpenBoardPkg: Support DXE drivers in FSP 2.1. From: "Chasel, Chiu" <chasel.chiu@intel.com> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1873 In dispatch mode since FSP DXE drivers will be dispatched directly by boot loader dispatcher, FspWrapperNotifyDxe driver should be skipped. Test: FSP API mode still boots successfully without impact. Cc: Michael Kubacki <michael.a.kubacki@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Liming Gao <liming.gao@intel.com> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com> --- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc | 6 +++++- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf | 9 +++++++-- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc index 1dfe49a7ad..653e17c8e4 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc @@ -329,8 +329,12 @@ # $(PLATFORM_PACKAGE)/PlatformInit/SiliconPolicyDxe/SiliconPolicyDxe.inf $(PLATFORM_PACKAGE)/PlatformInit/PlatformInitDxe/PlatformInitDxe.inf +!if gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection == 1 + # + # Below module is used by FSP API mode + # IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf - +!endif $(PLATFORM_PACKAGE)/FspWrapper/SaveMemoryConfig/SaveMemoryConfig.inf $(PLATFORM_PACKAGE)/Test/TestPointStubDxe/TestPointStubDxe.inf diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf index 0cff53e308..24dc29c129 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf @@ -1,7 +1,7 @@ ## @file # FDF file of Platform. # -# Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR> +# Copyright (c) 2017 - 2019, Intel Corporation. All rights +reserved.<BR> # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -332,7 +332,12 @@ INF MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDxe.inf INF ShellPkg/Application/Shell/Shell.inf INF $(PLATFORM_PACKAGE)/PlatformInit/PlatformInitDxe/PlatformInitDxe.inf -INF IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf +!if gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection == 1 + # + # Below module is used by FSP API mode + # + INF IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf +!endif INF $(PLATFORM_PACKAGE)/Test/TestPointStubDxe/TestPointStubDxe.inf -- 2.13.3.windows.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-06-11 1:26 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-06-04 0:52 [PATCH 0/2] Support DXE drivers in FSP 2.1 Chiu, Chasel 2019-06-04 0:52 ` [PATCH 1/2] Intel/MinPlatformPkg: " Chiu, Chasel 2019-06-06 9:53 ` Nate DeSimone 2019-06-11 1:26 ` Chiu, Chasel 2019-06-04 0:52 ` [PATCH 2/2] KabylakeOpenBoardPkg: " Chiu, Chasel 2019-06-06 9:53 ` Nate DeSimone
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox