public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "Chiu, Chasel" <chasel.chiu@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kubacki, Michael A" <michael.a.kubacki@intel.com>,
	"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH 1/2] Platform/Intel: Switch to FSP Dispatch mode.
Date: Thu, 6 Jun 2019 09:57:45 +0000	[thread overview]
Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEBD5EE5@ORSMSX114.amr.corp.intel.com> (raw)
In-Reply-To: <20190604030359.4296-2-chasel.chiu@intel.com>

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: Chiu, Chasel 
Sent: Monday, June 3, 2019 8:04 PM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: [PATCH 1/2] Platform/Intel: Switch to FSP Dispatch mode.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1874

Build configuration is updated to support different *FspBinPkg between FSP wrapper API and Dispatch modes.

Default will be Dispatch mode and to build FSP wrapper for API mode:
"py -2 build_bios.py --platform KabylakeRvp3 --fspapi"

Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
---
 Platform/Intel/build_bios.py | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/Platform/Intel/build_bios.py b/Platform/Intel/build_bios.py index 9f8d78f6e8..09eceddeff 100644
--- a/Platform/Intel/build_bios.py
+++ b/Platform/Intel/build_bios.py
@@ -125,6 +125,16 @@ def pre_build(build_config, build_type="DEBUG", silent=False, toolchain=None):
     config["BASE_TOOLS_PATH"] = config["EDK_TOOLS_PATH"]
     config["EDK_TOOLS_BIN"] = os.path.join(config["WORKSPACE"],
                                            config["EDK_TOOLS_BIN"])
+
+    #
+    # Board may have different FSP binary between API and Dispatch modes.
+    # In API mode if FSP_BIN_PKG_FOR_API_MODE is assigned, it should
+    # override FSP_BIN_PKG.
+    #
+    if config.get("API_MODE_FSP_WRAPPER_BUILD", "FALSE") == "TRUE":
+        if config.get("FSP_BIN_PKG_FOR_API_MODE") is not None:
+            config['FSP_BIN_PKG'] = config['FSP_BIN_PKG_FOR_API_MODE']
+
     config["PLATFORM_FSP_BIN_PACKAGE"] = \
         os.path.join(config['WORKSPACE_FSP_BIN'], config['FSP_BIN_PKG'])
     config['PROJECT_DSC'] = os.path.join(config["WORKSPACE_PLATFORM"],
--
2.13.3.windows.1


  reply	other threads:[~2019-06-06  9:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-04  3:03 [PATCH 0/2] Switch to FSP Dispatch mode Chiu, Chasel
2019-06-04  3:03 ` [PATCH 1/2] Platform/Intel: " Chiu, Chasel
2019-06-06  9:57   ` Nate DeSimone [this message]
2019-06-04  3:03 ` [PATCH 2/2] KabylakeOpenBoardPkg: " Chiu, Chasel
2019-06-06  9:57   ` Nate DeSimone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02A34F284D1DA44BB705E61F7180EF0AAEBD5EE5@ORSMSX114.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox