From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: nathaniel.l.desimone@intel.com) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Thu, 06 Jun 2019 02:57:51 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jun 2019 02:57:50 -0700 X-ExtLoop1: 1 Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga004.jf.intel.com with ESMTP; 06 Jun 2019 02:57:46 -0700 Received: from orsmsx160.amr.corp.intel.com (10.22.226.43) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 6 Jun 2019 02:57:46 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.116]) by ORSMSX160.amr.corp.intel.com ([169.254.13.124]) with mapi id 14.03.0415.000; Thu, 6 Jun 2019 02:57:46 -0700 From: "Nate DeSimone" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: "Kubacki, Michael A" , "Gao, Liming" Subject: Re: [PATCH 1/2] Platform/Intel: Switch to FSP Dispatch mode. Thread-Topic: [PATCH 1/2] Platform/Intel: Switch to FSP Dispatch mode. Thread-Index: AQHVGoIw0msj0jQr5EKYQXMYchxwnaaOZpOg Date: Thu, 6 Jun 2019 09:57:45 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEBD5EE5@ORSMSX114.amr.corp.intel.com> References: <20190604030359.4296-1-chasel.chiu@intel.com> <20190604030359.4296-2-chasel.chiu@intel.com> In-Reply-To: <20190604030359.4296-2-chasel.chiu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzJlZWJiYWUtN2MyZi00OWU3LTgzYTUtOWFmMDAwOWI3YzAxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibFcwY1VkMnJId3RzSE03ZXdabDRFYW9jT0lMbXVWNmdZMHR0SlBzYlo3SVdNZGRhUGVzRHVXQ2F2VjkxM1NsUiJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: Chiu, Chasel=20 Sent: Monday, June 3, 2019 8:04 PM To: devel@edk2.groups.io Cc: Kubacki, Michael A ; Desimone, Nathaniel L= ; Gao, Liming Subject: [PATCH 1/2] Platform/Intel: Switch to FSP Dispatch mode. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1874 Build configuration is updated to support different *FspBinPkg between FSP = wrapper API and Dispatch modes. Default will be Dispatch mode and to build FSP wrapper for API mode: "py -2 build_bios.py --platform KabylakeRvp3 --fspapi" Cc: Michael Kubacki Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Chasel Chiu --- Platform/Intel/build_bios.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/Platform/Intel/build_bios.py b/Platform/Intel/build_bios.py in= dex 9f8d78f6e8..09eceddeff 100644 --- a/Platform/Intel/build_bios.py +++ b/Platform/Intel/build_bios.py @@ -125,6 +125,16 @@ def pre_build(build_config, build_type=3D"DEBUG", sile= nt=3DFalse, toolchain=3DNone): config["BASE_TOOLS_PATH"] =3D config["EDK_TOOLS_PATH"] config["EDK_TOOLS_BIN"] =3D os.path.join(config["WORKSPACE"], config["EDK_TOOLS_BIN"]) + + # + # Board may have different FSP binary between API and Dispatch modes. + # In API mode if FSP_BIN_PKG_FOR_API_MODE is assigned, it should + # override FSP_BIN_PKG. + # + if config.get("API_MODE_FSP_WRAPPER_BUILD", "FALSE") =3D=3D "TRUE": + if config.get("FSP_BIN_PKG_FOR_API_MODE") is not None: + config['FSP_BIN_PKG'] =3D config['FSP_BIN_PKG_FOR_API_MODE'] + config["PLATFORM_FSP_BIN_PACKAGE"] =3D \ os.path.join(config['WORKSPACE_FSP_BIN'], config['FSP_BIN_PKG']) config['PROJECT_DSC'] =3D os.path.join(config["WORKSPACE_PLATFORM"], -- 2.13.3.windows.1