From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=fail (domain: intel.com, ip: , mailfrom: nathaniel.l.desimone@intel.com) Received: from mga09.intel.com (mga09.intel.com []) by groups.io with SMTP; Thu, 06 Jun 2019 02:57:51 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jun 2019 02:57:50 -0700 X-ExtLoop1: 1 Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga004.jf.intel.com with ESMTP; 06 Jun 2019 02:57:50 -0700 Received: from orsmsx151.amr.corp.intel.com (10.22.226.38) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 6 Jun 2019 02:57:49 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.116]) by ORSMSX151.amr.corp.intel.com ([169.254.7.242]) with mapi id 14.03.0415.000; Thu, 6 Jun 2019 02:57:49 -0700 From: "Nate DeSimone" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: "Kubacki, Michael A" , "Gao, Liming" Subject: Re: [PATCH 2/2] KabylakeOpenBoardPkg: Switch to FSP Dispatch mode. Thread-Topic: [PATCH 2/2] KabylakeOpenBoardPkg: Switch to FSP Dispatch mode. Thread-Index: AQHVGoIyWMlualPdOU+GjT1iPXuSTKaOZpzw Date: Thu, 6 Jun 2019 09:57:49 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEBD5EFE@ORSMSX114.amr.corp.intel.com> References: <20190604030359.4296-1-chasel.chiu@intel.com> <20190604030359.4296-3-chasel.chiu@intel.com> In-Reply-To: <20190604030359.4296-3-chasel.chiu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDE2OWFhNzYtZWI3Yi00OWQ5LWI4OWQtMGM0NTM4YTFhYWUwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieFd4WUY0VVwvVThIWmFHbU9pMCthTU1janU1SW82bjVNU0V2ZjE1NGtzTVd2XC9jU1ZidEZmM2hpMjJyVTZzblNNIn0= x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: Chiu, Chasel=20 Sent: Monday, June 3, 2019 8:04 PM To: devel@edk2.groups.io Cc: Kubacki, Michael A ; Desimone, Nathaniel L= ; Gao, Liming Subject: [PATCH 2/2] KabylakeOpenBoardPkg: Switch to FSP Dispatch mode. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1874 Now KabylakeOpenBoardPkg is building in FSP Dispatch mode as default. Test: Both FSP API and Dispatch mode can boot to Windows. Cc: Michael Kubacki Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Chasel Chiu --- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc | 2 += - Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg | 5 += ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgP= cd.dsc b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.d= sc index 63d0c4c2e6..81244d7216 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.d +++ sc @@ -32,7 +32,7 @@ # 0: FSP Wrapper is running in Dispatch mode. # 1: FSP Wrapper is running in API mode. # - gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection|1 + gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection|0 =20 !if gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable =3D=3D TRUE gEfiMdePkgTokenSpaceGuid.PcdPerformanceLibraryPropertyMask|0x1 diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.= cfg b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg index 64e02f7f48..bf89ea399c 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg @@ -27,8 +27,9 @@ TARGET =3D DEBUG TARGET_SHORT =3D D PERFORMANCE_BUILD =3D FALSE FSP_WRAPPER_BUILD =3D TRUE -FSP_BIN_PKG =3D KabylakeFspBinPkg -FSP_PKG_NAME =3D KabylakeFspPkg +FSP_BIN_PKG =3D AmberLakeFspBinPkg +FSP_BIN_PKG_FOR_API_MODE =3D KabylakeFspBinPkg FSP_PKG_NAME =3D=20 +AmberLakeFspPkg FSP_BINARY_BUILD =3D FALSE FSP_TEST_RELEASE =3D FALSE SECURE_BOOT_ENABLE =3D FALSE -- 2.13.3.windows.1