From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: nathaniel.l.desimone@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Tue, 11 Jun 2019 21:28:34 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jun 2019 21:28:34 -0700 X-ExtLoop1: 1 Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by FMSMGA003.fm.intel.com with ESMTP; 11 Jun 2019 21:28:34 -0700 Received: from orsmsx121.amr.corp.intel.com (10.22.225.226) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 11 Jun 2019 21:28:33 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.154]) by ORSMSX121.amr.corp.intel.com ([169.254.10.133]) with mapi id 14.03.0415.000; Tue, 11 Jun 2019 21:28:33 -0700 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Chiu, Chasel" CC: "Kubacki, Michael A" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH 1/2] Platform/Intel: Update Kabylake build steps. Thread-Topic: [edk2-devel] [PATCH 1/2] Platform/Intel: Update Kabylake build steps. Thread-Index: AQHVIM8Jmk1ukqbXQkqVzBkCUEKeSKaXbJbg Date: Wed, 12 Jun 2019 04:28:32 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEC189A7@ORSMSX114.amr.corp.intel.com> References: <20190612032912.5336-1-chasel.chiu@intel.com> <20190612032912.5336-2-chasel.chiu@intel.com> In-Reply-To: <20190612032912.5336-2-chasel.chiu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjRhOGJlYWYtMzc2ZS00YjNkLTgwMWYtMTI4MzUyODkyYjkyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMkx6cE5lZHhGZFlEcXdWOGhtR3ZlMVlNSlJwaXFGVjR5M1wvK2doZjg4NUJDMG83VTRXc3liM0RvK0ZCK2dxeXcifQ== x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable It's good that we have the Python 2.x dependency documented for KabyLakeOpe= nBoardPkg now, but we really need to migrate it to Python 3.x since securit= y updates for Python 2.x will be ending soon. Reviewed-by: Nate DeSimone -----Original Message----- From: devel@edk2.groups.io On Behalf Of Chiu, Chase= l Sent: Tuesday, June 11, 2019 8:29 PM To: devel@edk2.groups.io Cc: Kubacki, Michael A ; Desimone, Nathaniel = L ; Gao, Liming Subject: [edk2-devel] [PATCH 1/2] Platform/Intel: Update Kabylake build st= eps. https://bugzilla.tianocore.org/show_bug.cgi?id=3D1905 KabylakeOpenBoardPkg no longer supported batch file build, it only support= s build_bios.py. ReadMe.md should be updated and batch files should be removed. Test: both API mode and Dispatch mode can build successfully by build_bios.py Cc: Michael Kubacki Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Chasel Chiu --- Platform/Intel/Readme.md | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md index 443= fb409b3..cc0151066e 100644 --- a/Platform/Intel/Readme.md +++ b/Platform/Intel/Readme.md @@ -101,7 +101,7 @@ return back to the minimum platform caller. * ``git clone https://github.com/tianocore/edk2-non-osi.git -b devel-Mi= nPlatform`` =20 * FSP repository - * ``git clone https://github.com/IntelFsp/FSP.git -b Kabylake`` + * ``git clone https://github.com/IntelFsp/FSP.git`` =20 ### Build =20 @@ -132,7 +132,8 @@ return back to the minimum platform caller. | --capsule | capsule build enabled | | --silent | silent build enabled | | --performance | performance build enabled | - | --fsp | fsp build enabled | + | --fsp | fsp wrapper build enabled | + | --fspapi | API mode fsp wrapper build enabled | | | =20 * For more information on build options @@ -140,6 +141,8 @@ return back t= o the minimum platform caller. =20 * Note * Python 2.7.16 and Python 3.7.3 compatible + * Some dependency Python scripts might only support 2.x or 3.x, if that= happened use + "py -2" or "py -3" to launch build_bios.py * This python build script has been tested on Windows 10 and Ubuntu 16.= 04.5 LTS * See [cross-platform limitations](#Known-limitations) =20 @@ -186,12 +189,7 @@ return back to the minimum platform caller. =20 **Building with the batch scripts** -For KabylakeOpenBoardPkg -1. Open command window, go to the workspace directory, e.g. c:\Kabylake. -2. Type "cd edk2-platforms\Platform\Intel\KabylakeOpenBoardPkg\KabylakeRv= p3". -3. Type "GitEdk2MinKabylake.bat" to setup GIT environment. -4. Type "prep" and make prebuild finish for debug build, "prep r" for rel= ease build. -5. Type "bld" to build Kaby Lake reference platform UEFI firmware image. +KabylakeOpenBoardPkg does not support batch scripts, please use build_bio= s.py. =20 For PurleyOpenBoardPkg 1. Open command window, go to the workspace directory, e.g. c:\Purley. -- 2.13.3.windows.1