From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "Chiu, Chasel" <chasel.chiu@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kubacki, Michael A" <michael.a.kubacki@intel.com>,
"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH] KabylakeOpenBoardPkg: Remove PeiMain for Dispatch mode.
Date: Thu, 20 Jun 2019 03:32:18 +0000 [thread overview]
Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEC6FE1D@ORSMSX114.amr.corp.intel.com> (raw)
In-Reply-To: <20190614082449.17680-1-chasel.chiu@intel.com>
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
-----Original Message-----
From: Chiu, Chasel
Sent: Friday, June 14, 2019 1:25 AM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: [PATCH] KabylakeOpenBoardPkg: Remove PeiMain for Dispatch mode.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1916
In Dispatch mode PeiMain from FSP Binary will be launched so the one from boot loader can be removed.
Test: Verified the PeiMain is removed in Dispatch mode
and included in API mode.
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
---
Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf
index 007cb4b28f..abafd8e44d 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf
+++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf
@@ -226,7 +226,13 @@ READ_LOCK_STATUS = TRUE
FvNameGuid = FC8FE6B5-CD9B-411E-BD8F-31824D0CDE3D
INF UefiCpuPkg/SecCore/SecCore.inf
+!if (gMinPlatformPkgTokenSpaceGuid.PcdFspWrapperBootMode == FALSE) ||
+(gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection == 1) # # PeiMain
+is needed only for FSP API mode or EDK2 build, # in FSP dispatch mode
+the one inside FSP Binary is launched.
+#
INF MdeModulePkg/Core/Pei/PeiMain.inf
+!endif
!include $(PLATFORM_PACKAGE)/Include/Fdf/CorePreMemoryInclude.fdf
INF $(PLATFORM_PACKAGE)/PlatformInit/ReportFv/ReportFvPei.inf
--
2.13.3.windows.1
prev parent reply other threads:[~2019-06-20 3:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 8:24 [PATCH] KabylakeOpenBoardPkg: Remove PeiMain for Dispatch mode Chiu, Chasel
2019-06-20 3:32 ` Nate DeSimone [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02A34F284D1DA44BB705E61F7180EF0AAEC6FE1D@ORSMSX114.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox