From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: nathaniel.l.desimone@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by groups.io with SMTP; Wed, 19 Jun 2019 20:32:20 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jun 2019 20:32:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,395,1557212400"; d="scan'208";a="162219321" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by fmsmga007.fm.intel.com with ESMTP; 19 Jun 2019 20:32:19 -0700 Received: from orsmsx163.amr.corp.intel.com (10.22.240.88) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 19 Jun 2019 20:32:19 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.32]) by ORSMSX163.amr.corp.intel.com ([169.254.9.84]) with mapi id 14.03.0439.000; Wed, 19 Jun 2019 20:32:19 -0700 From: "Nate DeSimone" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: "Kubacki, Michael A" , "Gao, Liming" Subject: Re: [PATCH] KabylakeOpenBoardPkg: Remove PeiMain for Dispatch mode. Thread-Topic: [PATCH] KabylakeOpenBoardPkg: Remove PeiMain for Dispatch mode. Thread-Index: AQHVIorTtU9cGokqlkuR/mu+km60raaj6yaA Date: Thu, 20 Jun 2019 03:32:18 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEC6FE1D@ORSMSX114.amr.corp.intel.com> References: <20190614082449.17680-1-chasel.chiu@intel.com> In-Reply-To: <20190614082449.17680-1-chasel.chiu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjZlNWZkMTAtNTAyOC00MGQ0LWI4YjktZGE2NDFhYzE2ODIwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoialZCTFNHSU5LUFhMczdPMnBEQ2k3N1FtS0k0VU43a0ltemJ3eGFOUUdXOTNKN3dYc2FaK2ZlalVuODRmdjFLOSJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: Chiu, Chasel=20 Sent: Friday, June 14, 2019 1:25 AM To: devel@edk2.groups.io Cc: Kubacki, Michael A ; Desimone, Nathaniel L= ; Gao, Liming Subject: [PATCH] KabylakeOpenBoardPkg: Remove PeiMain for Dispatch mode. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1916 In Dispatch mode PeiMain from FSP Binary will be launched so the one from b= oot loader can be removed. Test: Verified the PeiMain is removed in Dispatch mode and included in API mode. Cc: Michael Kubacki Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Chasel Chiu --- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf | 6 ++++= ++ 1 file changed, 6 insertions(+) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.= fdf b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf index 007cb4b28f..abafd8e44d 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf @@ -226,7 +226,13 @@ READ_LOCK_STATUS =3D TRUE FvNameGuid =3D FC8FE6B5-CD9B-411E-BD8F-31824D0CDE3D =20 INF UefiCpuPkg/SecCore/SecCore.inf +!if (gMinPlatformPkgTokenSpaceGuid.PcdFspWrapperBootMode =3D=3D FALSE) ||= =20 +(gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection =3D=3D 1) # # PeiMain= =20 +is needed only for FSP API mode or EDK2 build, # in FSP dispatch mode=20 +the one inside FSP Binary is launched. +# INF MdeModulePkg/Core/Pei/PeiMain.inf +!endif !include $(PLATFORM_PACKAGE)/Include/Fdf/CorePreMemoryInclude.fdf =20 INF $(PLATFORM_PACKAGE)/PlatformInit/ReportFv/ReportFvPei.inf -- 2.13.3.windows.1