From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: nathaniel.l.desimone@intel.com) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Tue, 30 Jul 2019 14:41:38 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jul 2019 14:41:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,327,1559545200"; d="scan'208";a="166110557" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by orsmga008.jf.intel.com with ESMTP; 30 Jul 2019 14:41:37 -0700 Received: from orsmsx125.amr.corp.intel.com (10.22.240.125) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 30 Jul 2019 14:41:37 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.96]) by ORSMSX125.amr.corp.intel.com ([169.254.3.92]) with mapi id 14.03.0439.000; Tue, 30 Jul 2019 14:41:37 -0700 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Agyeman, Prince" CC: "Gao, Liming" , "Sinha, Ankit" , "Kubacki, Michael A" , "Chiu, Chasel" Subject: Re: [edk2-devel] [edk2-platforms] [PATCH] ClevoOpenBoardPkg: Add display support Thread-Topic: [edk2-devel] [edk2-platforms] [PATCH] ClevoOpenBoardPkg: Add display support Thread-Index: AQHVQ8hjF8yybbDlcUOJSCaA/qC4Pqbjt3jA Date: Tue, 30 Jul 2019 21:41:37 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAED95938@ORSMSX114.amr.corp.intel.com> References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzUwZTJkMTYtNTAyYS00ZGNkLTkzMzQtODM4NWI0NmE4ZTJkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaWpnMHMwdHgyMFhQZkd3S2JMTk9HZjJ1NTRTdHpnaW9qOWVvQlJJTWZrS1REeDN6bHpGRFNtVTJ3Y0xnRjIxaSJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: devel@edk2.groups.io On Behalf Of Agyeman, Pr= ince Sent: Friday, July 26, 2019 8:40 AM To: devel@edk2.groups.io Cc: Gao, Liming ; Sinha, Ankit ; Desimone, Nathaniel L ; Kubacki, Michae= l A ; Chiu, Chasel ; Ag= yeman, Prince Subject: [edk2-devel] [edk2-platforms] [PATCH] ClevoOpenBoardPkg: Add disp= lay support Added vbt and configured gpio to enable N1xxxW display. Cc: Liming Gao Cc: Ankit Sinha Cc: Nate DeSimone Cc: Michael Kubacki Cc: Chasel Chiu Signed-off-by: Prince Agyeman --- .../N1xxWU/Library/BoardInitLib/N1xxWUGpioTable.c | 2 +- Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf | 2 +- Platform/Intel/ClevoOpenBoardPkg/N1xxWU/build_config.cfg | 2 +- Platform/Intel/build_bios.py | 1 + 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardInitLib/= N1xxWUGpioTable.c b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardIn= itLib/N1xxWUGpioTable.c index 08a20673f0..d055fda8c3 100644 --- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardInitLib/N1xxWUG= pioTable.c +++ b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardInitLib/N1xxW +++ UGpioTable.c @@ -100,7 +100,7 @@ GPIO_INIT_CONFIG mGpioTableN1xxWU[] =3D {GPIO_SKL_LP_GPP_D5, {GpioPadModeNative1, GpioHostOwnGpio, GpioDirNone= , GpioOutDefault, GpioIntDis, GpioHostDeepReset, GpioTermNone}},//ISH_I2C= 0_SDA {GPIO_SKL_LP_GPP_D6, {GpioPadModeNative1, GpioHostOwnGpio, GpioDirNone= , GpioOutDefault, GpioIntDis, GpioHostDeepReset, GpioTermNone}},//ISH_I2C= 0_SCL {GPIO_SKL_LP_GPP_D7, {GpioPadModeNative1, GpioHostOwnGpio, GpioDirNone= , GpioOutDefault, GpioIntDis, GpioHostDeepReset, GpioTermNone}},//ISH_I2C= 1_SDA - {GPIO_SKL_LP_GPP_D8, {GpioPadModeNative1, GpioHostOwnGpio, GpioDirNone= , GpioOutDefault, GpioIntDis, GpioHostDeepReset, GpioTermNone}},//ISH_I2C= 1_SCL + {GPIO_SKL_LP_GPP_D8, {GpioPadModeGpio, GpioHostOwnGpio, GpioDirOut,= GpioOutHigh, GpioIntDis, GpioHostDeepReset, GpioTermNone}},//ISH_I2C= 1_SCL/SB_BLON {GPIO_SKL_LP_GPP_D9, {GpioPadModeGpio, GpioHostOwnGpio, GpioDirIn, = GpioOutDefault, GpioIntLevel | GpioIntDis, GpioHostDeepReset, GpioTermN= one}},//HOME_BTN {GPIO_SKL_LP_GPP_D10, {GpioPadModeGpio, GpioHostOwnGpio, GpioDirIn, = GpioOutDefault, GpioIntLevel | GpioIntDis, GpioHostDeepReset, GpioTermN= one}},//SCREEN_LOCK_PCH {GPIO_SKL_LP_GPP_D11, {GpioPadModeGpio, GpioHostOwnGpio, GpioDirIn, = GpioOutDefault, GpioIntLevel | GpioIntDis, GpioHostDeepReset, GpioTermN= one}},//VOL_UP_PCH diff --git a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf b/Pl= atform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf index da498ad379..9ebc81e933 100644 --- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf +++ b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf @@ -267,7 +267,7 @@ INF $(PLATFORM_PACKAGE)/PlatformInit/SiliconPolicyPei/= SiliconPolicyPeiPostMem.in =20 !if gSiPkgTokenSpaceGuid.PcdPeiDisplayEnable =3D=3D TRUE FILE FREEFORM = =3D 4ad46122-ffeb-4a52-bfb0-518cfca02db0 { - SECTION RAW =3D $(PLATFORM_FSP_BIN_PACKAGE)/SampleCode/Vbt/Vbt.bin + SECTION RAW =3D N1xxWU/Gop/Vbt.bin SECTION UI =3D "Vbt" } FILE FREEFORM =3D 7BB28B99-61BB-11D5-9A5D-0090273FC14D { diff --git a/Pla= tform/Intel/ClevoOpenBoardPkg/N1xxWU/build_config.cfg b/Platform/Intel/Clev= oOpenBoardPkg/N1xxWU/build_config.cfg index a423c8b497..3edc2b14e8 100644 --- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/build_config.cfg +++ b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/build_config.cfg @@ -7,7 +7,7 @@ =20 =20 [CONFIG] -WORKSPACE_PLATFORM_BIN =3D WORKSPACE_PLATFORM_BIN +WORKSPACE_PLATFORM_BIN =3D=20 +edk2-non-osi/Platform/Intel/ClevoOpenBoardBinPkg EDK_SETUP_OPTION =3D openssl_path =3D PLATFORM_BOARD_PACKAGE =3D ClevoOpenBoardPkg diff --git a/Platform/Intel/= build_bios.py b/Platform/Intel/build_bios.py index c01b953d16..beba4acebe 1= 00644 --- a/Platform/Intel/build_bios.py +++ b/Platform/Intel/build_bios.py @@ -120,6 +120,7 @@ def pre_build(build_config, build_type=3D"DEBUG", sile= nt=3DFalse, toolchain=3DNone): config["PACKAGES_PATH"] +=3D os.pathsep + \ os.path.join(config["WORKSPACE"], "edk2") config["PACKAGES_PATH"] +=3D os.pathsep + os.path.join(config["WORKSP= ACE"]) + config["PACKAGES_PATH"] +=3D os.pathsep +=20 + config["WORKSPACE_PLATFORM_BIN"] config["EDK_TOOLS_PATH"] =3D os.path.join(config["WORKSPACE"], config["EDK_TOOLS_PATH"]) config["BASE_TOOLS_PATH"] =3D config["EDK_TOOLS_PATH"] -- 2.19.1.windows.1