Re: [edk2-devel] [PATCH 2/4] Platform/Intel: Auto configure Fsp*BaseAddress PCD

["Nate DeSimone" <nathaniel.l.desimone@intel.com>]

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chiu, Chasel
Sent: Monday, July 29, 2019 4:07 AM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: [edk2-devel] [PATCH 2/4] Platform/Intel: Auto configure Fsp*BaseAddress PCD

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1863

Consume RebaseFspBinBaseAddress.py which will only rebase FSP binary without patching platform DSC.

Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
---
 Platform/Intel/build_bios.py | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/Platform/Intel/build_bios.py b/Platform/Intel/build_bios.py index c01b953d16..37b5ee2f5b 100644
--- a/Platform/Intel/build_bios.py
+++ b/Platform/Intel/build_bios.py
@@ -303,21 +303,18 @@ def build(config):
                    os.path.join(config['WORKSPACE_PLATFORM'],
                                 config['PLATFORM_PACKAGE'],
                                 'Tools', 'Fsp',
-                                'RebaseAndPatchFspBinBaseAddress.py'),
+                                'RebaseFspBinBaseAddress.py'),
                    os.path.join(config['WORKSPACE_PLATFORM'],
                                 config['FLASH_MAP_FDF']),
                    os.path.join(config['WORKSPACE_FSP_BIN'],
                                 config['FSP_BIN_PKG']),
                    "Fsp.fd",
-                   os.path.join(config['WORKSPACE_PLATFORM'],
-                                config['PROJECT'],
-                                config['BOARD_PKG_PCD_DSC']),
                    "0x0"]
 
         _, _, _, return_code = execute_script(command, config, shell=False)
 
         if return_code != 0:
-            print("ERROR:RebaseAndPatchFspBinBaseAddress failed")
+            print("ERROR:RebaseFspBinBaseAddress failed")
             sys.exit(return_code)
 
         # create Fsp_Rebased.fd which is Fsp_Rebased_S.fd +
--
2.13.3.windows.1