From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: nathaniel.l.desimone@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Tue, 30 Jul 2019 15:19:02 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jul 2019 15:19:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,327,1559545200"; d="scan'208";a="166134819" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by orsmga008.jf.intel.com with ESMTP; 30 Jul 2019 15:19:01 -0700 Received: from orsmsx111.amr.corp.intel.com (10.22.240.12) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 30 Jul 2019 15:19:00 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.96]) by ORSMSX111.amr.corp.intel.com ([169.254.12.226]) with mapi id 14.03.0439.000; Tue, 30 Jul 2019 15:19:00 -0700 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Chiu, Chasel" CC: "Kubacki, Michael A" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH 2/4] Platform/Intel: Auto configure Fsp*BaseAddress PCD Thread-Topic: [edk2-devel] [PATCH 2/4] Platform/Intel: Auto configure Fsp*BaseAddress PCD Thread-Index: AQHVRf3i2sIyaBSSME+JwOjQ4eiq/6bju0LQ Date: Tue, 30 Jul 2019 22:18:59 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAED95B16@ORSMSX114.amr.corp.intel.com> References: <20190729110715.2312-1-chasel.chiu@intel.com> <20190729110715.2312-3-chasel.chiu@intel.com> In-Reply-To: <20190729110715.2312-3-chasel.chiu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzNjMjY2MzEtYjU0ZC00NWJjLWE5ZjYtNmE3OGQ0YWZjMGZiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiN1dldmRiM2kxY05XRTZteVJMczJuaWQrNEJMY2luc1ZjYlVXdUlvSktoWjhtZ1N3clVNZGtCOUlaWnpMcTlwUyJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: devel@edk2.groups.io On Behalf Of Chiu, Chase= l Sent: Monday, July 29, 2019 4:07 AM To: devel@edk2.groups.io Cc: Kubacki, Michael A ; Desimone, Nathaniel = L ; Gao, Liming Subject: [edk2-devel] [PATCH 2/4] Platform/Intel: Auto configure Fsp*BaseA= ddress PCD REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1863 Consume RebaseFspBinBaseAddress.py which will only rebase FSP binary witho= ut patching platform DSC. Cc: Michael Kubacki Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Chasel Chiu --- Platform/Intel/build_bios.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/Platform/Intel/build_bios.py b/Platform/Intel/build_bios.py i= ndex c01b953d16..37b5ee2f5b 100644 --- a/Platform/Intel/build_bios.py +++ b/Platform/Intel/build_bios.py @@ -303,21 +303,18 @@ def build(config): os.path.join(config['WORKSPACE_PLATFORM'], config['PLATFORM_PACKAGE'], 'Tools', 'Fsp', - 'RebaseAndPatchFspBinBaseAddress.py'), + 'RebaseFspBinBaseAddress.py'), os.path.join(config['WORKSPACE_PLATFORM'], config['FLASH_MAP_FDF']), os.path.join(config['WORKSPACE_FSP_BIN'], config['FSP_BIN_PKG']), "Fsp.fd", - os.path.join(config['WORKSPACE_PLATFORM'], - config['PROJECT'], - config['BOARD_PKG_PCD_DSC']), "0x0"] =20 _, _, _, return_code =3D execute_script(command, config, shell=3D= False) =20 if return_code !=3D 0: - print("ERROR:RebaseAndPatchFspBinBaseAddress failed") + print("ERROR:RebaseFspBinBaseAddress failed") sys.exit(return_code) =20 # create Fsp_Rebased.fd which is Fsp_Rebased_S.fd + -- 2.13.3.windows.1