From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: nathaniel.l.desimone@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Thu, 08 Aug 2019 13:47:05 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2019 13:47:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,362,1559545200"; d="scan'208";a="169109566" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by orsmga008.jf.intel.com with ESMTP; 08 Aug 2019 13:47:04 -0700 Received: from orsmsx123.amr.corp.intel.com (10.22.240.116) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 8 Aug 2019 13:47:04 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.96]) by ORSMSX123.amr.corp.intel.com ([169.254.1.245]) with mapi id 14.03.0439.000; Thu, 8 Aug 2019 13:47:04 -0700 From: "Nate DeSimone" To: "Zeng, Star" , "Chiu, Chasel" , "Zhang, Shenglei" , "devel@edk2.groups.io" Subject: Re: [PATCH 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in INF file Thread-Topic: [PATCH 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in INF file Thread-Index: AQHVTbazozjZrXNFEkqO3ihjqSfusKbxzMeA///oPqA= Date: Thu, 8 Aug 2019 20:47:03 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEDE8A7A@ORSMSX114.amr.corp.intel.com> References: <20190808062456.6116-1-shenglei.zhang@intel.com> <20190808062456.6116-4-shenglei.zhang@intel.com> <3C3EFB470A303B4AB093197B6777CCEC50457EC3@PGSMSX111.gar.corp.intel.com> <0C09AFA07DD0434D9E2A0C6AEB04831040390A39@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB04831040390A39@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDY5ZGU3N2EtMjg5Ny00NWI5LTg5M2EtZTkxMjRiYmNjNTZiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTDdvY0pzS0RqVjdpaHhybkZuUkxyR1VzamZBaFRLeDJpNmRRRHc5YzdqZUZFMTRybW9odjVCNW1pRm5KUXJKcyJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Agreed with Chasel and Star. Once copyright is extended: Reviewed-by: Nate DeSimone -----Original Message----- From: Zeng, Star=20 Sent: Thursday, August 8, 2019 7:56 AM To: Chiu, Chasel ; Zhang, Shenglei ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Zeng, Star Subject: RE: [PATCH 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file i= n INF file Same with Chasel. Reviewed-by: Star Zeng . > -----Original Message----- > From: Chiu, Chasel > Sent: Thursday, August 8, 2019 2:59 PM > To: Zhang, Shenglei ; devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Zeng, Star=20 > > Subject: RE: [PATCH 3/3] IntelFsp2Pkg/FspSecCore: Add missing header=20 > file in INF file >=20 >=20 > Please extend copyright to 2019 of this file. > With above change Reviewed-by: Chasel Chiu >=20 >=20 > > -----Original Message----- > > From: Zhang, Shenglei > > Sent: Thursday, August 8, 2019 2:25 PM > > To: devel@edk2.groups.io > > Cc: Chiu, Chasel ; Desimone, Nathaniel L=20 > > ; Zeng, Star > > Subject: [PATCH 3/3] IntelFsp2Pkg/FspSecCore: Add missing header=20 > > file in INF file > > > > SecFsp.h is used but missing inf file, which will cause generating=20 > > warning message. > > > > Cc: Chasel Chiu > > Cc: Nate DeSimone > > Cc: Star Zeng > > Signed-off-by: Shenglei Zhang > > --- > > IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf > > b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf > > index 3de09b5b4921..86d3d31d3269 100644 > > --- a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf > > +++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf > > @@ -22,6 +22,7 @@ [Defines] > > > > [Sources] > > SecFspApiChk.c > > + SecFsp.h > > > > [Sources.IA32] > > Ia32/Stack.nasm > > -- > > 2.18.0.windows.1