From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "Kubacki, Michael A" <michael.a.kubacki@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Chiu, Chasel" <chasel.chiu@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms] [PATCH] Platform/Intel/KabylakeOpenBoardPkg: Fix build.
Date: Sun, 11 Aug 2019 23:54:17 +0000 [thread overview]
Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEDF3F28@ORSMSX114.amr.corp.intel.com> (raw)
In-Reply-To: <49AB4ACB9627B8468F29D589A27B745588A3D155@ORSMSX122.amr.corp.intel.com>
Pushed: https://github.com/tianocore/edk2-platforms/commit/84627927fa195703752c7fd5ab4437f87c547b87
-----Original Message-----
From: Kubacki, Michael A
Sent: Friday, August 9, 2019 11:13 AM
To: devel@edk2.groups.io; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Cc: Chiu, Chasel <chasel.chiu@intel.com>
Subject: RE: [edk2-devel] [edk2-platforms] [PATCH] Platform/Intel/KabylakeOpenBoardPkg: Fix build.
Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Nate DeSimone
> Sent: Thursday, August 8, 2019 5:47 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Kubacki, Michael A
> <michael.a.kubacki@intel.com>
> Subject: [edk2-devel] [edk2-platforms] [PATCH]
> Platform/Intel/KabylakeOpenBoardPkg: Fix build.
>
> The build for KabylakeOpenBoardPkg is presently broken due to
> WORKSPACE_PLATFORM_BIN being defined to a marco of the same name in
> KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
>
> Setting this macro to an empty string resolves the issue.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
> .../Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
> index bf89ea399c..ab1a9a61c2 100644
> ---
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
> +++
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
> @@ -7,7 +7,7 @@
>
>
> [CONFIG]
> -WORKSPACE_PLATFORM_BIN = WORKSPACE_PLATFORM_BIN
> +WORKSPACE_PLATFORM_BIN =
> EDK_SETUP_OPTION =
> openssl_path =
> PLATFORM_BOARD_PACKAGE = KabylakeOpenBoardPkg
> --
> 2.17.1.windows.2
>
>
>
next prev parent reply other threads:[~2019-08-11 23:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 0:46 [edk2-platforms] [PATCH] Platform/Intel/KabylakeOpenBoardPkg: Fix build Nate DeSimone
2019-08-09 18:12 ` [edk2-devel] " Kubacki, Michael A
2019-08-11 23:54 ` Nate DeSimone [this message]
2019-08-12 2:07 ` Chiu, Chasel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02A34F284D1DA44BB705E61F7180EF0AAEDF3F28@ORSMSX114.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox