From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: nathaniel.l.desimone@intel.com)
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by groups.io with SMTP; Sun, 11 Aug 2019 16:54:18 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga008.fm.intel.com ([10.253.24.58])
  by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Aug 2019 16:54:18 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,375,1559545200"; 
   d="scan'208";a="175735971"
Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5])
  by fmsmga008.fm.intel.com with ESMTP; 11 Aug 2019 16:54:18 -0700
Received: from orsmsx114.amr.corp.intel.com ([169.254.8.96]) by
 ORSMSX107.amr.corp.intel.com ([169.254.1.186]) with mapi id 14.03.0439.000;
 Sun, 11 Aug 2019 16:54:18 -0700
From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "Kubacki, Michael A" <michael.a.kubacki@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Chiu, Chasel" <chasel.chiu@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms] [PATCH] Platform/Intel/KabylakeOpenBoardPkg: Fix build.
Thread-Topic: [edk2-devel] [edk2-platforms] [PATCH]
 Platform/Intel/KabylakeOpenBoardPkg: Fix build.
Thread-Index: AQHVTkv9lfbSS8R1C06tEZo9tztUT6bzH0XAgAOEDHA=
Date: Sun, 11 Aug 2019 23:54:17 +0000
Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEDF3F28@ORSMSX114.amr.corp.intel.com>
References: <20190809004653.39088-1-nathaniel.l.desimone@intel.com>
 <49AB4ACB9627B8468F29D589A27B745588A3D155@ORSMSX122.amr.corp.intel.com>
In-Reply-To: <49AB4ACB9627B8468F29D589A27B745588A3D155@ORSMSX122.amr.corp.intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDIyYWZhMmYtNGEyNi00YjFmLWE0ZWYtNDI3MGUwMmNiZmI1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidUhOdnFzdFFiMzg1NlNOMTFOV0h2T3F5OERmeldzaHFaUCtDMlhjVVcwZ3A2U3NLXC9sOHEwRWVERDZQQ2dvNDMifQ==
x-ctpclassification: CTP_NT
x-originating-ip: [10.22.254.139]
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Pushed: https://github.com/tianocore/edk2-platforms/commit/84627927fa195703=
752c7fd5ab4437f87c547b87

-----Original Message-----
From: Kubacki, Michael A=20
Sent: Friday, August 9, 2019 11:13 AM
To: devel@edk2.groups.io; Desimone, Nathaniel L <nathaniel.l.desimone@inte=
l.com>
Cc: Chiu, Chasel <chasel.chiu@intel.com>
Subject: RE: [edk2-devel] [edk2-platforms] [PATCH] Platform/Intel/Kabylake=
OpenBoardPkg: Fix build.

Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of=20
> Nate DeSimone
> Sent: Thursday, August 8, 2019 5:47 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Kubacki, Michael A=20
> <michael.a.kubacki@intel.com>
> Subject: [edk2-devel] [edk2-platforms] [PATCH]
> Platform/Intel/KabylakeOpenBoardPkg: Fix build.
>=20
> The build for KabylakeOpenBoardPkg is presently broken due to=20
> WORKSPACE_PLATFORM_BIN being defined to a marco of the same name in=20
> KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
>=20
> Setting this macro to an empty string resolves the issue.
>=20
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
>  .../Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg    | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
> index bf89ea399c..ab1a9a61c2 100644
> ---=20
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
> +++
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
> @@ -7,7 +7,7 @@
>=20
>=20
>  [CONFIG]
> -WORKSPACE_PLATFORM_BIN =3D WORKSPACE_PLATFORM_BIN
> +WORKSPACE_PLATFORM_BIN =3D
>  EDK_SETUP_OPTION =3D
>  openssl_path =3D
>  PLATFORM_BOARD_PACKAGE =3D KabylakeOpenBoardPkg
> --
> 2.17.1.windows.2
>=20
>=20
>=20