From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: nathaniel.l.desimone@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Fri, 16 Aug 2019 17:54:29 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Aug 2019 17:54:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,395,1559545200"; d="scan'208";a="195105068" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by fmsmga001.fm.intel.com with ESMTP; 16 Aug 2019 17:54:28 -0700 Received: from orsmsx161.amr.corp.intel.com (10.22.240.84) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 16 Aug 2019 17:54:27 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.96]) by ORSMSX161.amr.corp.intel.com ([169.254.4.172]) with mapi id 14.03.0439.000; Fri, 16 Aug 2019 17:54:27 -0700 From: "Nate DeSimone" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Chiu, Chasel" , "Gao, Liming" , "Kinney, Michael D" , "Sinha, Ankit" Subject: Re: [edk2-platforms][PATCH V1 37/37] Add WhiskeylakeOpenBoardPkg to global build config and documentation Thread-Topic: [edk2-platforms][PATCH V1 37/37] Add WhiskeylakeOpenBoardPkg to global build config and documentation Thread-Index: AQHVVJEdhXKEicmM+kOYe9DtruxqnKb+g3xw Date: Sat, 17 Aug 2019 00:54:26 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEE12B54@ORSMSX114.amr.corp.intel.com> References: <20190817001603.30632-1-michael.a.kubacki@intel.com> <20190817001603.30632-38-michael.a.kubacki@intel.com> In-Reply-To: <20190817001603.30632-38-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjc0YjA3YmQtMmRlNi00MDdhLWI4YmMtNGU0YmZkYzg1OWNjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTEppWnhvOEprdWtTbXlpaXM3Ym04SmlUanNrKzQ0bGZ5N0NmZThsanVkbW9VXC9pQ24wNU5BeUxnc0lOckxvZ2EifQ== x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: Kubacki, Michael A=20 Sent: Friday, August 16, 2019 5:16 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Gao, Liming ; Desimone, Nathanie= l L ; Kinney, Michael D ; Sinha, Ankit Subject: [edk2-platforms][PATCH V1 37/37] Add WhiskeylakeOpenBoardPkg to gl= obal build config and documentation REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2083 * Adds the WhiskeylakeURvp board as a build option in build.cfg so it it is listed as a valid build target. * Updates relevant Readme.md files to include instructions for WhiskeylakeOpenBoardPkg. * Adds the maintainers for WhiskeylakeOpenBoardPkg to maintainers.txt. Cc: Sai Chaganty Cc: Chasel Chiu Cc: Liming Gao Cc: Nate DeSimone Cc: Michael D Kinney Cc: Ankit Sinha Signed-off-by: Michael Kubacki --- Maintainers.txt | 5 +++ Platform/Intel/Readme.md | 44 +++++++++++++------- Platform/Intel/build.c= fg | 4 +- Readme.md | 1 + 4 files changed, 38 insertions(+), 16 deletions(-) diff --git a/Maintainers.txt b/Maintainers.txt index bc8cbd6458..b16432bf87= 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -98,6 +98,11 @@ M: Shifei A Lu M: Xiaohu Zhou M: Isaac W Oram =20 +Platform/Intel/WhiskeylakeOpenBoardPkg +M: Chasel Chiu +M: Michael Kubacki +M: Nate DeSimone + Platform/Intel/Tools M: Bob Feng M: Liming Gao diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md index 00f4= 2985a2..aaf6ef4d3e 100644 --- a/Platform/Intel/Readme.md +++ b/Platform/Intel/Readme.md @@ -53,9 +53,10 @@ A UEFI firmware implementation using MinPlatformPkg is c= onstructed using the fol =20 =20 ## Board Support +* The `ClevoOpenBoardPkg` contains board implementations for Clevo systems= . * The `KabylakeOpenBoardPkg` contains board implementations for Kaby Lake = systems. * The `PurleyOpenBoardPkg` contains board implementations for Purley syste= ms. -* The `ClevoOpenBoardPkg` contains board implementations for Clevo systems= . +* The `WhiskeylakeOpenBoardPkg` contains board implementations for Whiskey= Lake systems. =20 ## Board Package Organization The board package follows the standard EDK II package structure with the f= ollowing additional elements and guidelines: @@ -189,7 +190,12 @@ return back to the minimum platform caller. | | | |---build_config.cfg: BoardMtO= lympus specific | | | | build se= ttings, environment variables. | | | |---build_board.py: Optional b= oard-specific pre-build, - | | | | build, pos= t-build and clean functions. + | | | build, pos= t-build and clean functions. + | | | + | | |------WhiskeylakeOpenBoardPkg + | | | |------WhiskeylakeURvp + | | | |---build_config.cfg: Whiskeyl= akeURvp specific build + | | | settings= environment variables. |------FSP =20 @@ -222,19 +228,6 @@ Users can also flash the UEFI firmware image to the hi= ghest area of the flash re =20 ### **Known limitations** =20 -**KabylakeOpenBoardPkg** -1. This firmware project has only been tested on the Intel KabylakeRvp3 bo= ard. -2. This firmware project has only been tested booting to Microsoft Windows= 10 x64 with AHCI mode and Integrated Graphic - Device. -3. The Windows build was tested on Windows 10 with Microsoft Visual Studio= 2015. -4. The Linux build was tested on Ubuntu 16.04.5 LTS with GCC version 5.4.0= . -5. The build was tested with NASM version 2.11.08. - -**PurleyOpenBoardPkg** -1. This firmware project has only been tested on the Microsoft MtOlympus b= oard. -2. This firmware project has only been tested booting to Microsoft Windows= Server 2016 with NVME on M.2 slot. -3. This firmware project build has only been tested using the Microsoft Vi= sual Studio 2015 compiler. - **ClevoOpenBoardPkg** 1. Currently, support is only being added for the N1xxWU series of boards. 2. The Windows build was tested on Windows 10 with Microsoft Visual Studio= 2015 compiler. @@ -244,6 +237,27 @@ Users can also flash the UEFI firmware image to the hi= ghest area of the flash re 6. The firmware project applies to all Clevo su= pported board configurations but is only being tested on System 76 Galago Pro devices. =20 +**KabylakeOpenBoardPkg** +1. This firmware project has only been tested on the Intel KabylakeRvp3 bo= ard. +2. This firmware project has only been tested booting to Microsoft=20 +Windows 10 x64 with AHCI mode and Integrated Graphic + Device. +3. The Windows build was tested on Windows 10 with Microsoft Visual Studio= 2015. +4. The Linux build was tested on Ubuntu 16.04.5 LTS with GCC version 5.4.0= . +5. The build was tested with NASM version 2.11.08. + +**PurleyOpenBoardPkg** +1. This firmware project has only been tested on the Microsoft MtOlympus b= oard. +2. This firmware project has only been tested booting to Microsoft Windows= Server 2016 with NVME on M.2 slot. +3. This firmware project build has only been tested using the Microsoft Vi= sual Studio 2015 compiler. + +**WhiskeylakeOpenBoardPkg** +1. This firmware project has only been tested on the Intel WhiskeylakeURvp= board. +2. This firmware project has only been tested booting to Microsoft=20 +Windows 10 x64 with AHCI mode and Integrated Graphic + Device. +3. The Windows build was tested on Windows 10 with Microsoft Visual Studio= 2015. +4. The Linux build was tested on Ubuntu 16.04.5 LTS with GCC version 5.4.0= . +5. The build was tested with NASM version 2.11.08. + ### **Planned Activities** * Replace the batch build scripts with cross-platform Python build scripts= . * Publish a Minimum Platform specification to describe the architecture an= d interfaces in more detail. diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg index fc6e= 4fe824..b6d32ada49 100644 --- a/Platform/Intel/build.cfg +++ b/Platform/Intel/build.cfg @@ -51,6 +51,8 @@ NUMBER_OF_PROCESSORS =3D 0 =20 [PLATFORMS] # board_name =3D path_to_board_build_config.cfg +BoardMtOlympus =3D PurleyOpenBoardPkg/BoardMtOlympus/build_config.cfg KabylakeRvp3 =3D KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg N1xxWU =3D ClevoOpenBoardPkg/N1xxWU/build_config.cfg -BoardMtOlympus =3D PurleyOpenBoardPkg/BoardMtOlympus/build_config.cfg +WhiskeylakeURvp =3D=20 +WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config.cfg + diff --git a/Readme.md b/Readme.md index 1befd0b544..e4f211eee6 100644 --- a/Readme.md +++ b/Readme.md @@ -228,6 +228,7 @@ they will be documented with the platform. * [Clevo](Platform/Intel/ClevoOpenBoardPkg) * [Kaby Lake](Platform/Intel/KabylakeOpenBoardPkg) * [Purley](Platform/Intel/PurleyOpenBoardPkg) +* [Whiskey Lake](Platform/Intel/WhiskeylakeOpenBoardPkg) =20 For more information, see the [EDK II Minimum Platform Specification](https://edk2-docs.gitbooks.io/edk-= ii-minimum-platform-specification). -- 2.16.2.windows.1