From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: nathaniel.l.desimone@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Mon, 19 Aug 2019 16:21:38 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Aug 2019 16:21:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,406,1559545200"; d="scan'208";a="189678832" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by orsmga002.jf.intel.com with ESMTP; 19 Aug 2019 16:21:38 -0700 Received: from orsmsx155.amr.corp.intel.com (10.22.240.21) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 19 Aug 2019 16:21:37 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.96]) by ORSMSX155.amr.corp.intel.com ([169.254.7.26]) with mapi id 14.03.0439.000; Mon, 19 Aug 2019 16:21:37 -0700 From: "Nate DeSimone" To: "Wei, David Y" , "devel@edk2.groups.io" CC: "Wu, Hao A" , "Gao, Liming" , "Sinha, Ankit" , "Agyeman, Prince" , "Kubacki, Michael A" , "Kinney, Michael D" Subject: Re: [edk2-platform patch 7/7] Platform/Intel: Add build option for SIMICS QSP Platform Thread-Topic: [edk2-platform patch 7/7] Platform/Intel: Add build option for SIMICS QSP Platform Thread-Index: AQHVTwRdr3g5bayqS0uIyOkIpVP8NacDKzKg Date: Mon, 19 Aug 2019 23:21:36 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEE1B2E1@ORSMSX114.amr.corp.intel.com> References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDgwZjM5ZDgtODA2My00MDdmLTkxNTUtOWNiMTE0NjQ4NTc4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWFY5blNUVHl1amY1OTFVUEZwYkt5N3pWR3FMOUhtTWcrdmJSNnhYdXBzR2JQeDdGY1hDcnJjNFRaYVNnTFpXNCJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi David, This patch no longer applies cleanly on the latest edk2-platforms master br= anch. In addition to addressing the review feedback I previously sent, plea= se rebase your patch. Thanks, Nate -----Original Message----- From: Wei, David Y=20 Sent: Friday, August 9, 2019 3:47 PM To: devel@edk2.groups.io Cc: Wu, Hao A ; Gao, Liming ; Sin= ha, Ankit ; Agyeman, Prince ; Kubacki, Michael A ; Desimone, Nathaniel L= ; Kinney, Michael D Subject: [edk2-platform patch 7/7] Platform/Intel: Add build option for SIM= ICS QSP Platform Add build option in build script for SIMICS QSP Platform Cc: Hao Wu Cc: Liming Gao Cc: Ankit Sinha Cc: Agyeman Prince Cc: Kubacki Michael A Cc: Nate DeSimone Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: David Wei --- Platform/Intel/build.cfg | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg index fc6e= 4fe824..2ebe09a632 100644 --- a/Platform/Intel/build.cfg +++ b/Platform/Intel/build.cfg @@ -54,3 +54,5 @@ NUMBER_OF_PROCESSORS =3D 0 KabylakeRvp3 =3D KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg N1xxWU =3D ClevoOpenBoardPkg/N1xxWU/build_config.cfg BoardMtOlympus =3D PurleyOpenBoardPkg/BoardMtOlympus/build_config.cfg +WhiskeylakeURvp =3D=20 +WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config.cfg +BoardX58ICH10 =3D SimicsOpenBoardPkg/BoardX58ICH10/build_config.cfg -- 2.16.2.windows.1