From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: nathaniel.l.desimone@intel.com) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Fri, 23 Aug 2019 14:55:29 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Aug 2019 14:55:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,422,1559545200"; d="scan'208";a="179281189" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by fmsmga008.fm.intel.com with ESMTP; 23 Aug 2019 14:55:28 -0700 Received: from orsmsx151.amr.corp.intel.com (10.22.226.38) by ORSMSX103.amr.corp.intel.com (10.22.225.130) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 23 Aug 2019 14:55:28 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.225]) by ORSMSX151.amr.corp.intel.com ([169.254.7.126]) with mapi id 14.03.0439.000; Fri, 23 Aug 2019 14:55:28 -0700 From: "Nate DeSimone" To: "Zhang, Shenglei" , "devel@edk2.groups.io" CC: "Kubacki, Michael A" , "Chiu, Chasel" , "Gao, Liming" Subject: Re: [edk2-platform PATCH 2/2] Platform/MinPlatformPkg: Add missing header files in INF files Thread-Topic: [edk2-platform PATCH 2/2] Platform/MinPlatformPkg: Add missing header files in INF files Thread-Index: AQHVV/aiVGfunIHzWUG1ITO6gbqD8acJSuRg Date: Fri, 23 Aug 2019 21:55:28 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEE47F04@ORSMSX114.amr.corp.intel.com> References: <20190821080108.1736-1-shenglei.zhang@intel.com> <20190821080108.1736-3-shenglei.zhang@intel.com> In-Reply-To: <20190821080108.1736-3-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzYzZjZhNDQtYThlZi00ZGQxLWIwMTktYWUwNjQ0YTllMTNhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYm5OMUtzS1JCbUtXanlrbjhyU21HbGdFWk1QTzJOQ1hrZEF3TVd4cTJxRzl1VFRDak55eFR4WUp5UHBmQnFDbCJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable With copyright change noted by other reviewers... Reviewed-by: Nate DeSimone -----Original Message----- From: Zhang, Shenglei=20 Sent: Wednesday, August 21, 2019 1:01 AM To: devel@edk2.groups.io Cc: Kubacki, Michael A ; Chiu, Chasel ; Desimone, Nathaniel L ; Ga= o, Liming Subject: [edk2-platform PATCH 2/2] Platform/MinPlatformPkg: Add missing hea= der files in INF files The header files are used but missing in INF,which causes warning message w= hen building them. https://bugzilla.tianocore.org/show_bug.cgi?id=3D2037 Cc: Michael Kubacki Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Shenglei Zhang --- .../MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf | 1 + .../SecFspWrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf | 1 + .../Hsti/HstiIbvPlatformDxe/HstiIbvPlatformDxe.inf | 1 + .../Library/PeiHobVariableLibFce/PeiHobVariableLibFce.inf | 2 ++ .../PeiHobVariableLibFce/PeiHobVariableLibFceOptSize.inf | 2 ++ .../Test/Library/TestPointCheckLib/DxeTestPointCheckLib.inf | 1 + .../Test/Library/TestPointCheckLib/SmmTestPointCheckLib.inf | 1 + 7 files changed, 9 insertions(+) diff --git a/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServic= eSmm.inf b/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceS= mm.inf index cca7de94..4c5202f9 100644 --- a/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.in= f +++ b/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm +++ .inf @@ -50,6 +50,7 @@ [Sources] Common/SpiFvbServiceCommon.c Common/FvbInfo.c + Common/SpiFvbServiceCommon.h Smm/SpiFvbServiceSmm.c =20 [Protocols] diff --git a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapper= PlatformSecLib/SecFspWrapperPlatformSecLib.inf b/Platform/Intel/MinPlatform= Pkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/SecFspWrapperPlatformSec= Lib.inf index 5d77e9e4..3f5a63f2 100644 --- a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatfor= mSecLib/SecFspWrapperPlatformSecLib.inf +++ b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlat +++ formSecLib/SecFspWrapperPlatformSecLib.inf @@ -41,6 +41,7 @@ SecGetPerformance.c SecTempRamDone.c PlatformInit.c + FsptCoreUpd.h =20 [Sources.IA32] Ia32/SecEntry.nasm diff --git a/Platform/Intel/MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvP= latformDxe.inf b/Platform/Intel/MinPlatformPkg/Hsti/HstiIbvPlatformDxe/Hsti= IbvPlatformDxe.inf index 64814528..172280e8 100644 --- a/Platform/Intel/MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvPlatform= Dxe.inf +++ b/Platform/Intel/MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvPlatf +++ ormDxe.inf @@ -23,6 +23,7 @@ SecureBootBypass.c ExternalDeviceDmaProtection.c MorSupport.c + HstiIbvPlatformDxe.h =20 [Packages] MdePkg/MdePkg.dec diff --git a/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/Pei= HobVariableLibFce.inf b/Platform/Intel/MinPlatformPkg/Library/PeiHobVariabl= eLibFce/PeiHobVariableLibFce.inf index fd80c611..ad8882fe 100644 --- a/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVari= ableLibFce.inf +++ b/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobV +++ ariableLibFce.inf @@ -37,6 +37,8 @@ [Sources] PeiHobVariableLibFce.c InternalCommonLib.c + Variable.h + Fce.h =20 [Ppis] gEfiPeiMemoryDiscoveredPpiGuid ## NOTIFY diff --git a/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/Pei= HobVariableLibFceOptSize.inf b/Platform/Intel/MinPlatformPkg/Library/PeiHob= VariableLibFce/PeiHobVariableLibFceOptSize.inf index 82d81c98..e1a76715 100644 --- a/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVari= ableLibFceOptSize.inf +++ b/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobV +++ ariableLibFceOptSize.inf @@ -36,6 +36,8 @@ [Sources] PeiHobVariableLibFceOptSize.c InternalCommonLib.c + Variable.h + Fce.h =20 [Ppis] gEfiPeiMemoryDiscoveredPpiGuid ## NOTIFY diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/D= xeTestPointCheckLib.inf b/Platform/Intel/MinPlatformPkg/Test/Library/TestPo= intCheckLib/DxeTestPointCheckLib.inf index 62fceffb..76e193dc 100644 --- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestP= ointCheckLib.inf +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTe +++ stPointCheckLib.inf @@ -68,6 +68,7 @@ DxeCheckTcgMor.c DxeCheckDmaProtection.c TestPointHelp.c + TestPointInternal.h =20 [Guids] gEfiMemoryAttributesTableGuid diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/S= mmTestPointCheckLib.inf b/Platform/Intel/MinPlatformPkg/Test/Library/TestPo= intCheckLib/SmmTestPointCheckLib.inf index 6007fbc9..03d027ec 100644 --- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestP= ointCheckLib.inf +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTe +++ stPointCheckLib.inf @@ -45,6 +45,7 @@ DxeCheckLoadedImage.c DxeCheckGcd.c TestPointHelp.c + TestPointInternal.h =20 [Pcd] gMinPlatformPkgTokenSpaceGuid.PcdTestPointIbvPlatformFeature -- 2.18.0.windows.1