From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: nathaniel.l.desimone@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Fri, 23 Aug 2019 14:59:48 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Aug 2019 14:59:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,422,1559545200"; d="scan'208";a="196570186" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by fmsmga001.fm.intel.com with ESMTP; 23 Aug 2019 14:59:50 -0700 Received: from orsmsx152.amr.corp.intel.com (10.22.226.39) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 23 Aug 2019 14:59:48 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.225]) by ORSMSX152.amr.corp.intel.com ([169.254.8.159]) with mapi id 14.03.0439.000; Fri, 23 Aug 2019 14:59:47 -0700 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Kubacki, Michael A" CC: "Chiu, Chasel" , "Gao, Liming" Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 1/2] KabylakeOpenBoardPkg: Fix GCC Build Failures Thread-Topic: [edk2-devel] [edk2-platforms][PATCH V1 1/2] KabylakeOpenBoardPkg: Fix GCC Build Failures Thread-Index: AQHVWRCy3f7egW2JXE69NThPGQc3g6cJSeNg Date: Fri, 23 Aug 2019 21:59:46 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEE47F3A@ORSMSX114.amr.corp.intel.com> References: <20190822174008.20624-1-michael.a.kubacki@intel.com> <20190822174008.20624-2-michael.a.kubacki@intel.com> In-Reply-To: <20190822174008.20624-2-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTUxYWVkZGUtYjYzNS00MGJlLTk5YjctNzM0NWM2YTNhM2NmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieWF0VGtsT0hlSktIZ2E2aWlQZHZOT21iSmtuQ2xneW9uZjJEcGt1XC9sNG5pd0Q1N2ZoWnZYRVRSc0lmU2Y5ZmEifQ== x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable With copyright year change... Reviewed-by: Nate DeSimone < -----Original Message----- From: devel@edk2.groups.io On Behalf Of Kubacki, Mi= chael A Sent: Thursday, August 22, 2019 10:40 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming Subject: [edk2-devel] [edk2-platforms][PATCH V1 1/2] KabylakeOpenBoardPkg:= Fix GCC Build Failures REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2109 Fixes build failures on GCC7.3.0. Tested on Ubunutu 18.04.1 LTS. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Michael Kubacki --- Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapperPlatf= ormSecLib/FspWrapperPlatformSecLib.c | 2 +- Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioE= xpanderLib.c | 6 ++---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFsp= WrapperPlatformSecLib/FspWrapperPlatformSecLib.c b/Platform/Intel/KabylakeO= penBoardPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/FspWrapperPlatfo= rmSecLib.c index d73fc77f69..d40eecae95 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper= PlatformSecLib/FspWrapperPlatformSecLib.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper= PlatformSecLib/FspWrapperPlatformSecLib.c @@ -174,7 +174,7 @@ SecPlatformMain ( // CopyMem (CopyDestinationPointer, mPeiCoreFvLocationPpiList, sizeof (m= PeiCoreFvLocationPpiList)); TopOfTemporaryRamPpiIndex =3D 1; - (UINT8 *) CopyDestinationPointer +=3D sizeof(mPeiCoreFvLocationPpiLis= t); + CopyDestinationPointer +=3D sizeof (mPeiCoreFvLocationPpiList); } CopyMem (CopyDestinationPointer, mPeiSecPlatformPpi, sizeof(mPeiSecPlat= formPpi)); // diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderL= ib/BaseGpioExpanderLib.c b/Platform/Intel/KabylakeOpenBoardPkg/Library/Base= GpioExpanderLib/BaseGpioExpanderLib.c index ead1e6df19..acab1326ff 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/Base= GpioExpanderLib.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/Base= GpioExpanderLib.c @@ -70,12 +70,11 @@ GpioExpGetRegister ( IN UINT8 Register ) { - EFI_STATUS Status; UINT8 WriBuf[1]; UINT8 ReBuf[1] =3D {0}; =20 WriBuf[0] =3D Register; - Status =3D I2cWriteRead( Bar0, TCA6424_I2C_ADDRESS+Address, 1, WriBuf, = 1, ReBuf, WAIT_1_SECOND); + I2cWriteRead (Bar0, TCA6424_I2C_ADDRESS + Address, 1, WriBuf, 1, ReBuf,= WAIT_1_SECOND); =20 return ReBuf[0]; } @@ -99,13 +98,12 @@ GpioExpSetRegister ( IN UINT8 Value ) { - EFI_STATUS Status; UINT8 WriBuf[2]; =20 WriBuf[0] =3D Register; WriBuf[1] =3D Value; - Status =3D I2cWriteRead( Bar0, TCA6424_I2C_ADDRESS+Address, 2, WriBuf, = 0, NULL, WAIT_1_SECOND); =20 + I2cWriteRead (Bar0, TCA6424_I2C_ADDRESS + Address, 2, WriBuf, 0, NULL, = WAIT_1_SECOND); } /** Set the input register to a give value mentioned in the function. --=20 2.16.2.windows.1