From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: nathaniel.l.desimone@intel.com) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Fri, 23 Aug 2019 15:09:55 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Aug 2019 15:09:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,422,1559545200"; d="scan'208";a="203900299" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by fmsmga004.fm.intel.com with ESMTP; 23 Aug 2019 15:09:54 -0700 Received: from orsmsx122.amr.corp.intel.com (10.22.225.227) by ORSMSX103.amr.corp.intel.com (10.22.225.130) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 23 Aug 2019 15:09:54 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.225]) by ORSMSX122.amr.corp.intel.com ([169.254.11.203]) with mapi id 14.03.0439.000; Fri, 23 Aug 2019 15:09:54 -0700 From: "Nate DeSimone" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Gao, Liming" Subject: Re: [edk2-platforms][PATCH V2 1/2] KabylakeOpenBoardPkg: Fix GCC Build Failures Thread-Topic: [edk2-platforms][PATCH V2 1/2] KabylakeOpenBoardPkg: Fix GCC Build Failures Thread-Index: AQHVWRXJgxDDAczPM0CC1xtYsbcsyacJS7uw Date: Fri, 23 Aug 2019 22:09:53 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEE4804B@ORSMSX114.amr.corp.intel.com> References: <20190822181642.25596-1-michael.a.kubacki@intel.com> <20190822181642.25596-2-michael.a.kubacki@intel.com> In-Reply-To: <20190822181642.25596-2-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2VmZmRmODItOGFhYi00OWMwLWI4ZDYtOGIyNWFmNTczZDM4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZFhQeTB6RmtNbnZCZXVud3dzNDhia2VHUldDdVVOV2ZLbWErZ3VcLzE0UEtudWNQM3hqM0VZb2E1M1dVWVRrYkQifQ== x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: Kubacki, Michael A=20 Sent: Thursday, August 22, 2019 11:17 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming Subject: [edk2-platforms][PATCH V2 1/2] KabylakeOpenBoardPkg: Fix GCC Build= Failures REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2109 Fixes build failures on GCC7.3.0. Tested on Ubunutu 18.04.1 LTS. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Michael Kubacki --- Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapperPlatfo= rmSecLib/FspWrapperPlatformSecLib.c | 2 +- Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioEx= panderLib.c | 8 +++----- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspW= rapperPlatformSecLib/FspWrapperPlatformSecLib.c b/Platform/Intel/KabylakeOp= enBoardPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/FspWrapperPlatfor= mSecLib.c index d73fc77f69..d40eecae95 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapperP= latformSecLib/FspWrapperPlatformSecLib.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapperP= latformSecLib/FspWrapperPlatformSecLib.c @@ -174,7 +174,7 @@ SecPlatformMain ( // CopyMem (CopyDestinationPointer, mPeiCoreFvLocationPpiList, sizeof (mP= eiCoreFvLocationPpiList)); TopOfTemporaryRamPpiIndex =3D 1; - (UINT8 *) CopyDestinationPointer +=3D sizeof(mPeiCoreFvLocationPpiList= ); + CopyDestinationPointer +=3D sizeof (mPeiCoreFvLocationPpiList); } CopyMem (CopyDestinationPointer, mPeiSecPlatformPpi, sizeof(mPeiSecPlatf= ormPpi)); // diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLi= b/BaseGpioExpanderLib.c b/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseG= pioExpanderLib/BaseGpioExpanderLib.c index ead1e6df19..3d1856d89e 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/BaseG= pioExpanderLib.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/BaseG= pioExpanderLib.c @@ -1,7 +1,7 @@ /** @file Support for IO expander TCA6424. =20 -Copyright (c) 2017, Intel Corporation. All rights reserved.
+Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -70,12 +70,11 @@ GpioExpGetRegister ( IN UINT8 Register ) { - EFI_STATUS Status; UINT8 WriBuf[1]; UINT8 ReBuf[1] =3D {0}; =20 WriBuf[0] =3D Register; - Status =3D I2cWriteRead( Bar0, TCA6424_I2C_ADDRESS+Address, 1, WriBuf, 1= , ReBuf, WAIT_1_SECOND); + I2cWriteRead (Bar0, TCA6424_I2C_ADDRESS + Address, 1, WriBuf, 1, ReBuf, = WAIT_1_SECOND); =20 return ReBuf[0]; } @@ -99,13 +98,12 @@ GpioExpSetRegister ( IN UINT8 Value ) { - EFI_STATUS Status; UINT8 WriBuf[2]; =20 WriBuf[0] =3D Register; WriBuf[1] =3D Value; - Status =3D I2cWriteRead( Bar0, TCA6424_I2C_ADDRESS+Address, 2, WriBuf, 0= , NULL, WAIT_1_SECOND); =20 + I2cWriteRead (Bar0, TCA6424_I2C_ADDRESS + Address, 2, WriBuf, 0, NULL, W= AIT_1_SECOND); } /** Set the input register to a give value mentioned in the function. --=20 2.16.2.windows.1