From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: nathaniel.l.desimone@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Fri, 23 Aug 2019 15:10:04 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Aug 2019 15:10:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,422,1559545200"; d="scan'208";a="184334503" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga006.jf.intel.com with ESMTP; 23 Aug 2019 15:10:03 -0700 Received: from orsmsx123.amr.corp.intel.com (10.22.240.116) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 23 Aug 2019 15:10:03 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.225]) by ORSMSX123.amr.corp.intel.com ([169.254.1.98]) with mapi id 14.03.0439.000; Fri, 23 Aug 2019 15:09:57 -0700 From: "Nate DeSimone" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Gao, Liming" , "Sinha, Ankit" Subject: Re: [edk2-platforms][PATCH V2 2/2] ClevoOpenBoardPkg: Fix GCC Build Failures Thread-Topic: [edk2-platforms][PATCH V2 2/2] ClevoOpenBoardPkg: Fix GCC Build Failures Thread-Index: AQHVWRXK0Pucm1b3z02mGiVdlfdrX6cJS8Lg Date: Fri, 23 Aug 2019 22:09:56 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEE48055@ORSMSX114.amr.corp.intel.com> References: <20190822181642.25596-1-michael.a.kubacki@intel.com> <20190822181642.25596-3-michael.a.kubacki@intel.com> In-Reply-To: <20190822181642.25596-3-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGFiMWRkNDEtM2I0NS00NWI0LTkyYjYtODhlZGQ4YmMxYmFlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUTAycG9nN1lDOFZQdXhWRnl0WUo5YVplb1FyRGtDejR2M2pIb3hFRmhzOHdpanZMSFg4N0kwUkdrT2N4aWhWZSJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: Kubacki, Michael A=20 Sent: Thursday, August 22, 2019 11:17 AM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Gao, Liming ; Sinha, Ankit Subject: [edk2-platforms][PATCH V2 2/2] ClevoOpenBoardPkg: Fix GCC Build Fa= ilures Fixes build failures on GCC7.3.0. Tested on Ubunutu 18.04.1 LTS. Cc: Nate DeSimone Cc: Liming Gao Cc: Ankit Sinha Signed-off-by: Michael Kubacki --- Platform/Intel/ClevoOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpan= derLib.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/Platform/Intel/ClevoOpenBoardPkg/Library/BaseGpioExpanderLib/B= aseGpioExpanderLib.c b/Platform/Intel/ClevoOpenBoardPkg/Library/BaseGpioExp= anderLib/BaseGpioExpanderLib.c index 260c5bb6a2..cc70f15c24 100644 --- a/Platform/Intel/ClevoOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpio= ExpanderLib.c +++ b/Platform/Intel/ClevoOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpio= ExpanderLib.c @@ -70,12 +70,11 @@ GpioExpGetRegister ( IN UINT8 Register ) { - EFI_STATUS Status; UINT8 WriBuf[1]; UINT8 ReBuf[1] =3D {0}; =20 WriBuf[0] =3D Register; - Status =3D I2cWriteRead( Bar0, TCA6424_I2C_ADDRESS+Address, 1, WriBuf, 1= , ReBuf, WAIT_1_SECOND); + I2cWriteRead (Bar0, TCA6424_I2C_ADDRESS + Address, 1, WriBuf, 1, ReBuf, = WAIT_1_SECOND); =20 return ReBuf[0]; } @@ -99,13 +98,11 @@ GpioExpSetRegister ( IN UINT8 Value ) { - EFI_STATUS Status; UINT8 WriBuf[2]; =20 WriBuf[0] =3D Register; WriBuf[1] =3D Value; - Status =3D I2cWriteRead( Bar0, TCA6424_I2C_ADDRESS+Address, 2, WriBuf, 0= , NULL, WAIT_1_SECOND); - + I2cWriteRead (Bar0, TCA6424_I2C_ADDRESS + Address, 2, WriBuf, 0, NULL, W= AIT_1_SECOND); } /** Set the input register to a give value mentioned in the function. --=20 2.16.2.windows.1